ActionItem137: adjustements in language choosing scheme

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1300 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem137: adjustements in language choosing scheme
git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1300 3f533792-8f58-4932-b0fe-aaf55b0a4547
AntonioTerceiro
1 parent 242b7431
Showing 3 changed files with 28 additions and 14 deletions Show diff stats
app/controllers/application.rb
app/views/shared/language_chooser.rhtml
test/integration/locale_setting_test.rb
@@ -26,7 +26,7 @@ class ApplicationController &lt; ActionController::Base
   include PermissionCheck
   init_gettext 'noosfero'
-  before_init_gettext :set_locale
+  before_init_gettext :force_language
   include NeedsProfile
@@ -62,15 +62,11 @@ class ApplicationController &lt; ActionController::Base
     current_user.person if logged_in?
   end
-  def set_locale
-    locale = cookies[:locale]
-    unless params[:locale].blank?
-      locale = params[:locale]
-    end
-
-    if locale
-      cookies[:locale] = locale
-      GetText.locale = locale
+  def force_language
+    lang = params[:lang]
+    unless lang.blank?
+      cookies[:lang] = lang
+      GetText.locale = lang
     end
   end
@@ -2,6 +2,6 @@
   <% if GetText.locale.to_s == locale_code %>
     <strong><%= locale_name %></strong>
   <% else %>
-    <%= link_to locale_name, { :locale => locale_code }%>
+    <%= link_to locale_name, { :lang => locale_code }%>
   <% end %>
 <% end %>
@@ -2,10 +2,27 @@ require &quot;#{File.dirname(__FILE__)}/../test_helper&quot;
 class LocaleSettingTest < ActionController::IntegrationTest
-  should 'set locale properly' do
+  def setup
+    # reset GetText before every test
+    GetText.locale = nil
+  end
+
+  should 'detect locale from the browser' do
+
+    # user has pt_BR
+    get '/', { }, { 'HTTP_ACCEPT_LANGUAGE' => 'pt-br, en' }
+    assert_equal 'pt_BR', GetText.locale.to_s
+
+    # user now wants en
+    get '/', { }, { 'HTTP_ACCEPT_LANGUAGE' => 'en' }
+    assert_equal 'en', GetText.locale.to_s
+
+  end
+
+  should 'be able to force locale' do
     # set locale to pt_BR
-    get '/', :locale => 'pt_BR'
+    get '/', :lang => 'pt_BR'
     assert_equal 'pt_BR', GetText.locale.to_s
     # locale is kept
@@ -13,7 +30,7 @@ class LocaleSettingTest &lt; ActionController::IntegrationTest
     assert_equal 'pt_BR', GetText.locale.to_s
     # changing back
-    get '/', :locale => 'en'
+    get '/', :lang => 'en'
     assert_equal 'en', GetText.locale.to_s
     # locale is kept again
@@ -23,4 +40,5 @@ class LocaleSettingTest &lt; ActionController::IntegrationTest
   end
+
 end
	@@ -2,6 +2,6 @@		@@ -2,6 +2,6 @@
2	<% if GetText.locale.to_s == locale_code %>	2	<% if GetText.locale.to_s == locale_code %>
3	<strong><%= locale_name %></strong>	3	<strong><%= locale_name %></strong>
4	<% else %>	4	<% else %>
5	- <%= link_to locale_name, { :locale => locale_code }%>	5	+ <%= link_to locale_name, { :lang => locale_code }%>
6	<% end %>	6	<% end %>
7	<% end %>	7	<% end %>