Creates External Profile model for federated users

Larissa Reis
1 parent c383bcdc
Showing 11 changed files with 90 additions and 35 deletions Show diff stats
app/models/abuse_complaint.rb
app/models/abuse_report.rb
app/models/comment.rb
app/models/concerns/human.rb
app/models/concerns/profile_entity.rb
app/models/external_person.rb
app/models/profile.rb
db/migrate/20160420125236_add_type_to_polymorphic_profile_associations.rb
db/migrate/20160420140141_create_external_person.rb
test/unit/comment_test.rb
test/unit/person_test.rb
 class AbuseComplaint < Task
   has_many :abuse_reports, :dependent => :destroy
-  belongs_to :reported, :class_name => "Profile", :foreign_key => "requestor_id"
+  belongs_to :reported, :polymorphic => true, :foreign_key => "requestor_id"
   validates_presence_of :reported
   alias :requestor :reported
@@ -2,7 +2,7 @@ class AbuseReport &lt; ApplicationRecord
   attr_accessible :content, :reason
-  belongs_to :reporter, :class_name => 'Person'
+  belongs_to :reporter, :polymorphic => true
   belongs_to :abuse_complaint
   has_many :reported_images, :dependent => :destroy
@@ -15,7 +15,7 @@ class Comment &lt; ApplicationRecord
   alias :article= :source=
   attr_accessor :follow_article
-  belongs_to :author, :class_name => 'Person', :foreign_key => 'author_id'
+  belongs_to :author, :polymorphic => true, :foreign_key => 'author_id'
   has_many :children, :class_name => 'Comment', :foreign_key => 'reply_of_id', :dependent => :destroy
   belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'
@@ -2,15 +2,15 @@ module Human
   extend ActiveSupport::Concern
   included do
-    has_many :comments, :foreign_key => :author_id
-    has_many :abuse_reports, :foreign_key => 'reporter_id', :dependent => :destroy
+    has_many :comments, :as => :author, :foreign_key => :author_id
+    has_many :abuse_reports, :as => :reporter, :foreign_key => 'reporter_id', :dependent => :destroy
     scope :abusers, -> {
-      joins(:abuse_complaints).where('tasks.status = 3').distinct.select('profiles.*')
+      joins(:abuse_complaints).where('tasks.status = 3').distinct.select("#{self.table_name}.*")
     }
     scope :non_abusers, -> {
-      distinct.select("profiles.*").
-      joins("LEFT JOIN tasks ON profiles.id = tasks.requestor_id AND tasks.type='AbuseComplaint'").
+      distinct.select("#{self.table_name}.*").
+      joins("LEFT JOIN tasks ON #{self.table_name}.id = tasks.requestor_id AND tasks.type='AbuseComplaint'").
       where("tasks.status != 3 OR tasks.id is NULL")
     }
   end
@@ -2,14 +2,15 @@ module ProfileEntity
   extend ActiveSupport::Concern
   included do
-    attr_accessible :name, :identifier, :environment, :redirection_after_login
+    attr_accessible :name, :identifier, :environment
     validates_presence_of :identifier, :name
-    validates_inclusion_of :redirection_after_login, :in => Environment.login_redirection_options.keys, :allow_nil => true
     belongs_to :environment
     has_many :search_terms, :as => :context
-    has_many :abuse_complaints, :foreign_key => 'requestor_id', :dependent => :destroy
+    has_many :abuse_complaints, :as => :reported, :foreign_key => 'requestor_id', :dependent => :destroy
+
+    before_create :set_default_environment
   end
@@ -23,11 +24,15 @@ module ProfileEntity
     self.save
   end
-  def preferred_login_redirection
-    redirection_after_login.blank? ? environment.redirection_after_login : redirection_after_login
-  end
-
   def opened_abuse_complaint
     abuse_complaints.opened.first
   end
+
+  def set_default_environment
+    if self.environment.nil?
+      self.environment = Environment.default
+    end
+    true
+  end
+
 end
 # A pseudo profile is a person from a remote network
-class ExternalPerson
+class ExternalPerson < ActiveRecord::Base
   include Human
   include ProfileEntity
+  validates_uniqueness_of :identifier, scope: :source
+
+  attr_accessible :source, :email_md5_hash
+
+  def self.get_or_create(webfinger)
+    user = ExternalPerson.find_by(identifier: webfinger.identifier, source: webfinger.domain)
+    if user.nil?
+      user = ExternalPerson.create!(identifier: webfinger.identifier,
+                                    name: webfinger.name,
+                                    source: webfinger.domain,
+                                    email_md5_hash: webfinger.email_md5
+                                   )
+    end
+    user
+  end
+
+  def url
+    "http://#{self.source}/#{self.identifier}"
+  end
+
+  def avatar
+    "http://#{self.source}/plugin/gravatar_provider/h/#{self.email_md5_hash}"
+  end
+
+  def preferred_login_redirection
+    environment.redirection_after_login
+  end
+
 end
@@ -6,7 +6,7 @@ class Profile &lt; ApplicationRecord
   include ProfileEntity
   attr_accessible :public_profile, :nickname, :custom_footer, :custom_header, :address, :zip_code, :contact_phone, :image_builder, :description, :closed, :template_id, :lat, :lng, :is_template, :fields_privacy, :preferred_domain_id, :category_ids, :country, :city, :state, :national_region_code, :email, :contact_email, :redirect_l10n, :notification_time,
-    :custom_url_redirection, :email_suggestions, :allow_members_to_invite, :invite_friends_only, :secret, :profile_admin_mail_notification
+    :custom_url_redirection, :email_suggestions, :allow_members_to_invite, :invite_friends_only, :secret, :profile_admin_mail_notification, :redirection_after_login
   # use for internationalizable human type names in search facets
   # reimplement on subclasses
@@ -411,14 +411,6 @@ class Profile &lt; ApplicationRecord
     end
   end
-  before_create :set_default_environment
-  def set_default_environment
-    if self.environment.nil?
-      self.environment = Environment.default
-    end
-    true
-  end
-
   # registar callback for creating boxes after the object is created.
   after_create :create_default_set_of_boxes
@@ -1103,6 +1095,10 @@ private :generate_url, :url_options
     display_private_info_to?(current_person) || (public_fields.include?(field) && public?)
   end
+  validates_inclusion_of :redirection_after_login, :in => Environment.login_redirection_options.keys, :allow_nil => true
+  def preferred_login_redirection
+    redirection_after_login.blank? ? environment.redirection_after_login : redirection_after_login
+  end
   settings_items :custom_url_redirection, type: String, default: nil
   def remove_from_suggestion_list(person)
@@ -0,0 +1,17 @@
+class AddTypeToPolymorphicProfileAssociations < ActiveRecord::Migration
+  def up
+    add_column :tasks, :reported_type, :string
+    add_column :abuse_reports, :reporter_type, :string
+    add_column :comments, :author_type, :string
+
+    update("UPDATE tasks SET reported_type='Profile'")
+    update("UPDATE abuse_reports SET reporter_type='Person'")
+    update("UPDATE comments SET author_type='Person'")
+  end
+
+  def down
+    remove_column :abuse_complaints, :reported_type
+    remove_column :abuse_reports, :reporter_type
+    remove_column :comments, :author_type
+  end
+end
@@ -0,0 +1,12 @@
+class CreateExternalPerson < ActiveRecord::Migration
+  def change
+    create_table :external_people do |t|
+      t.string :name
+      t.string :identifier
+      t.string :source
+      t.string :email_md5_hash
+      t.integer :environment_id
+      t.boolean :visible, default: true
+    end
+  end
+end
@@ -23,17 +23,14 @@ class CommentTest &lt; ActiveSupport::TestCase
     end
   end
-  should 'record authenticated author' do
+  should 'record authenticated author polymorphically' do
     c = Comment.new
-    assert_raise ActiveRecord::AssociationTypeMismatch do
-      c.author = 1
-    end
-    assert_raise ActiveRecord::AssociationTypeMismatch do
-      c.author = Profile
-    end
     assert_nothing_raised do
       c.author = Person.new
     end
+    assert_nothing_raised do
+      c.author = ExternalPerson.new
+    end
   end
   should 'record unauthenticated author' do
@@ -1831,9 +1831,9 @@ class PersonTest &lt; ActiveSupport::TestCase
     p1 = fast_create(Person)
     p2 = fast_create(Person)
     article = fast_create(Article)
-    c1 = fast_create(Comment, :source_id => article.id, :author_id => p1.id)
-    c2 = fast_create(Comment, :source_id => article.id, :author_id => p2.id)
-    c3 = fast_create(Comment, :source_id => article.id, :author_id => p1.id)
+    c1 = fast_create(Comment, :source_id => article.id, :author_id => p1.id, :author_type => 'Profile')
+    c2 = fast_create(Comment, :source_id => article.id, :author_id => p2.id, :author_type => 'Profile')
+    c3 = fast_create(Comment, :source_id => article.id, :author_id => p1.id, :author_type => 'Profile')
     assert_equivalent [c1,c3], p1.comments
   end
1	class AbuseComplaint < Task	1	class AbuseComplaint < Task
2	has_many :abuse_reports, :dependent => :destroy	2	has_many :abuse_reports, :dependent => :destroy
3	- belongs_to :reported, :class_name => "Profile", :foreign_key => "requestor_id"	3	+ belongs_to :reported, :polymorphic => true, :foreign_key => "requestor_id"
4		4
5	validates_presence_of :reported	5	validates_presence_of :reported
6	alias :requestor :reported	6	alias :requestor :reported
	@@ -2,7 +2,7 @@ class AbuseReport < ApplicationRecord		@@ -2,7 +2,7 @@ class AbuseReport < ApplicationRecord
2		2
3	attr_accessible :content, :reason	3	attr_accessible :content, :reason
4		4
5	- belongs_to :reporter, :class_name => 'Person'	5	+ belongs_to :reporter, :polymorphic => true
6	belongs_to :abuse_complaint	6	belongs_to :abuse_complaint
7	has_many :reported_images, :dependent => :destroy	7	has_many :reported_images, :dependent => :destroy
8		8
	@@ -15,7 +15,7 @@ class Comment < ApplicationRecord		@@ -15,7 +15,7 @@ class Comment < ApplicationRecord
15	alias :article= :source=	15	alias :article= :source=
16	attr_accessor :follow_article	16	attr_accessor :follow_article
17		17
18	- belongs_to :author, :class_name => 'Person', :foreign_key => 'author_id'	18	+ belongs_to :author, :polymorphic => true, :foreign_key => 'author_id'
19	has_many :children, :class_name => 'Comment', :foreign_key => 'reply_of_id', :dependent => :destroy	19	has_many :children, :class_name => 'Comment', :foreign_key => 'reply_of_id', :dependent => :destroy
20	belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'	20	belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'
21		21
1	# A pseudo profile is a person from a remote network	1	# A pseudo profile is a person from a remote network
2	-class ExternalPerson	2	+class ExternalPerson < ActiveRecord::Base
3		3
4	include Human	4	include Human
5	include ProfileEntity	5	include ProfileEntity
6		6
		7	+ validates_uniqueness_of :identifier, scope: :source
		8	+
		9	+ attr_accessible :source, :email_md5_hash
		10	+
		11	+ def self.get_or_create(webfinger)
		12	+ user = ExternalPerson.find_by(identifier: webfinger.identifier, source: webfinger.domain)
		13	+ if user.nil?
		14	+ user = ExternalPerson.create!(identifier: webfinger.identifier,
		15	+ name: webfinger.name,
		16	+ source: webfinger.domain,
		17	+ email_md5_hash: webfinger.email_md5
		18	+ )
		19	+ end
		20	+ user
		21	+ end
		22	+
		23	+ def url
		24	+ "http://#{self.source}/#{self.identifier}"
		25	+ end
		26	+
		27	+ def avatar
		28	+ "http://#{self.source}/plugin/gravatar_provider/h/#{self.email_md5_hash}"
		29	+ end
		30	+
		31	+ def preferred_login_redirection
		32	+ environment.redirection_after_login
		33	+ end
		34	+
7	end	35	end
@@ -0,0 +1,17 @@		@@ -0,0 +1,17 @@
	1	+class AddTypeToPolymorphicProfileAssociations < ActiveRecord::Migration
	2	+ def up
	3	+ add_column :tasks, :reported_type, :string
	4	+ add_column :abuse_reports, :reporter_type, :string
	5	+ add_column :comments, :author_type, :string
	6	+
	7	+ update("UPDATE tasks SET reported_type='Profile'")
	8	+ update("UPDATE abuse_reports SET reporter_type='Person'")
	9	+ update("UPDATE comments SET author_type='Person'")
	10	+ end
	11	+
	12	+ def down
	13	+ remove_column :abuse_complaints, :reported_type
	14	+ remove_column :abuse_reports, :reporter_type
	15	+ remove_column :comments, :author_type
	16	+ end
	17	+end
@@ -0,0 +1,12 @@		@@ -0,0 +1,12 @@
	1	+class CreateExternalPerson < ActiveRecord::Migration
	2	+ def change
	3	+ create_table :external_people do \|t\|
	4	+ t.string :name
	5	+ t.string :identifier
	6	+ t.string :source
	7	+ t.string :email_md5_hash
	8	+ t.integer :environment_id
	9	+ t.boolean :visible, default: true
	10	+ end
	11	+ end
	12	+end