Download as
Browse Code »

Commit 9f59e9402ae678b0137a9e24acc29d2ef7d6340d

Authored by Leandro Santos
Committed by Antonio Terceiro
1 parent 3d6c66d5
Exists in staging and in 42 other branches all_pending_tasks_api, api-articles-period, api_roles, caching-rails4, captcha_serpro_plugin, comments_permissions, content-manager-hostspot, elasticsearch, elasticsearch_api, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export-comment-paragraph, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, fix_event_date_issue, fix_notification_email, fix_string_downcase_and_upcase, follower_permition, json_cookie_serializer, login-captcha, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, production-vendorized, profile_api_improvements, tasks_keep_filter_params, user_mention, webfinger_server

refactoring test 'update external feed'

Showing 3 changed files with 11 additions and 1 deletions   Show diff stats
app/models/rss_feed.rb
  Diff comments   View file @9f59e94
... ... @@ -19,6 +19,8 @@ class RssFeed < Article
19 19 settings[:limit] || 10
20 20 end
21 21 def limit=(value)
  22 + #UPGRADE Leandro: I add this line to save the serialize attribute
  23 + self.body_will_change!
22 24 settings[:limit] = value
23 25 end
24 26  
... ...
lib/acts_as_having_settings.rb
  Diff comments   View file @9f59e94
... ... @@ -31,6 +31,10 @@ module ActsAsHavingSettings
31 31 val.nil? ? (#{default}.is_a?(String) ? gettext(#{default}) : #{default}) : val
32 32 end
33 33 def #{setting}=(value)
  34 +
  35 + #UPGRADE Leandro: I add this line to save the serialize attribute
  36 + send(self.class.settings_field.to_s + '_will_change!')
  37 +
34 38 send(self.class.settings_field)[:#{setting}] = self.class.acts_as_having_settings_type_cast(value, #{data_type.inspect})
35 39 end
36 40 CODE
... ...
test/unit/blog_test.rb
  Diff comments   View file @9f59e94
... ... @@ -113,7 +113,11 @@ class BlogTest < ActiveSupport::TestCase
113 113 should 'update external feed' do
114 114 p = create_user('testuser').person
115 115 blog = Blog.new(:profile => p, :name => 'Blog test')
116   - blog.create_external_feed(:address => 'feed address')
  116 + blog.save
  117 + e = ExternalFeed.new(:address => 'feed address')
  118 + e.blog = blog
  119 + e.save
  120 + blog.reload
117 121 blog.external_feed_builder = { :address => 'address edited' }
118 122 blog.save!
119 123 assert_equal 'address edited', blog.external_feed.address
... ...