Download as
Browse Code »

Commit a2a9a8bb828a489dede9ffd26279ff0a19174018

Authored by Marcos Pereira
2 parents 2a82a686 0b6f316d
Exists in staging and in 31 other branches all_pending_tasks_api, api-articles-period, api_roles, comments_permissions, elasticsearch, elasticsearch_api, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, fix_notification_email, follower_permition, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, profile_api_improvements, user_mention

Merge branch 'articles-children-api' into 'master' 

api: list only published children when get an article



See merge request !895
Showing 2 changed files with 10 additions and 1 deletions   Show diff stats
lib/noosfero/api/entities.rb
  Diff comments   View file @a2a9a8b
... ... @@ -203,7 +203,7 @@ module Noosfero
203 203 root 'articles', 'article'
204 204 expose :parent, :using => ArticleBase
205 205 expose :children, :using => ArticleBase do |article, options|
206   - article.children.limit(Noosfero::API::V1::Articles::MAX_PER_PAGE)
  206 + article.children.published.limit(Noosfero::API::V1::Articles::MAX_PER_PAGE)
207 207 end
208 208 end
209 209  
... ...
test/api/articles_test.rb
  Diff comments   View file @a2a9a8b
... ... @@ -735,4 +735,13 @@ class ArticlesTest < ActiveSupport::TestCase
735 735 assert_not_includes json["article"].keys, "comments"
736 736 end
737 737  
  738 + should 'not list private child when get the parent article' do
  739 + person = fast_create(Person, :environment_id => environment.id)
  740 + article = fast_create(Article, :profile_id => person.id, :name => "Some thing")
  741 + child = fast_create(Article, :parent_id => article.id, :profile_id => person.id, :name => "Some thing", :published => false)
  742 + get "/api/v1/articles/#{article.id}?#{params.to_query}"
  743 + json = JSON.parse(last_response.body)
  744 + assert_not_includes json['article']['children'].map {|a| a['id']}, child.id
  745 + end
  746 +
738 747 end
... ...