Commit bbad555fdd3f427119f697f035ce8984113ba34a
1 parent
16c36447
Exists in
staging
and in
42 other branches
[search-improvements] Use only enabled assets
Also removing events from assets list since it has no search (yet).
Showing
2 changed files
with
23 additions
and
14 deletions
Show diff stats
app/controllers/public/search_controller.rb
| @@ -173,13 +173,21 @@ class SearchController < PublicController | @@ -173,13 +173,21 @@ class SearchController < PublicController | ||
| 173 | end | 173 | end |
| 174 | end | 174 | end |
| 175 | 175 | ||
| 176 | + AVAILABLE_SEARCHES = ActiveSupport::OrderedHash[ | ||
| 177 | + :articles, _('Contents'), | ||
| 178 | + :enterprises, _('Enterprises'), | ||
| 179 | + :people, _('People'), | ||
| 180 | + :communities, _('Communities'), | ||
| 181 | + :products, _('Products and Services'), | ||
| 182 | + ] | ||
| 183 | + | ||
| 176 | def load_search_assets | 184 | def load_search_assets |
| 177 | - if SEARCHES.keys.include?(params[:action].to_sym) && environment.enabled?("disable_asset_#{params[:action]}") | 185 | + if AVAILABLE_SEARCHES.keys.include?(params[:action].to_sym) && environment.enabled?("disable_asset_#{params[:action]}") |
| 178 | render_not_found | 186 | render_not_found |
| 179 | return | 187 | return |
| 180 | end | 188 | end |
| 181 | 189 | ||
| 182 | - @enabled_searches = SEARCHES.select {|key, name| environment.disabled?("disable_asset_#{key}") } | 190 | + @enabled_searches = AVAILABLE_SEARCHES.select {|key, name| environment.disabled?("disable_asset_#{key}") } |
| 183 | @searching = {} | 191 | @searching = {} |
| 184 | @titles = {} | 192 | @titles = {} |
| 185 | @enabled_searches.each do |key, name| | 193 | @enabled_searches.each do |key, name| |
| @@ -191,7 +199,7 @@ class SearchController < PublicController | @@ -191,7 +199,7 @@ class SearchController < PublicController | ||
| 191 | 199 | ||
| 192 | def load_order | 200 | def load_order |
| 193 | @order = 'more_recent' | 201 | @order = 'more_recent' |
| 194 | - if SEARCHES.keys.include?(@asset.to_sym) | 202 | + if AVAILABLE_SEARCHES.keys.include?(@asset.to_sym) |
| 195 | available_orders = asset_class(@asset)::SEARCH_FILTERS[:order] | 203 | available_orders = asset_class(@asset)::SEARCH_FILTERS[:order] |
| 196 | @order = params[:order] if available_orders.include?(params[:order]) | 204 | @order = params[:order] if available_orders.include?(params[:order]) |
| 197 | end | 205 | end |
| @@ -232,4 +240,14 @@ class SearchController < PublicController | @@ -232,4 +240,14 @@ class SearchController < PublicController | ||
| 232 | 20 | 240 | 20 |
| 233 | end | 241 | end |
| 234 | 242 | ||
| 243 | + def available_assets | ||
| 244 | + assets = ActiveSupport::OrderedHash[ | ||
| 245 | + :articles, _('Contents'), | ||
| 246 | + :enterprises, _('Enterprises'), | ||
| 247 | + :people, _('People'), | ||
| 248 | + :communities, _('Communities'), | ||
| 249 | + :products, _('Products and Services'), | ||
| 250 | + ] | ||
| 251 | + end | ||
| 252 | + | ||
| 235 | end | 253 | end |
app/helpers/search_helper.rb
| @@ -5,15 +5,6 @@ module SearchHelper | @@ -5,15 +5,6 @@ module SearchHelper | ||
| 5 | BLOCKS_SEARCH_LIMIT = 24 | 5 | BLOCKS_SEARCH_LIMIT = 24 |
| 6 | MULTIPLE_SEARCH_LIMIT = 8 | 6 | MULTIPLE_SEARCH_LIMIT = 8 |
| 7 | 7 | ||
| 8 | - SEARCHES = ActiveSupport::OrderedHash[ | ||
| 9 | - :articles, _('Contents'), | ||
| 10 | - :enterprises, _('Enterprises'), | ||
| 11 | - :people, _('People'), | ||
| 12 | - :communities, _('Communities'), | ||
| 13 | - :products, _('Products and Services'), | ||
| 14 | - :events, _('Events'), | ||
| 15 | - ] | ||
| 16 | - | ||
| 17 | FILTERS_TRANSLATIONS = { | 8 | FILTERS_TRANSLATIONS = { |
| 18 | :order => _('Order'), | 9 | :order => _('Order'), |
| 19 | :display => _('Display') | 10 | :display => _('Display') |
| @@ -118,7 +109,7 @@ module SearchHelper | @@ -118,7 +109,7 @@ module SearchHelper | ||
| 118 | end | 109 | end |
| 119 | 110 | ||
| 120 | def assets_menu(selected) | 111 | def assets_menu(selected) |
| 121 | - assets = SEARCHES.keys | 112 | + assets = @enabled_searches.keys |
| 122 | content_tag('ul', | 113 | content_tag('ul', |
| 123 | assets.map do |asset| | 114 | assets.map do |asset| |
| 124 | options = {} | 115 | options = {} |
| @@ -129,7 +120,7 @@ module SearchHelper | @@ -129,7 +120,7 @@ module SearchHelper | ||
| 129 | end | 120 | end |
| 130 | 121 | ||
| 131 | def asset_link(asset) | 122 | def asset_link(asset) |
| 132 | - link_to(SEARCHES[asset], "/search/#{asset}") | 123 | + link_to(@enabled_searches[asset], "/search/#{asset}") |
| 133 | end | 124 | end |
| 134 | 125 | ||
| 135 | end | 126 | end |