Download as
Browse Code »

Commit cf3280640a4bb5986167a40f2e6c17035490e64d

Authored by Antonio Terceiro
1 parent 2161fb73
Exists in staging and in 42 other branches all_pending_tasks_api, api-articles-period, api_roles, caching-rails4, captcha_serpro_plugin, comments_permissions, content-manager-hostspot, elasticsearch, elasticsearch_api, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export-comment-paragraph, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, fix_event_date_issue, fix_notification_email, fix_string_downcase_and_upcase, follower_permition, json_cookie_serializer, login-captcha, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, production-vendorized, profile_api_improvements, tasks_keep_filter_params, user_mention, webfinger_server

Only warn user if actually changing the URL 

(ActionItem1258)
Showing 1 changed file with 10 additions and 2 deletions   Show diff stats
public/javascripts/application.js
  Diff comments   View file @cf32806
... ... @@ -48,8 +48,16 @@ function convToValidIdentifier( str, sep ) {
48 48  
49 49 function updateUrlField(name_field, id) {
50 50 url_field = $(id);
51   - url_field.value = convToValidIdentifier(name_field.value, "-");
52   - warn_value_change(url_field);
  51 + old_url_value = url_field.value;
  52 + new_url_value = convToValidIdentifier(name_field.value, "-");
  53 +
  54 + url_field.value = new_url_value;
  55 +
  56 + if (!/^\s*$/.test(old_url_value)
  57 + && old_url_value != new_url_value
  58 + ) {
  59 + warn_value_change(url_field);
  60 + }
53 61 }
54 62  
55 63 function show_warning(field, message) {
... ...