Commit
f49dbb2e6fe689f008864e6f1a0e786b98e2043d
Exists in
staging
and in
42 other branches
all_pending_tasks_api, api-articles-period, api_roles, caching-rails4, captcha_serpro_plugin, comments_permissions, content-manager-hostspot, elasticsearch, elasticsearch_api, elasticsearch_categories, elasticsearch_filter, elasticsearch_sort, elasticsearch_to_merge, elasticsearch_view, environment-exposes-api, export-comment-api, export-comment-paragraph, export_data, external_followers, federation-webfinger, federation_followers, federation_followers_backend, federation_oauth_provider, federation_webfinger, fix_event_date_issue, fix_notification_email, fix_string_downcase_and_upcase, follower_permition, json_cookie_serializer, login-captcha, master, master_profile_followers, oauth_external_login, oauth_login, private-scraps, private-scraps-rebase, production, production-vendorized, profile_api_improvements, tasks_keep_filter_params, user_mention, webfinger_server
Marking comments as ham atomically
ActionItem2306
| @@ -204,4 +204,9 @@ class Comment < ActiveRecord::Base |
| @@ -204,4 +204,9 @@ class Comment < ActiveRecord::Base |
204
| self.save! |
204
| self.save! |
205
| end |
205
| end |
206
| |
206
| |
| |
207
| + def ham! |
| |
208
| + self.spam = false |
| |
209
| + self.save! |
| |
210
| + end |
| |
211
| + |
207
| end |
212
| end |
| @@ -460,4 +460,11 @@ class CommentTest < ActiveSupport::TestCase |
| @@ -460,4 +460,11 @@ class CommentTest < ActiveSupport::TestCase |
460
| assert_equivalent [c3], Comment.spam |
460
| assert_equivalent [c3], Comment.spam |
461
| end |
461
| end |
462
| |
462
| |
| |
463
| + should 'be able to mark as ham atomically' do |
| |
464
| + c1 = fast_create(Comment, :name => 'foo', :email => 'foo@example.com', :spam => true) |
| |
465
| + c1.ham! |
| |
466
| + c1.reload |
| |
467
| + assert c1.ham? |
| |
468
| + end |
| |
469
| + |
463
| end |
470
| end |