16 Mar, 2016
4 commits
-
this avoid colateral errors in others tests refers to commit: 1af11191ddb2da6ea93ea86ce7fbbb9a089feaf7
-
This reverts commit 23bd8bbc2293d5123bbcb4b416143934edf23abc. I found a way to fix the problem using `alias_method`
-
related issue: #181
15 Mar, 2016
4 commits
-
we must avoid using Date.today and DateTime.now in tests cases, they can return yesterday or tomorrow depending on the machine's time zone and ignores the configured Rails timezone reference: http://www.elabs.se/blog/36-working-with-time-zones-in-ruby-on-rails
-
it seems that a 'mock object' is false in a `if` block
-
Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> Signed-off-by: Gustavo Jaruga <darkshades@gmail.com>
-
Decouple html creation from models into helpers This is a work started by @joenio and continued by @danielafeitosa for which I have just fixed failling tests and some minor issues created by the refactor. This MR adds just the fixes that do not involve plugins. As I've discussed with @diguliu there ill be separate MRs for plugins allowing easier review e clean merges. See merge request !803
12 Mar, 2016
1 commit
10 Mar, 2016
21 commits
-
This is one more step into decoupling HTML generation from models. All models with such method are expected to go through this refactor.
-
After creating the ArticleBlock view test at ff15413b2a8dca45d9f64e57270f294e351a0098 this test got broken. The root cause was the inclusion of ApplicationHelper for the article_block_test which led to `custom_options_article` for CMSHelper tests to fail as the BlogHelper (included by ApplicationHelper) was overriding the method. This has been fized by remove the include to ApplicationHelper and extract the necessary methods to separate helpers which led to two new methods for ArticleHelper and one new helper the ButtonsHelper.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers. This was inspired by the same conversion made by commit 23cca52cdaea5cc3b46e4982f30ad3426891e2f2 on MyNetworkBlock test.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers. The view required fix at the html escaping method call synthax.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content. The view required fixes as it was still supposing the old interface coupled into the model instead of receiving the model object. And it had a programming error that prevented results from getting displayed.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers. This was inspired by the same conversion made by commit 23cca52cdaea5cc3b46e4982f30ad3426891e2f2 on MyNetworkBlock test.
-
By removing the content method, it is now necessary to turn the test into a view one. This was inspired by the same conversion made by commit 23cca52cdaea5cc3b46e4982f30ad3426891e2f2 on MyNetworkBlock test.
-
After the extraction of HTML dependencies into helpers it has been broken.
09 Mar, 2016
3 commits
08 Mar, 2016
1 commit
-
Closes !511
03 Mar, 2016
2 commits
-
Added filter section on profile members list - Adds use of filtered members to mailing queue executed by send_mail action Signed-off-by: Gustavo Jaruga <darksshades@gmail.com> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> Signed-off-by: Michel Felipe de Oliveira Ferreira <michel.ferreira@serpro.gov.br> See merge request !800
-
Signed-off-by: Gustavo Jaruga <darkshades@gmail.com> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com>
29 Feb, 2016
1 commit
26 Feb, 2016
1 commit
-
- Adds use of filtered members to mailing queue executed by send_mail action Signed-off-by: Gustavo Jaruga <darksshades@gmail.com> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> Signed-off-by: Michel Felipe de Oliveira Ferreira <michel.ferreira@serpro.gov.br>
25 Feb, 2016
2 commits
-
Fix article comments ordering Fix article's comments ordering bug (had wrong logic before correction) and pagination missing bug (js was overwriting pagination after ajax request). References: https://softwarepublico.gov.br/gitlab/softwarepublico/softwarepublico/issues/630 https://softwarepublico.gov.br/gitlab/softwarepublico/softwarepublico/issues/632 See merge request !792
-
Dbm private files Also rewriting the file visualization to work consistently with every file type. Here is the overall basic behavior now: * If the request is passed with view=true, content is displayed as an article content. * If the file has an inline visualization (like images) it's already displayed. * If not, a download link is displayed. * If the request is passed with view=false, the file is provided straight, without any noosfero layout being loaded. * If the file is private: * And the user accesses its public filesystem path, apache (this is done by noosfero-apache) will redirect the request to rails path so that the rails server will provide it considering appropriate permissions. * And the user accesses its rails path, rails server will provide as well. * If the file is public: * And the user accesses its public filesystem path, apache will provide the file. * And the user accesses its rails path, rails server will redirect to its public filesystem path so that apache provides the file. The feature and debian package were tested and are still available for testing on: http://private-files.dev.colivre.net See merge request !797
