optimize creation of seed ideas

we have some callbacks on choice creation, that we don't need to run after every single choice when creating them in a batch. Instead we can just make sure the last choice in the batch runs the required callbacks.

optimize creation of seed ideas
we have some callbacks on choice creation, that we don't need to run after every single choice when creating them in a batch. Instead we can just make sure the last choice in the batch runs the required callbacks.
Luke Baker
1 parent 6a94e874
Showing 2 changed files with 13 additions and 6 deletions Show diff stats
app/models/choice.rb
app/models/question.rb
@@ -26,17 +26,22 @@ class Choice &lt; ActiveRecord::Base
   attr_protected :prompts_count, :wins, :losses, :score, :prompts_on_the_right_count, :prompts_on_the_left_count
   attr_readonly :question_id
+  attr_accessor :part_of_batch_create
   def update_questions_counter
-    self.question.update_attribute(:inactive_choices_count, self.question.choices.inactive.length)
+    unless part_of_batch_create
+      self.question.update_attribute(:inactive_choices_count, self.question.choices.inactive.length)
+    end
   end 
   # if changing a choice to active, we want to regenerate prompts
   def update_prompt_queue
-    if self.changed.include?('active') && self.active?
-      self.question.mark_prompt_queue_for_refill
-      if self.question.choices.size - self.question.inactive_choices_count > 1 && self.question.uses_catchup?
-        self.question.send_later :add_prompt_to_queue
+    unless part_of_batch_create
+      if self.changed.include?('active') && self.active?
+        self.question.mark_prompt_queue_for_refill
+        if self.question.choices.size - self.question.inactive_choices_count > 1 && self.question.uses_catchup?
+          self.question.send_later :add_prompt_to_queue
+        end
       end
     end
   end
@@ -45,7 +45,9 @@ class Question &lt; ActiveRecord::Base
   def create_choices_from_ideas
     if ideas && ideas.any?
       ideas.each do |idea|
-  choices.create!(:creator => self.creator, :active => true, :data => idea.squish.strip)
+        # all but last is considered part of batch create, so the
+        # last one will fire things that only need to be run at the end
+        choices.create!(:creator => self.creator, :active => true, :data => idea.squish.strip, :part_of_batch_create => idea != ideas.last, :question => self)
       end
     end
   end