Refactoring update to work instead of update_from_abroad

Dhruv Kapadia
1 parent 8139c736
Showing 3 changed files with 13 additions and 10 deletions Show diff stats
app/controllers/choices_controller.rb
app/models/choice.rb
config/initializers/noisy_attr_accessible.rb
@@ -74,8 +74,6 @@ class ChoicesController &lt; InheritedResources::Base
           options[:builder].tag!('choice_status', the_status) }
         logger.info "successfully saved the choice #{@choice.inspect}"
-	Question.update_counters(@question.id, :inactive_choices_count => @choice.active? ? 0 : 1)
-
 	visitor_votes = Proc.new { |options| options[:builder].tag!('visitor_votes', visitor.votes.count(:conditions => {:question_id => @question.id})) }
         visitor_ideas = Proc.new { |options| options[:builder].tag!('visitor_ideas', visitor.items.count) }
@@ -204,6 +202,13 @@ class ChoicesController &lt; InheritedResources::Base
     end
   end
+
+  def update
+    # prevent AttributeNotFound error and only update actual Choice columns, since we add extra information in 'show' method
+    choice_attributes = Choice.new.attribute_names
+    params[:choice] = params[:choice].delete_if {|key, value| !choice_attributes.include?(key)}
+    update!
+  end
@@ -14,7 +14,12 @@ class Choice &lt; ActiveRecord::Base
   has_many :prompts_on_the_right, :class_name => "Prompt", :foreign_key => "right_choice_id"
   named_scope :active, :conditions => { :active => true }
   named_scope :inactive, :conditions => { :active => false}
-  
+ 
+  after_save :update_questions_counter
+
+  def update_questions_counter
+    self.question.update_attribute(:inactive_choices_count, self.question.choices.inactive.length)
+  end 
   #attr_accessor :data
   def question_name
@@ -105,7 +110,6 @@ class Choice &lt; ActiveRecord::Base
   def activate!
     (self.active = true)
     self.save!
-    Question.update_counters(self.question_id, :inactive_choices_count => -1)
   end
   def suspend!
@@ -116,7 +120,6 @@ class Choice &lt; ActiveRecord::Base
   def deactivate!
     (self.active = false)
     self.save!
-    Question.update_counters(self.question_id, :inactive_choices_count => 1)
   end
   protected
@@ -1,5 +0,0 @@
-ActiveRecord::Base.class_eval do
-  def log_protected_attribute_removal(*attributes)
-    raise "Can't mass-assign these protected attributes: #{attributes.join(', ')}"
-  end
-end
	@@ -1,5 +0,0 @@	@@ -1,5 +0,0 @@
1	-ActiveRecord::Base.class_eval do
2	- def log_protected_attribute_removal(*attributes)
3	- raise "Can't mass-assign these protected attributes: #{attributes.join(', ')}"
4	- end
5	-end