retab spacing Question

Luke Baker
1 parent 2372de54
Showing 1 changed file with 211 additions and 211 deletions Show diff stats
app/models/question.rb
@@ -36,7 +36,7 @@ class Question &lt; ActiveRecord::Base
   def create_choices_from_ideas
     if ideas && ideas.any?
       ideas.each do |idea|
-	choices.create!(:creator => self.creator, :active => true, :data => idea.squish.strip)
+  choices.create!(:creator => self.creator, :active => true, :data => idea.squish.strip)
       end
     end
   end
@@ -48,27 +48,27 @@ class Question &lt; ActiveRecord::Base
   def choose_prompt(options = {})
           # if there is one or fewer active choices, we won't be able to find a prompt
-	  if self.choices.size - self.inactive_choices_count <= 1 
-		  raise RuntimeError, "More than one choice needs to be active"
-	  end
-
-	  if self.uses_catchup? || options[:algorithm] == "catchup"
-	      logger.info("Question #{self.id} is using catchup algorithm!")
-	      next_prompt = self.pop_prompt_queue
-	      if next_prompt.nil?
-		      logger.info("DEBUG Catchup prompt cache miss! Nothing in prompt_queue")
-		      next_prompt = self.catchup_choose_prompt
-		      record_prompt_cache_miss
-	      else
-		      record_prompt_cache_hit
-	      end
-	      self.send_later :add_prompt_to_queue
-	      return next_prompt
-	  else
-	      #Standard choose prompt at random
+    if self.choices.size - self.inactive_choices_count <= 1 
+      raise RuntimeError, "More than one choice needs to be active"
+    end
+
+    if self.uses_catchup? || options[:algorithm] == "catchup"
+        logger.info("Question #{self.id} is using catchup algorithm!")
+        next_prompt = self.pop_prompt_queue
+        if next_prompt.nil?
+          logger.info("DEBUG Catchup prompt cache miss! Nothing in prompt_queue")
+          next_prompt = self.catchup_choose_prompt
+          record_prompt_cache_miss
+        else
+          record_prompt_cache_hit
+        end
+        self.send_later :add_prompt_to_queue
+        return next_prompt
+    else
+        #Standard choose prompt at random
               next_prompt = self.picked_prompt
-	      return next_prompt
-	  end
+        return next_prompt
+    end
   end
@@ -92,16 +92,16 @@ class Question &lt; ActiveRecord::Base
    prompt = nil
    until prompt && prompt.active?
-	   target = rand 
-	   left_choice_id = right_choice_id = nil
-
-	   weighted.each do |item, weight|
-		   if target <= weight
-			   left_choice_id, right_choice_id = item.split(", ")
-			   break
-		   end
-		   target -= weight
-	   end
+     target = rand 
+     left_choice_id = right_choice_id = nil
+
+     weighted.each do |item, weight|
+       if target <= weight
+         left_choice_id, right_choice_id = item.split(", ")
+         break
+       end
+       target -= weight
+     end
            prompt = prompts.find_or_create_by_left_choice_id_and_right_choice_id(left_choice_id, right_choice_id, :include => [{ :left_choice => :item }, { :right_choice => :item }])
    end
    # check if prompt has two active choices here, maybe we can set this on the prompt level too?
@@ -116,24 +116,24 @@ class Question &lt; ActiveRecord::Base
    sum = 0.0
    prompts.find_each(:select => 'votes_count, left_choice_id, right_choice_id') do |p|
-	   value = [(1.0/ (p.votes.size + 1).to_f).to_f, throttle_min].min
+     value = [(1.0/ (p.votes.size + 1).to_f).to_f, throttle_min].min
            weights["#{p.left_choice_id}, #{p.right_choice_id}"] = value
-	   sum += value
+     sum += value
    end
    # This will not run once all prompts have been generated, 
-   # 	but it prevents us from having to pregenerate all possible prompts
+   #  but it prevents us from having to pregenerate all possible prompts
    if weights.size < choices.size ** 2 - choices.size
       choices.each do |l|
-	   choices.each do |r|
-		   if l.id == r.id
-			   next
-		   end
-		   if !weights.has_key?("#{l.id}, #{r.id}")
+     choices.each do |r|
+       if l.id == r.id
+         next
+       end
+       if !weights.has_key?("#{l.id}, #{r.id}")
                       weights["#{l.id}, #{r.id}"] = throttle_min
-		      sum+=throttle_min
-		   end
-	   end
+          sum+=throttle_min
+       end
+     end
       end
    end
@@ -160,37 +160,37 @@ class Question &lt; ActiveRecord::Base
           @prompt = choose_prompt(:algorithm => params[:algorithm])
           @appearance = current_user.record_appearance(visitor, @prompt)
        else
-	  #only display a new prompt and new appearance if the old prompt has not been voted on
-	  @appearance = last_appearance
+    #only display a new prompt and new appearance if the old prompt has not been voted on
+    @appearance = last_appearance
           @prompt= @appearance.prompt
        end
        if params[:future_prompts]
-	       num_future = params[:future_prompts][:number].to_i rescue 1
-	       num_future.times do |number|
-		  offset = number + 1
+         num_future = params[:future_prompts][:number].to_i rescue 1
+         num_future.times do |number|
+      offset = number + 1
                   last_appearance = get_first_unanswered_appearance(visitor, offset)
                   if last_appearance.nil?
                       @future_prompt = choose_prompt(:algorithm => params[:algorithm])
                       @future_appearance = current_user.record_appearance(visitor, @future_prompt)
-		  else
-	              @future_appearance = last_appearance
+      else
+                @future_appearance = last_appearance
                       @future_prompt= @future_appearance.prompt
-		  end
-	
+      end
+  
                   result.merge!({"future_appearance_id_#{offset}".to_sym => @future_appearance.lookup})
                   result.merge!({"future_prompt_id_#{offset}".to_sym => @future_prompt.id})
-		  ["left", "right"].each do |side|
-		      ["text", "id"].each do |param|
-			 choice = (side == "left") ? @future_prompt.left_choice : @future_prompt.right_choice
-			 param_val = (param == "text") ? choice.data : choice.id
+      ["left", "right"].each do |side|
+          ["text", "id"].each do |param|
+       choice = (side == "left") ? @future_prompt.left_choice : @future_prompt.right_choice
+       param_val = (param == "text") ? choice.data : choice.id
                          result.merge!({"future_#{side}_choice_#{param}_#{offset}".to_sym => param_val})
-		      end
-		  end
-	          
-	       end
+          end
+      end
+            
+         end
        end
@@ -219,7 +219,7 @@ class Question &lt; ActiveRecord::Base
       if votes_by_visitors.size > 0
          average = votes_by_visitors.inject(0){|total, (k,v)| total = total + v}.to_f / votes_by_visitors.size.to_f
       else
-	 average = 0.0
+   average = 0.0
       end
       result.merge!(:average_votes => average.round) # round to 2 decimals
@@ -232,22 +232,22 @@ class Question &lt; ActiveRecord::Base
  #passing precomputed sum saves us a traversal through the array
  def normalize!(weighted, sum=nil)
    if weighted.instance_of?(Hash)
-	   if sum.nil?
-	     sum = weighted.inject(0) do |sum, item_and_weight|
-	        sum += item_and_weight[1]
-	     end
-	     sum = sum.to_f
-	   end
-	   weighted.each do |item, weight| 
-		   weighted[item] = weight/sum 
-		   weighted[item] = 0.0 unless weighted[item].finite?
-	   end
+     if sum.nil?
+       sum = weighted.inject(0) do |sum, item_and_weight|
+          sum += item_and_weight[1]
+       end
+       sum = sum.to_f
+     end
+     weighted.each do |item, weight| 
+       weighted[item] = weight/sum 
+       weighted[item] = 0.0 unless weighted[item].finite?
+     end
    elsif weighted.instance_of?(Array)
-	   sum = weighted.inject(0) {|sum, item| sum += item} if sum.nil?
-	   weighted.each_with_index do |item, i| 
-		   weighted[i] = item/sum
-		   weighted[i] = 0.0 unless weighted[i].finite?
-	   end
+     sum = weighted.inject(0) {|sum, item| sum += item} if sum.nil?
+     weighted.each_with_index do |item, i| 
+       weighted[i] = item/sum
+       weighted[i] = 0.0 unless weighted[i].finite?
+     end
    end
   end
@@ -266,8 +266,8 @@ class Question &lt; ActiveRecord::Base
    # Initial probabilities chosen at random
    the_choices.size.times do 
-	   probs << rand
-	   prev_probs << rand
+     probs << rand
+     prev_probs << rand
    end
    t=0
@@ -287,13 +287,13 @@ class Question &lt; ActiveRecord::Base
       denominator = 0.0
       the_choices.each_with_index do |c, index|
-	      if(index == s)
-		      next
-	      end
+        if(index == s)
+          next
+        end
-	      wins_and_losses = the_prompts["#{choice.id}, #{c.id}"].votes.size + the_prompts["#{c.id}, #{choice.id}"].votes.size
+        wins_and_losses = the_prompts["#{choice.id}, #{c.id}"].votes.size + the_prompts["#{c.id}, #{choice.id}"].votes.size
-	      denominator+= (wins_and_losses).to_f / (prev_probs[s] + prev_probs[index])
+        denominator+= (wins_and_losses).to_f / (prev_probs[s] + prev_probs[index])
       end
       probs[s] = numerator / denominator 
       # avoid divide by zero NaN
@@ -303,25 +303,25 @@ class Question &lt; ActiveRecord::Base
       difference = 0
       probs.each_with_index do |curr, index|
-	      difference += (curr - prev_probs[index]).abs
+        difference += (curr - prev_probs[index]).abs
       end
       puts difference
    end
    probs_hash = {}
    probs.each_with_index do |item, index| 
-	   probs_hash[the_choices[index].id] = item
+     probs_hash[the_choices[index].id] = item
    end
    probs_hash
  end
  def all_bt_scores
-	 btprobs = bradley_terry_probs
-	 btprobs.each do |key, value|
-		 c = Choice.find(key)
-		 puts "#{c.id}: #{c.votes.size} #{c.compute_bt_score(btprobs)}"
-	 end
+   btprobs = bradley_terry_probs
+   btprobs.each do |key, value|
+     c = Choice.find(key)
+     puts "#{c.id}: #{c.votes.size} #{c.compute_bt_score(btprobs)}"
+   end
  end
@@ -388,36 +388,36 @@ class Question &lt; ActiveRecord::Base
       is_user_created = {}
       self.choices.each do |c|
-	      is_user_created[c.id] = c.user_created
+        is_user_created[c.id] = c.user_created
       end
       #the_prompts = prompts.find(:all, :include => ['left_choice', 'right_choice'])
       prompts.find_each do |p|
-	      num_appearances = num_appearances_by_prompt[p.id]
-
-	      if num_appearances.nil?
-		      num_appearances = 0
-	      end
-
-	      left_user_created = is_user_created[p.left_choice_id]
-	      right_user_created = is_user_created[p.right_choice_id]
-
-
-	      if left_user_created == false && right_user_created == false
-		      seed_seed_sum += num_appearances
-		      seed_seed_total +=1
-	      elsif left_user_created == false && right_user_created == true
-		      seed_nonseed_sum += num_appearances
-		      seed_nonseed_total +=1
-	      elsif left_user_created == true && right_user_created == false
-		      nonseed_seed_sum += num_appearances
-		      nonseed_seed_total +=1
-	      elsif left_user_created == true && right_user_created == true
-		      nonseed_nonseed_sum += num_appearances
-		      nonseed_nonseed_total +=1
-	      end
+        num_appearances = num_appearances_by_prompt[p.id]
+
+        if num_appearances.nil?
+          num_appearances = 0
+        end
+
+        left_user_created = is_user_created[p.left_choice_id]
+        right_user_created = is_user_created[p.right_choice_id]
+
+
+        if left_user_created == false && right_user_created == false
+          seed_seed_sum += num_appearances
+          seed_seed_total +=1
+        elsif left_user_created == false && right_user_created == true
+          seed_nonseed_sum += num_appearances
+          seed_nonseed_total +=1
+        elsif left_user_created == true && right_user_created == false
+          nonseed_seed_sum += num_appearances
+          nonseed_seed_total +=1
+        elsif left_user_created == true && right_user_created == true
+          nonseed_nonseed_sum += num_appearances
+          nonseed_nonseed_total +=1
+        end
       end
       densities = {}
@@ -437,175 +437,175 @@ class Question &lt; ActiveRecord::Base
   def save_densities!
-	  d_hash = density
+    d_hash = density
-	  d_hash.each do |type, average|
-		  d = Density.new
-		  d.question_id = self.id
-		  d.prompt_type = type.to_s
-		  d.value = average.nan? ? nil : average
-		  d.save!
-	  end
+    d_hash.each do |type, average|
+      d = Density.new
+      d.question_id = self.id
+      d.prompt_type = type.to_s
+      d.value = average.nan? ? nil : average
+      d.save!
+    end
   end
   def pq_key
-	  @pq_key ||= "#{self.id}_prompt_queue"
+    @pq_key ||= "#{self.id}_prompt_queue"
   end
   def clear_prompt_queue
-	  $redis.del(self.pq_key)
+    $redis.del(self.pq_key)
   end
   def add_prompt_to_queue
-	  prompt = self.catchup_choose_prompt
-	  $redis.rpush(self.pq_key, prompt.id)
-	  prompt
+    prompt = self.catchup_choose_prompt
+    $redis.rpush(self.pq_key, prompt.id)
+    prompt
   end
   def pop_prompt_queue
-	  begin
-	     prompt_id = $redis.lpop(self.pq_key)
-	     prompt = prompt_id.nil? ? nil : Prompt.find(prompt_id.to_i)
+    begin
+       prompt_id = $redis.lpop(self.pq_key)
+       prompt = prompt_id.nil? ? nil : Prompt.find(prompt_id.to_i)
           end until (prompt.nil? || prompt.active?)
           prompt
   end
   def record_prompt_cache_miss
-	  $redis.incr(self.pq_key + "_" + Time.now.to_date.to_s + "_"+ "misses")
+    $redis.incr(self.pq_key + "_" + Time.now.to_date.to_s + "_"+ "misses")
   end
   def record_prompt_cache_hit
-	  $redis.incr(self.pq_key + "_" + Time.now.to_date.to_s + "_"+ "hits")
+    $redis.incr(self.pq_key + "_" + Time.now.to_date.to_s + "_"+ "hits")
   end
   def get_prompt_cache_misses(date)
-	  $redis.get(self.pq_key + "_" + date.to_s + "_"+ "misses")
+    $redis.get(self.pq_key + "_" + date.to_s + "_"+ "misses")
   end
   def get_prompt_cache_hits(date)
-	  $redis.get(self.pq_key + "_" + date.to_s + "_"+ "hits")
+    $redis.get(self.pq_key + "_" + date.to_s + "_"+ "hits")
   end
   def reset_cache_tracking_keys(date)
-	  $redis.del(self.pq_key + "_" + date.to_s + "_"+ "misses")
-	  $redis.del(self.pq_key + "_" + date.to_s + "_"+ "hits")
+    $redis.del(self.pq_key + "_" + date.to_s + "_"+ "misses")
+    $redis.del(self.pq_key + "_" + date.to_s + "_"+ "hits")
   end
   def expire_prompt_cache_tracking_keys(date, expire_time = 24*60*60 * 3) # default expires in three days
-	  $redis.expire(self.pq_key + "_" + date.to_s + "_"+ "hits", expire_time)
-	  $redis.expire(self.pq_key + "_" + date.to_s + "_"+ "misses", expire_time)
+    $redis.expire(self.pq_key + "_" + date.to_s + "_"+ "hits", expire_time)
+    $redis.expire(self.pq_key + "_" + date.to_s + "_"+ "misses", expire_time)
   end
   def export_and_delete(type, options={})
-	  delete_at = options.delete(:delete_at)
-	  filename = export(type, options)
+    delete_at = options.delete(:delete_at)
+    filename = export(type, options)
-	  File.send_at(delete_at, :delete, filename)
-	  filename
+    File.send_at(delete_at, :delete, filename)
+    filename
   end
   def export(type, options = {})
     case type
     when 'votes'
-	 outfile = "ideamarketplace_#{self.id}_votes.csv"
+   outfile = "ideamarketplace_#{self.id}_votes.csv"
-	 headers = ['Vote ID', 'Session ID', 'Question ID','Winner ID', 'Winner Text', 'Loser ID', 'Loser Text',
-		    'Prompt ID', 'Left Choice ID', 'Right Choice ID', 'Created at', 'Updated at',  'Appearance ID',
-		    'Response Time (s)', 'Missing Response Time Explanation', 'Session Identifier']
+   headers = ['Vote ID', 'Session ID', 'Question ID','Winner ID', 'Winner Text', 'Loser ID', 'Loser Text',
+        'Prompt ID', 'Left Choice ID', 'Right Choice ID', 'Created at', 'Updated at',  'Appearance ID',
+        'Response Time (s)', 'Missing Response Time Explanation', 'Session Identifier']
     when 'ideas'
-	 outfile = "ideamarketplace_#{self.id}_ideas.csv"
+   outfile = "ideamarketplace_#{self.id}_ideas.csv"
          headers = ['Ideamarketplace ID','Idea ID', 'Idea Text', 'Wins', 'Losses', 'Times involved in Cant Decide', 'Score',
-	       'User Submitted', 'Session ID', 'Created at', 'Last Activity', 'Active',  
-		'Appearances on Left', 'Appearances on Right']
+         'User Submitted', 'Session ID', 'Created at', 'Last Activity', 'Active',  
+    'Appearances on Left', 'Appearances on Right']
     when 'non_votes'
          outfile = "ideamarketplace_#{self.id}_non_votes.csv"
          headers = ['Record Type', 'Record ID', 'Session ID', 'Question ID','Left Choice ID', 'Left Choice Text', 
-	            'Right Choice ID', 'Right Choice Text', 'Prompt ID', 'Appearance ID', 'Reason',
-		    'Created at', 'Updated at', 'Response Time (s)', 'Missing Response Time Explanation', 'Session Identifier']
+              'Right Choice ID', 'Right Choice Text', 'Prompt ID', 'Appearance ID', 'Reason',
+        'Created at', 'Updated at', 'Response Time (s)', 'Missing Response Time Explanation', 'Session Identifier']
     else 
-	 raise "Unsupported export type: #{type}"
+   raise "Unsupported export type: #{type}"
     end
     filename = File.join(File.expand_path(Rails.root), "public", "system", "exports", 
-			 self.id.to_s, Digest::SHA1.hexdigest(outfile + rand(10000000).to_s) + "_" + outfile)
+       self.id.to_s, Digest::SHA1.hexdigest(outfile + rand(10000000).to_s) + "_" + outfile)
     FileUtils::mkdir_p(File.dirname(filename))
     csv_data = FasterCSV.open(filename, "w") do |csv|
-       csv << headers	
+       csv << headers 
        case type
        when 'votes'
          self.votes.find_each(:include => [:prompt, :choice, :loser_choice, :voter]) do |v|
-	       prompt = v.prompt
-	       # these may not exist
-	       loser_data = v.loser_choice.nil? ? "" : "'#{v.loser_choice.data.strip}'"
-	       left_id = v.prompt.nil? ? "" : v.prompt.left_choice_id
-	       right_id = v.prompt.nil? ? "" : v.prompt.right_choice_id
+         prompt = v.prompt
+         # these may not exist
+         loser_data = v.loser_choice.nil? ? "" : "'#{v.loser_choice.data.strip}'"
+         left_id = v.prompt.nil? ? "" : v.prompt.left_choice_id
+         right_id = v.prompt.nil? ? "" : v.prompt.right_choice_id
-	       time_viewed = v.time_viewed.nil? ? "NA": v.time_viewed.to_f / 1000.0
+         time_viewed = v.time_viewed.nil? ? "NA": v.time_viewed.to_f / 1000.0
-	       csv << [ v.id, v.voter_id, v.question_id, v.choice_id, "'#{v.choice.data.strip}'", v.loser_choice_id, loser_data,
-		       v.prompt_id, left_id, right_id, v.created_at, v.updated_at, v.appearance_id,
-		       time_viewed, v.missing_response_time_exp , v.voter.identifier] 
-	 end
+         csv << [ v.id, v.voter_id, v.question_id, v.choice_id, "'#{v.choice.data.strip}'", v.loser_choice_id, loser_data,
+           v.prompt_id, left_id, right_id, v.created_at, v.updated_at, v.appearance_id,
+           time_viewed, v.missing_response_time_exp , v.voter.identifier] 
+   end
        when 'ideas'
          self.choices.each do |c|
              user_submitted = c.user_created ? "TRUE" : "FALSE"
-	     left_prompts_ids = c.prompts_on_the_left.ids_only
-	     right_prompts_ids = c.prompts_on_the_right.ids_only
+       left_prompts_ids = c.prompts_on_the_left.ids_only
+       right_prompts_ids = c.prompts_on_the_right.ids_only
-	     left_appearances = self.appearances.count(:conditions => {:prompt_id => left_prompts_ids})
-	     right_appearances = self.appearances.count(:conditions => {:prompt_id => right_prompts_ids})
+       left_appearances = self.appearances.count(:conditions => {:prompt_id => left_prompts_ids})
+       right_appearances = self.appearances.count(:conditions => {:prompt_id => right_prompts_ids})
-	     num_skips = self.skips.count(:conditions => {:prompt_id => left_prompts_ids + right_prompts_ids})
+       num_skips = self.skips.count(:conditions => {:prompt_id => left_prompts_ids + right_prompts_ids})
-	       csv << [c.question_id, c.id, "'#{c.data.strip}'", c.wins, c.losses, num_skips, c.score,
-		       user_submitted , c.creator_id, c.created_at, c.updated_at, c.active,
-		       left_appearances, right_appearances]
+         csv << [c.question_id, c.id, "'#{c.data.strip}'", c.wins, c.losses, num_skips, c.score,
+           user_submitted , c.creator_id, c.created_at, c.updated_at, c.active,
+           left_appearances, right_appearances]
          end
        when 'non_votes'
-	       
-	  self.appearances.find_each(:include => [:skip, :vote, :voter]) do |a|
-		  # we only display skips and orphaned appearances in this csv file
-		  unless a.vote.nil?
-			  next
-		  end
-		  
-		  #If no skip and no vote, this is an orphaned appearance
-		  if a.skip.nil?
-	              prompt = a.prompt
-	              csv << [ "Orphaned Appearance", a.id, a.voter_id, a.question_id, a.prompt.left_choice.id, a.prompt.left_choice.data.strip, 
-		           a.prompt.right_choice.id, a.prompt.right_choice.data.strip, a.prompt_id, 'N/A', 'N/A',
-		           a.created_at, a.updated_at, 'N/A', '', a.voter.identifier] 
-			  
-		  else
-	              
-	          #If this appearance belongs to a skip, show information on the skip instead
-		      s = a.skip
-		      time_viewed = s.time_viewed.nil? ? "NA": s.time_viewed.to_f / 1000.0
-	              prompt = s.prompt
-	              csv << [ "Skip", s.id, s.skipper_id, s.question_id, s.prompt.left_choice.id, s.prompt.left_choice.data.strip, 
-		           s.prompt.right_choice.id, s.prompt.right_choice.data.strip, s.prompt_id, s.appearance_id, s.skip_reason,
-		           s.created_at, s.updated_at, time_viewed , s.missing_response_time_exp, s.skipper.identifier] 
-		  end
-	  end
+         
+    self.appearances.find_each(:include => [:skip, :vote, :voter]) do |a|
+      # we only display skips and orphaned appearances in this csv file
+      unless a.vote.nil?
+        next
+      end
+      
+      #If no skip and no vote, this is an orphaned appearance
+      if a.skip.nil?
+                prompt = a.prompt
+                csv << [ "Orphaned Appearance", a.id, a.voter_id, a.question_id, a.prompt.left_choice.id, a.prompt.left_choice.data.strip, 
+               a.prompt.right_choice.id, a.prompt.right_choice.data.strip, a.prompt_id, 'N/A', 'N/A',
+               a.created_at, a.updated_at, 'N/A', '', a.voter.identifier] 
+        
+      else
+                
+            #If this appearance belongs to a skip, show information on the skip instead
+          s = a.skip
+          time_viewed = s.time_viewed.nil? ? "NA": s.time_viewed.to_f / 1000.0
+                prompt = s.prompt
+                csv << [ "Skip", s.id, s.skipper_id, s.question_id, s.prompt.left_choice.id, s.prompt.left_choice.data.strip, 
+               s.prompt.right_choice.id, s.prompt.right_choice.data.strip, s.prompt_id, s.appearance_id, s.skip_reason,
+               s.created_at, s.updated_at, time_viewed , s.missing_response_time_exp, s.skipper.identifier] 
+      end
+    end
        end
     end
     if options[:response_type] == 'redis'
-	    if options[:redis_key].nil?
-		    raise "No :redis_key specified"
-	    end
-	    #The client should use blpop to listen for a key
-	    #The client is responsible for deleting the redis key (auto expiration results failure in testing)
-	    $redis.lpush(options[:redis_key], filename)
+      if options[:redis_key].nil?
+        raise "No :redis_key specified"
+      end
+      #The client should use blpop to listen for a key
+      #The client is responsible for deleting the redis key (auto expiration results failure in testing)
+      $redis.lpush(options[:redis_key], filename)
     #TODO implement response_type == 'email' for use by customers of the API (not local)
     end
@@ -614,17 +614,17 @@ class Question &lt; ActiveRecord::Base
   def get_first_unanswered_appearance(visitor, offset=0)
        last_appearance = visitor.appearances.find(:first, 
-						  :conditions => {:question_id => self.id,
-							          :answerable_id => nil
-       						                 },
-				 		  :order => 'id ASC',
-						  :offset => offset)
+              :conditions => {:question_id => self.id,
+                        :answerable_id => nil
+                                   },
+              :order => 'id ASC',
+              :offset => offset)
        if last_appearance && !last_appearance.prompt.active?
-		  last_appearance.valid_record = false
-		  last_appearance.validity_information = "Deactivated Prompt"
-		  last_appearance.save
+      last_appearance.valid_record = false
+      last_appearance.validity_information = "Deactivated Prompt"
+      last_appearance.save
-		  return get_first_unanswered_appearance(visitor)
+      return get_first_unanswered_appearance(visitor)
        end
        last_appearance
   end