Commit fda7a1be1b65bb2735197de354301d82742b8f3e
1 parent
9235d495
Exists in
master
and in
1 other branch
remove global appearance to vote + skips test
this test is superseded by answered_appearances_equals_votes_and_skips
Showing
1 changed file
with
0 additions
and
24 deletions
Show diff stats
lib/tasks/test_api.rake
@@ -363,14 +363,6 @@ namespace :test_api do | @@ -363,14 +363,6 @@ namespace :test_api do | ||
363 | 363 | ||
364 | end | 364 | end |
365 | 365 | ||
366 | - message, error_occurred = ensure_all_votes_and_skips_have_unique_appearance | ||
367 | - | ||
368 | - if error_occurred | ||
369 | - errors << message | ||
370 | - else | ||
371 | - successes << message | ||
372 | - end | ||
373 | - | ||
374 | message, error_occurred = response_time_tests | 366 | message, error_occurred = response_time_tests |
375 | 367 | ||
376 | if error_occurred | 368 | if error_occurred |
@@ -673,22 +665,6 @@ namespace :test_api do | @@ -673,22 +665,6 @@ namespace :test_api do | ||
673 | return error_message.blank? ? [success_message, false] : [error_message, true] | 665 | return error_message.blank? ? [success_message, false] : [error_message, true] |
674 | end | 666 | end |
675 | 667 | ||
676 | - def ensure_all_votes_and_skips_have_unique_appearance | ||
677 | - error_message = "" | ||
678 | - success_message = "All vote and skip objects have an associated appearance object" | ||
679 | - | ||
680 | - total_answered_appearances = Appearance.count(:conditions => 'answerable_id IS NOT NULL') | ||
681 | - total_votes = Vote.count | ||
682 | - total_skips = Skip.count | ||
683 | - | ||
684 | - if (total_answered_appearances != total_votes+ total_skips) | ||
685 | - difference = (total_votes+ total_skips) - total_answered_appearances | ||
686 | - error_message += "Error! There are #{difference} votes or skips without associated appearance objects." | ||
687 | - end | ||
688 | - | ||
689 | - return error_message.blank? ? [success_message, false] : [error_message, true] | ||
690 | - end | ||
691 | - | ||
692 | def response_time_tests | 668 | def response_time_tests |
693 | error_message = "" | 669 | error_message = "" |
694 | success_message = "All Vote objects have an client response time < calculated server roundtrip time\n" | 670 | success_message = "All Vote objects have an client response time < calculated server roundtrip time\n" |