Choice scores no longer calculated every index or show request

Dhruv Kapadia
1 parent 60ada0c5
Showing 4 changed files with 20 additions and 24 deletions Show diff stats
app/controllers/choices_controller.rb
app/models/choice.rb
app/models/visitor.rb
db/migrate/20100323180141_set_blank_score_values_to_default_fifty.rb
@@ -9,7 +9,9 @@ class ChoicesController &lt; InheritedResources::Base
     if params[:limit]
       @question = Question.find(params[:question_id])#, :include => :choices)
       @question.reload
-      @question.choices.each(&:compute_score!)
+      
+      #should compute score after each win/loss
+      #@question.choices.each(&:compute_score!)
       unless params[:include_inactive]
         @choices = Choice.find(:all, :conditions => {:question_id => @question.id, :active => true}, :limit => params[:limit].to_i, :order => 'score DESC', :include => :item)
       else
@@ -17,7 +19,7 @@ class ChoicesController &lt; InheritedResources::Base
       end
     else
       @question = Question.find(params[:question_id], :include => :choices) #eagerloads ALL choices
-      @question.choices.each(&:compute_score!)
+      #@question.choices.each(&:compute_score!)
       unless params[:include_inactive]
         @choices = @question.choices(true).active.find(:all, :include => :item)
       else
@@ -34,8 +36,8 @@ class ChoicesController &lt; InheritedResources::Base
     show! do |format|
       format.xml { 
         @choice.reload
-        @choice.compute_score!
-        @choice.reload
+      #  @choice.compute_score!
+      #  @choice.reload
         render :xml => @choice.to_xml(:methods => [:item_data, :wins_plus_losses, :question_name])}
       format.json { render :json => @choice.to_json(:methods => [:data])}
     end 
@@ -26,6 +26,7 @@ class Choice &lt; ActiveRecord::Base
   def lose!
     self.loss_count += 1 rescue (self.loss_count = 1)
+    self.score = compute_score
     save!
   end
@@ -51,7 +52,7 @@ class Choice &lt; ActiveRecord::Base
       self.item = @item
     end
     unless self.score
-      self.score = 0.0
+      self.score = 50.0
     end
     unless self.active?
       puts "this choice was not specifically set to active, so we are now asking if we should auto-activate"
@@ -16,31 +16,16 @@ class Visitor &lt; ActiveRecord::Base
   end
   def vote_for!(prompt, ordinality)
-    # Why are there three vote objects created for every actual 'vote'? Why not have each vote have a questionid, promptid and choiceid?
-#    question_vote = votes.create!(:voteable_id => prompt.question_id, :voteable_type => "Question")
-#    logger.info "Visitor: #{self.inspect} voted for Question: #{prompt.question_id}"
-    
-    
-#    prompt_vote = votes.create!(:voteable => prompt)
-#    logger.info "Visitor: voted for Prompt: #{prompt.id.to_s}"
-    # @click = Click.new(:what_was_clicked => "on the API level, inside visitor#vote_for! with prompt id #{prompt.id}, ordinality #{ordinality.to_s}, choice: #{choice.item.data} (id: #{choice.id})")
-    # @click.save!
-    
     choices = prompt.choices
     choice = choices[ordinality] #we need to guarantee that the choices are in the right order (by position)
     other_choices = choices - [choice]
-    other_choices.each {|c| c.lose! }
+    other_choices.each do |c| 
+	    c.lose!
+    end
     loser_choice = other_choices.first
     votes.create!(:question_id => prompt.question_id, :prompt_id => prompt.id, :voter_id=> self.id, :choice_id => choice.id, :loser_choice_id => loser_choice.id)
-    
-#    choice_vote = votes.create!(:voteable => choice)
-    # logger.info "Visitor: voted for Prompt: #{prompt.id.to_s} for choice #{choice.item.data}"
-    # choice.save!
-    # choice.score = choice.compute_score
-    # logger.info "Just computed the score for that choice and it's apparently #{choice.score}"
-    # choice.save!
-    #logger.info "Saved. That choice's score is still #{choice.score}"
+    choice.compute_score! #update score after win
   end
   def skip!(prompt)
@@ -0,0 +1,8 @@
+class SetBlankScoreValuesToDefaultFifty < ActiveRecord::Migration
+  def self.up
+	  ActiveRecord::Base.connection.execute('UPDATE choices SET score=50.0 where score =0')
+  end
+
+  def self.down
+  end
+end
	@@ -16,31 +16,16 @@ class Visitor < ActiveRecord::Base		@@ -16,31 +16,16 @@ class Visitor < ActiveRecord::Base
16	end	16	end
17		17
18	def vote_for!(prompt, ordinality)	18	def vote_for!(prompt, ordinality)
19	- # Why are there three vote objects created for every actual 'vote'? Why not have each vote have a questionid, promptid and choiceid?
20	-# question_vote = votes.create!(:voteable_id => prompt.question_id, :voteable_type => "Question")
21	-# logger.info "Visitor: #{self.inspect} voted for Question: #{prompt.question_id}"
22	-
23	-
24	-# prompt_vote = votes.create!(:voteable => prompt)
25	-# logger.info "Visitor: voted for Prompt: #{prompt.id.to_s}"
26	- # @click = Click.new(:what_was_clicked => "on the API level, inside visitor#vote_for! with prompt id #{prompt.id}, ordinality #{ordinality.to_s}, choice: #{choice.item.data} (id: #{choice.id})")
27	- # @click.save!
28	-
29	choices = prompt.choices	19	choices = prompt.choices
30	choice = choices[ordinality] #we need to guarantee that the choices are in the right order (by position)	20	choice = choices[ordinality] #we need to guarantee that the choices are in the right order (by position)
31	other_choices = choices - [choice]	21	other_choices = choices - [choice]
32	- other_choices.each {\|c\| c.lose! }	22	+ other_choices.each do \|c\|
		23	+ c.lose!
		24	+ end
33		25
34	loser_choice = other_choices.first	26	loser_choice = other_choices.first
35	votes.create!(:question_id => prompt.question_id, :prompt_id => prompt.id, :voter_id=> self.id, :choice_id => choice.id, :loser_choice_id => loser_choice.id)	27	votes.create!(:question_id => prompt.question_id, :prompt_id => prompt.id, :voter_id=> self.id, :choice_id => choice.id, :loser_choice_id => loser_choice.id)
36	-
37	-# choice_vote = votes.create!(:voteable => choice)
38	- # logger.info "Visitor: voted for Prompt: #{prompt.id.to_s} for choice #{choice.item.data}"
39	- # choice.save!
40	- # choice.score = choice.compute_score
41	- # logger.info "Just computed the score for that choice and it's apparently #{choice.score}"
42	- # choice.save!
43	- #logger.info "Saved. That choice's score is still #{choice.score}"	28	+ choice.compute_score! #update score after win
44	end	29	end
45		30
46	def skip!(prompt)	31	def skip!(prompt)
@@ -0,0 +1,8 @@		@@ -0,0 +1,8 @@
	1	+class SetBlankScoreValuesToDefaultFifty < ActiveRecord::Migration
	2	+ def self.up
	3	+ ActiveRecord::Base.connection.execute('UPDATE choices SET score=50.0 where score =0')
	4	+ end
	5	+
	6	+ def self.down
	7	+ end
	8	+end