profile-suggestions: added basic structure

(ActionItem3234)

profile-suggestions: added basic structure
(ActionItem3234)
Daniela Feitosa
1 parent bc1632a9
Showing 6 changed files with 119 additions and 1 deletions Show diff stats
app/models/person.rb
app/models/profile.rb
app/models/profile_suggestion.rb
db/migrate/20140720144212_create_profile_suggestions.rb
db/schema.rb
test/unit/profile_suggestion_test.rb
@@ -59,6 +59,10 @@ class Person &lt; Profile
   has_and_belongs_to_many :acepted_forums, :class_name => 'Forum', :join_table => 'terms_forum_people'
   has_and_belongs_to_many :articles_with_access, :class_name => 'Article', :join_table => 'article_privacy_exceptions'
+  has_many :profile_suggestions, :foreign_key => :person_id, :dependent => :destroy
+  has_many :suggested_people, :through => :profile_suggestions, :source => :suggestion, :conditions => ['profile_suggestions.suggestion_type = ? AND profile_suggestions.enabled = ?', 'Person', true]
+  has_many :suggested_communities, :through => :profile_suggestions, :source => :suggestion, :conditions => ['profile_suggestions.suggestion_type = ? AND profile_suggestions.enabled = ?', 'Community', true]
+
   scope :more_popular, :order => 'friends_count DESC'
   scope :abusers, :joins => :abuse_complaints, :conditions => ['tasks.status = 3'], :select => 'DISTINCT profiles.*'
@@ -217,6 +217,8 @@ class Profile &lt; ActiveRecord::Base
   has_many :abuse_complaints, :foreign_key => 'requestor_id', :dependent => :destroy
+  has_many :profile_suggestions, :foreign_key => :suggestion_id, :dependent => :destroy
+
   def top_level_categorization
     ret = {}
     self.profile_categorizations.each do |c|
@@ -0,0 +1,37 @@
+class ProfileSuggestion < ActiveRecord::Base
+  belongs_to :person
+  belongs_to :suggestion, :class_name => 'Profile', :foreign_key => :suggestion_id
+
+  attr_accessible :person, :suggestion, :suggestion_type, :categories, :similarity, :enabled
+
+  before_create do |profile_suggestion|
+    profile_suggestion.suggestion_type = self.suggestion.class.to_s
+  end
+
+  acts_as_having_settings :field => :categories
+
+  validate :must_be_a_valid_category, :on => :create
+  def must_be_a_valid_category
+    if categories.keys.map { |cat| self.respond_to?(cat)}.include?(false)
+      errors.add(:categories, 'Category must be valid')
+    end
+  end
+
+  validates_uniqueness_of :suggestion_id, :scope => [ :person_id ]
+
+  CATEGORIES = {
+    :common_friends => _('Friends in common'),
+    :common_communities => _('Communities in common'),
+    :common_tags => _('Tags in common')
+  }
+
+  CATEGORIES.keys.each do |category|
+    settings_items category.to_sym
+    attr_accessible category.to_sym
+  end
+  def disable
+    self.enabled = false
+    self.save
+  end
+
+end
@@ -0,0 +1,15 @@
+class CreateProfileSuggestions < ActiveRecord::Migration
+  def change
+    create_table :profile_suggestions do |t|
+      t.references :person
+      t.references :suggestion
+      t.string :suggestion_type
+      t.text :categories
+      t.boolean :enabled, :default => true
+
+      t.timestamps
+    end
+    add_index :profile_suggestions, :person_id
+    add_index :profile_suggestions, :suggestion_id
+  end
+end
@@ -11,7 +11,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
-ActiveRecord::Schema.define(:version => 20140605222753) do
+ActiveRecord::Schema.define(:version => 20140720144212) do
   create_table "abuse_reports", :force => true do |t|
     t.integer  "reporter_id"
@@ -446,6 +446,19 @@ ActiveRecord::Schema.define(:version =&gt; 20140605222753) do
   add_index "products", ["product_category_id"], :name => "index_products_on_product_category_id"
   add_index "products", ["profile_id"], :name => "index_products_on_profile_id"
+  create_table "profile_suggestions", :force => true do |t|
+    t.integer  "person_id"
+    t.integer  "suggestion_id"
+    t.string   "suggestion_type"
+    t.text     "categories"
+    t.boolean  "enabled",         :default => true
+    t.datetime "created_at",                        :null => false
+    t.datetime "updated_at",                        :null => false
+  end
+
+  add_index "profile_suggestions", ["person_id"], :name => "index_profile_suggestions_on_person_id"
+  add_index "profile_suggestions", ["suggestion_id"], :name => "index_profile_suggestions_on_suggestion_id"
+
   create_table "profiles", :force => true do |t|
     t.string   "name"
     t.string   "type"
@@ -0,0 +1,47 @@
+# encoding: UTF-8
+require File.dirname(__FILE__) + '/../test_helper'
+
+class ProfileSuggestionTest < ActiveSupport::TestCase
+
+  should 'save the profile class' do
+    person = create_user('person').person
+    suggested_community = fast_create(Community)
+
+    suggestion = ProfileSuggestion.create(:person => person, :suggestion => suggested_community)
+    assert_equal 'Community', suggestion.suggestion_type
+  end
+
+  should 'only accept pre-defined categories' do
+    person = create_user('person').person
+    suggested_community = fast_create(Community)
+
+    suggestion = ProfileSuggestion.new(:person => person, :suggestion => suggested_community)
+
+    suggestion.categories = {:unexistent => 1}
+    suggestion.valid?
+    assert suggestion.errors[:categories.to_s].present?
+  end
+
+  should 'disable a suggestion' do
+    person = create_user('person').person
+    suggested_community = fast_create(Community)
+
+    suggestion = ProfileSuggestion.create(:person => person, :suggestion => suggested_community)
+
+    suggestion.disable
+    assert_equal false, ProfileSuggestion.find(suggestion.id).enabled?
+  end
+
+  should 'not suggest the same community twice' do
+    person = create_user('person').person
+    suggested_community = fast_create(Community)
+
+    ProfileSuggestion.create(:person => person, :suggestion => suggested_community)
+
+    repeated_suggestion = ProfileSuggestion.new(:person => person, :suggestion => suggested_community)
+
+    repeated_suggestion.valid?
+    assert_equal true, repeated_suggestion.errors[:suggestion_id.to_s].present?
+  end
+
+end
	@@ -217,6 +217,8 @@ class Profile < ActiveRecord::Base		@@ -217,6 +217,8 @@ class Profile < ActiveRecord::Base
217		217
218	has_many :abuse_complaints, :foreign_key => 'requestor_id', :dependent => :destroy	218	has_many :abuse_complaints, :foreign_key => 'requestor_id', :dependent => :destroy
219		219
		220	+ has_many :profile_suggestions, :foreign_key => :suggestion_id, :dependent => :destroy
		221	+
220	def top_level_categorization	222	def top_level_categorization
221	ret = {}	223	ret = {}
222	self.profile_categorizations.each do \|c\|	224	self.profile_categorizations.each do \|c\|
@@ -0,0 +1,37 @@		@@ -0,0 +1,37 @@
	1	+class ProfileSuggestion < ActiveRecord::Base
	2	+ belongs_to :person
	3	+ belongs_to :suggestion, :class_name => 'Profile', :foreign_key => :suggestion_id
	4	+
	5	+ attr_accessible :person, :suggestion, :suggestion_type, :categories, :similarity, :enabled
	6	+
	7	+ before_create do \|profile_suggestion\|
	8	+ profile_suggestion.suggestion_type = self.suggestion.class.to_s
	9	+ end
	10	+
	11	+ acts_as_having_settings :field => :categories
	12	+
	13	+ validate :must_be_a_valid_category, :on => :create
	14	+ def must_be_a_valid_category
	15	+ if categories.keys.map { \|cat\| self.respond_to?(cat)}.include?(false)
	16	+ errors.add(:categories, 'Category must be valid')
	17	+ end
	18	+ end
	19	+
	20	+ validates_uniqueness_of :suggestion_id, :scope => [ :person_id ]
	21	+
	22	+ CATEGORIES = {
	23	+ :common_friends => _('Friends in common'),
	24	+ :common_communities => _('Communities in common'),
	25	+ :common_tags => _('Tags in common')
	26	+ }
	27	+
	28	+ CATEGORIES.keys.each do \|category\|
	29	+ settings_items category.to_sym
	30	+ attr_accessible category.to_sym
	31	+ end
	32	+ def disable
	33	+ self.enabled = false
	34	+ self.save
	35	+ end
	36	+
	37	+end
@@ -0,0 +1,15 @@		@@ -0,0 +1,15 @@
	1	+class CreateProfileSuggestions < ActiveRecord::Migration
	2	+ def change
	3	+ create_table :profile_suggestions do \|t\|
	4	+ t.references :person
	5	+ t.references :suggestion
	6	+ t.string :suggestion_type
	7	+ t.text :categories
	8	+ t.boolean :enabled, :default => true
	9	+
	10	+ t.timestamps
	11	+ end
	12	+ add_index :profile_suggestions, :person_id
	13	+ add_index :profile_suggestions, :suggestion_id
	14	+ end
	15	+end
	@@ -11,7 +11,7 @@		@@ -11,7 +11,7 @@
11	#	11	#
12	# It's strongly recommended to check this file into your version control system.	12	# It's strongly recommended to check this file into your version control system.
13		13
14	-ActiveRecord::Schema.define(:version => 20140605222753) do	14	+ActiveRecord::Schema.define(:version => 20140720144212) do
15		15
16	create_table "abuse_reports", :force => true do \|t\|	16	create_table "abuse_reports", :force => true do \|t\|
17	t.integer "reporter_id"	17	t.integer "reporter_id"
	@@ -446,6 +446,19 @@ ActiveRecord::Schema.define(:version => 20140605222753) do		@@ -446,6 +446,19 @@ ActiveRecord::Schema.define(:version => 20140605222753) do
446	add_index "products", ["product_category_id"], :name => "index_products_on_product_category_id"	446	add_index "products", ["product_category_id"], :name => "index_products_on_product_category_id"
447	add_index "products", ["profile_id"], :name => "index_products_on_profile_id"	447	add_index "products", ["profile_id"], :name => "index_products_on_profile_id"
448		448
		449	+ create_table "profile_suggestions", :force => true do \|t\|
		450	+ t.integer "person_id"
		451	+ t.integer "suggestion_id"
		452	+ t.string "suggestion_type"
		453	+ t.text "categories"
		454	+ t.boolean "enabled", :default => true
		455	+ t.datetime "created_at", :null => false
		456	+ t.datetime "updated_at", :null => false
		457	+ end
		458	+
		459	+ add_index "profile_suggestions", ["person_id"], :name => "index_profile_suggestions_on_person_id"
		460	+ add_index "profile_suggestions", ["suggestion_id"], :name => "index_profile_suggestions_on_suggestion_id"
		461	+
449	create_table "profiles", :force => true do \|t\|	462	create_table "profiles", :force => true do \|t\|
450	t.string "name"	463	t.string "name"
451	t.string "type"	464	t.string "type"
@@ -0,0 +1,47 @@		@@ -0,0 +1,47 @@
	1	+# encoding: UTF-8
	2	+require File.dirname(__FILE__) + '/../test_helper'
	3	+
	4	+class ProfileSuggestionTest < ActiveSupport::TestCase
	5	+
	6	+ should 'save the profile class' do
	7	+ person = create_user('person').person
	8	+ suggested_community = fast_create(Community)
	9	+
	10	+ suggestion = ProfileSuggestion.create(:person => person, :suggestion => suggested_community)
	11	+ assert_equal 'Community', suggestion.suggestion_type
	12	+ end
	13	+
	14	+ should 'only accept pre-defined categories' do
	15	+ person = create_user('person').person
	16	+ suggested_community = fast_create(Community)
	17	+
	18	+ suggestion = ProfileSuggestion.new(:person => person, :suggestion => suggested_community)
	19	+
	20	+ suggestion.categories = {:unexistent => 1}
	21	+ suggestion.valid?
	22	+ assert suggestion.errors[:categories.to_s].present?
	23	+ end
	24	+
	25	+ should 'disable a suggestion' do
	26	+ person = create_user('person').person
	27	+ suggested_community = fast_create(Community)
	28	+
	29	+ suggestion = ProfileSuggestion.create(:person => person, :suggestion => suggested_community)
	30	+
	31	+ suggestion.disable
	32	+ assert_equal false, ProfileSuggestion.find(suggestion.id).enabled?
	33	+ end
	34	+
	35	+ should 'not suggest the same community twice' do
	36	+ person = create_user('person').person
	37	+ suggested_community = fast_create(Community)
	38	+
	39	+ ProfileSuggestion.create(:person => person, :suggestion => suggested_community)
	40	+
	41	+ repeated_suggestion = ProfileSuggestion.new(:person => person, :suggestion => suggested_community)
	42	+
	43	+ repeated_suggestion.valid?
	44	+ assert_equal true, repeated_suggestion.errors[:suggestion_id.to_s].present?
	45	+ end
	46	+
	47	+end