ActionItem336: testing the html and the local file references

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1697 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem336: testing the html and the local file references
git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1697 3f533792-8f58-4932-b0fe-aaf55b0a4547
AurelioAHeckert
1 parent 7a67c87d
Showing 32 changed files with 301 additions and 0 deletions Show diff stats
test/functional/account_controller_test.rb
test/functional/admin_controller_test.rb
test/functional/admin_panel_controller_test.rb
test/functional/application_controller_test.rb
test/functional/catalog_controller_test.rb
test/functional/categories_controller_test.rb
test/functional/cms_controller_test.rb
test/functional/consumed_products_controller_test.rb
test/functional/content_viewer_controller_test.rb
test/functional/edit_template_controller_test.rb
test/functional/enterprise_editor_controller_test.rb
test/functional/enterprise_registration_controller_test.rb
test/functional/enterprise_validation_test.rb
test/functional/environment_design_controller_test.rb
test/functional/environment_role_manager_controller_test.rb
test/functional/features_controller_test.rb
test/functional/friends_controller_test.rb
test/functional/home_controller_test.rb
test/functional/manage_products_controller_test.rb
test/functional/memberships_controller_test.rb
@@ -17,6 +17,14 @@ class AccountControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_should_login_and_redirect
     post :login, :user => {:login => 'johndoe', :password => 'test'}
     assert session[:user]
@@ -11,6 +11,14 @@ class AdminControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   # Replace this with your real tests.
   def test_truth
     assert true
@@ -14,6 +14,14 @@ class AdminPanelControllerTest &lt; Test::Unit::TestCase
     login_as(create_admin_user(Environment.default))
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_index
     get :index
     assert_template 'index'
@@ -12,6 +12,14 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+
   def test_exist_environment_variable_to_helper_environment_identification
     get :index
     assert_not_nil assigns(:environment)
@@ -11,6 +11,14 @@ class CatalogControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'list products of enterprise' do
     ent = Enterprise.create!(:identifier => 'test_enterprise1', :name => 'Test enteprise1')
     get :index, :profile => ent.identifier
@@ -20,6 +20,14 @@ class CategoriesControllerTest &lt; Test::Unit::TestCase
   attr_reader :env, :cat1, :cat2
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_index
     assert user =  login_as(create_admin_user(Environment.default))
     assert user.person.has_permission?('manage_environment_categories',Environment.default ), "#{user.login} don't have permission to manage_environment_categories in #{Environment.default.name}"
@@ -19,6 +19,14 @@ class CmsControllerTest &lt; Test::Unit::TestCase
   attr_reader :profile
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'list top level documents on index' do
     get :index, :profile => profile.identifier
@@ -17,6 +17,14 @@ class ConsumedProductsControllerTest &lt; Test::Unit::TestCase
   end
   attr_reader :profile
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'display new form' do
     login_as(profile.identifier)
     get :new, :profile => profile.identifier
@@ -17,6 +17,14 @@ class ContentViewerControllerTest &lt; Test::Unit::TestCase
   end
   attr_reader :profile
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_should_display_page
     page = profile.articles.build(:name => 'test')
     page.save!
@@ -15,6 +15,14 @@ class EditTemplateControllerTest &lt; Test::Unit::TestCase
     login_as 'ze'
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_redirect_to_design_editor_when_index_action_is_called
     give_permission('ze', 'edit_environment_design', Environment.default)
     get :index
@@ -11,6 +11,14 @@ class EnterpriseEditorControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'not see index if do not logged in' do
     ent1 = Enterprise.create!(:identifier => 'test_enterprise1', :name => 'Test enteprise1')
     get 'index', :profile => 'test_enterprise1'
@@ -15,6 +15,14 @@ all_fixtures
     login_as 'ze'
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'go to the first step on index' do
     get :index
     assert_response :success
@@ -19,6 +19,14 @@ class EnterpriseValidationControllerTest &lt; Test::Unit::TestCase
     Profile.expects(:find_by_identifier).with('myorg').returns(@org).at_least_once
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'list pending validations on index' do
     empty = []
     @org.expects(:pending_validations).returns(empty)
@@ -11,6 +11,14 @@ class EnvironmentDesignControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'indicate only actual blocks as such' do
     assert(@controller.available_blocks.all? {|item| item.new.is_a? Block})
   end
@@ -11,6 +11,14 @@ class EnvironmentRoleManagerControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   # Replace this with your real tests.
   def test_truth
     assert true
@@ -14,6 +14,14 @@ class FeaturesControllerTest &lt; Test::Unit::TestCase
     login_as(create_admin_user(Environment.find(2)))
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_listing_features
     uses_host 'anhetegua.net'
     get :index
@@ -18,6 +18,14 @@ class FriendsControllerTest &lt; Test::Unit::TestCase
   end
   attr_accessor :profile, :friend
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'list friends' do
     get :index
     assert_response :success
@@ -14,6 +14,14 @@ all_fixtures
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_detection_of_environment_by_host
     uses_host 'www.colivre.net'
     get :index
@@ -15,6 +15,14 @@ class ManageProductsControllerTest &lt; Test::Unit::TestCase
     login_as :test_user
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should "not have permission" do
     u = create_user('user_test')
     login_as :user_test
@@ -16,6 +16,14 @@ class MembershipsControllerTest &lt; Test::Unit::TestCase
   end
   attr_reader :profile
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'list current memberships' do
     get :index, :profile => profile.identifier
@@ -20,6 +20,14 @@ class MyProfileControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_should_allow_person
     @controller = OnlyForPersonTestController.new
     person = create_user('random_joe')
@@ -13,6 +13,14 @@ class ProfileControllerTest &lt; Test::Unit::TestCase
     @profile = create_user('testuser').person
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   noosfero_test :profile => 'testuser'
   should 'list friends' do
@@ -62,6 +62,14 @@ class ProfileDesignControllerTest &lt; Test::Unit::TestCase
     login_as 'ze'
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   ######################################################
   # BEGIN - tests for BoxOrganizerController features 
   ######################################################
@@ -14,6 +14,14 @@ class ProfileEditorControllerTest &lt; Test::Unit::TestCase
     login_as('ze')
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_index
     person = User.create(:login => 'test_profile', :email => 'test@noosfero.org', :password => 'test', :password_confirmation => 'test').person
     person.person_info.name = 'a test profile'
@@ -11,6 +11,14 @@ class ProfileMembersControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'not access index if dont have permission' do
     user = create_user('test_user')
     Enterprise.create!(:identifier => 'test_enterprise', :name => 'test enterprise')
@@ -5,14 +5,24 @@ require &#39;public_controller&#39;
 class PublicController; def rescue_action(e) raise e end; end
 class PublicControllerTest < Test::Unit::TestCase
+
   def setup
     @controller = PublicController.new
     @request    = ActionController::TestRequest.new
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   # Replace this with your real tests.
   def test_truth
     assert true
   end
+
 end
@@ -13,6 +13,14 @@ class RegionValidatorsControllerTest &lt; Test::Unit::TestCase
     login_as('ze')
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   # Replace this with your real tests.
   should 'list regions at index' do
     get :index
@@ -15,6 +15,14 @@ class RoleControllerTest &lt; Test::Unit::TestCase
     login_as(:ze)
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   def test_index_should_get_roles
     get 'index'
     assert_response :success
@@ -13,6 +13,14 @@ class SearchControllerTest &lt; Test::Unit::TestCase
     @category = Category.create!(:name => 'my category', :environment => Environment.default)
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+
   should 'filter stop words' do
     @controller.expects(:locale).returns('pt_BR').at_least_once
     get 'index', :query => 'a carne da vaca'
@@ -11,6 +11,14 @@ class SystemControllerTest &lt; Test::Unit::TestCase
     @response   = ActionController::TestResponse.new
   end
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   # Replace this with your real tests.
   def test_truth
     assert true
@@ -18,6 +18,14 @@ class TasksControllerTest &lt; Test::Unit::TestCase
   end
   attr_accessor :profile
+  def test_local_files_reference
+    assert_local_files_reference
+  end
+  
+  def test_valid_xhtml
+    assert_valid_xhtml
+  end
+  
   should 'list pending tasks' do
     get :index
@@ -2,6 +2,8 @@ ENV[&quot;RAILS_ENV&quot;] = &quot;test&quot;
 require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
 require 'test_help'
 require 'mocha'
+require 'tidy'
+require 'hpricot'
 require 'noosfero/test'
@@ -135,6 +137,55 @@ class Test::Unit::TestCase
     assert_equal parent, child.superclass, "Class #{child} expected to be a subclass of #{parent}"
   end
+  def assert_valid_xhtml(method=:get, action=:index, params = {})
+    if method.to_s() == 'post'
+      post action, params
+    else
+      get action, params
+    end
+    tidy = Tidy.open(:show_warnings=>false)
+    tidy.options.output_xml = true
+    tidy.clean @response.body
+    if tidy.errors
+      flunk "HTML ERROR - Tidy Diagnostics:\n  "+
+            tidy.errors.join("\n  ") +"\n  "+
+            tidy.diagnostics.join("\n  ")
+    end
+  end
+
+  def assert_local_files_reference(method=:get, action=:index, params = {})
+    if method.to_s() == 'post'
+      post action, params
+    else
+      get action, params
+    end
+    doc = Hpricot @response.body
+    
+    # Test style references:
+    (doc/'style').each do |s|
+      s = s.to_s().gsub( /\/\*.*\*\//, '' ).
+                   split( /;|<|>|\n/ ).
+                   map do |l|
+                     patch = l.match( /@import url\((.*)\)/ )
+                     patch ? patch[1] : nil
+                   end.compact
+      s.each do |css_ref|
+        if ! File.exists?( RAILS_ROOT.to_s() +'/public/'+ css_ref )
+          flunk 'CSS reference missed on HTML: "%s"' % css_ref
+        end
+      end
+    end
+
+    # Test image references:
+    (doc/'img').each do |img|
+      src = img.get_attribute( 'src' )
+      if ! File.exists?( RAILS_ROOT.to_s() +'/public/'+ src )
+        flunk 'Image reference missed on HTML: "%s"' % src
+      end
+    end
+
+  end
+
   # this check only if string has html tag
   def assert_sanitized(string)
     assert_no_match /<[^>]+\/?>/, string, "String #{string} expected to be sanitized"
	@@ -17,6 +17,14 @@ class AccountControllerTest < Test::Unit::TestCase		@@ -17,6 +17,14 @@ class AccountControllerTest < Test::Unit::TestCase
17	@response = ActionController::TestResponse.new	17	@response = ActionController::TestResponse.new
18	end	18	end
19		19
		20	+ def test_local_files_reference
		21	+ assert_local_files_reference
		22	+ end
		23	+
		24	+ def test_valid_xhtml
		25	+ assert_valid_xhtml
		26	+ end
		27	+
20	def test_should_login_and_redirect	28	def test_should_login_and_redirect
21	post :login, :user => {:login => 'johndoe', :password => 'test'}	29	post :login, :user => {:login => 'johndoe', :password => 'test'}
22	assert session[:user]	30	assert session[:user]
	@@ -11,6 +11,14 @@ class AdminControllerTest < Test::Unit::TestCase		@@ -11,6 +11,14 @@ class AdminControllerTest < Test::Unit::TestCase
11	@response = ActionController::TestResponse.new	11	@response = ActionController::TestResponse.new
12	end	12	end
13		13
		14	+ def test_local_files_reference
		15	+ assert_local_files_reference
		16	+ end
		17	+
		18	+ def test_valid_xhtml
		19	+ assert_valid_xhtml
		20	+ end
		21	+
14	# Replace this with your real tests.	22	# Replace this with your real tests.
15	def test_truth	23	def test_truth
16	assert true	24	assert true
	@@ -14,6 +14,14 @@ class AdminPanelControllerTest < Test::Unit::TestCase		@@ -14,6 +14,14 @@ class AdminPanelControllerTest < Test::Unit::TestCase
14	login_as(create_admin_user(Environment.default))	14	login_as(create_admin_user(Environment.default))
15	end	15	end
16		16
		17	+ def test_local_files_reference
		18	+ assert_local_files_reference
		19	+ end
		20	+
		21	+ def test_valid_xhtml
		22	+ assert_valid_xhtml
		23	+ end
		24	+
17	def test_index	25	def test_index
18	get :index	26	get :index
19	assert_template 'index'	27	assert_template 'index'
	@@ -12,6 +12,14 @@ class ApplicationControllerTest < Test::Unit::TestCase		@@ -12,6 +12,14 @@ class ApplicationControllerTest < Test::Unit::TestCase
12	@response = ActionController::TestResponse.new	12	@response = ActionController::TestResponse.new
13	end	13	end
14		14
		15	+ def test_local_files_reference
		16	+ assert_local_files_reference
		17	+ end
		18	+
		19	+ def test_valid_xhtml
		20	+ assert_valid_xhtml
		21	+ end
		22	+
15	def test_exist_environment_variable_to_helper_environment_identification	23	def test_exist_environment_variable_to_helper_environment_identification
16	get :index	24	get :index
17	assert_not_nil assigns(:environment)	25	assert_not_nil assigns(:environment)
	@@ -11,6 +11,14 @@ class CatalogControllerTest < Test::Unit::TestCase		@@ -11,6 +11,14 @@ class CatalogControllerTest < Test::Unit::TestCase
11	@response = ActionController::TestResponse.new	11	@response = ActionController::TestResponse.new
12	end	12	end
13		13
		14	+ def test_local_files_reference
		15	+ assert_local_files_reference
		16	+ end
		17	+
		18	+ def test_valid_xhtml
		19	+ assert_valid_xhtml
		20	+ end
		21	+
14	should 'list products of enterprise' do	22	should 'list products of enterprise' do
15	ent = Enterprise.create!(:identifier => 'test_enterprise1', :name => 'Test enteprise1')	23	ent = Enterprise.create!(:identifier => 'test_enterprise1', :name => 'Test enteprise1')
16	get :index, :profile => ent.identifier	24	get :index, :profile => ent.identifier
	@@ -20,6 +20,14 @@ class CategoriesControllerTest < Test::Unit::TestCase		@@ -20,6 +20,14 @@ class CategoriesControllerTest < Test::Unit::TestCase
20		20
21	attr_reader :env, :cat1, :cat2	21	attr_reader :env, :cat1, :cat2
22		22
		23	+ def test_local_files_reference
		24	+ assert_local_files_reference
		25	+ end
		26	+
		27	+ def test_valid_xhtml
		28	+ assert_valid_xhtml
		29	+ end
		30	+
23	def test_index	31	def test_index
24	assert user = login_as(create_admin_user(Environment.default))	32	assert user = login_as(create_admin_user(Environment.default))
25	assert user.person.has_permission?('manage_environment_categories',Environment.default ), "#{user.login} don't have permission to manage_environment_categories in #{Environment.default.name}"	33	assert user.person.has_permission?('manage_environment_categories',Environment.default ), "#{user.login} don't have permission to manage_environment_categories in #{Environment.default.name}"
	@@ -19,6 +19,14 @@ class CmsControllerTest < Test::Unit::TestCase		@@ -19,6 +19,14 @@ class CmsControllerTest < Test::Unit::TestCase
19		19
20	attr_reader :profile	20	attr_reader :profile
21		21
		22	+ def test_local_files_reference
		23	+ assert_local_files_reference
		24	+ end
		25	+
		26	+ def test_valid_xhtml
		27	+ assert_valid_xhtml
		28	+ end
		29	+
22	should 'list top level documents on index' do	30	should 'list top level documents on index' do
23	get :index, :profile => profile.identifier	31	get :index, :profile => profile.identifier
24		32
	@@ -17,6 +17,14 @@ class ConsumedProductsControllerTest < Test::Unit::TestCase		@@ -17,6 +17,14 @@ class ConsumedProductsControllerTest < Test::Unit::TestCase
17	end	17	end
18	attr_reader :profile	18	attr_reader :profile
19		19
		20	+ def test_local_files_reference
		21	+ assert_local_files_reference
		22	+ end
		23	+
		24	+ def test_valid_xhtml
		25	+ assert_valid_xhtml
		26	+ end
		27	+
20	should 'display new form' do	28	should 'display new form' do
21	login_as(profile.identifier)	29	login_as(profile.identifier)
22	get :new, :profile => profile.identifier	30	get :new, :profile => profile.identifier
	@@ -17,6 +17,14 @@ class ContentViewerControllerTest < Test::Unit::TestCase		@@ -17,6 +17,14 @@ class ContentViewerControllerTest < Test::Unit::TestCase
17	end	17	end
18	attr_reader :profile	18	attr_reader :profile
19		19
		20	+ def test_local_files_reference
		21	+ assert_local_files_reference
		22	+ end
		23	+
		24	+ def test_valid_xhtml
		25	+ assert_valid_xhtml
		26	+ end
		27	+
20	def test_should_display_page	28	def test_should_display_page
21	page = profile.articles.build(:name => 'test')	29	page = profile.articles.build(:name => 'test')
22	page.save!	30	page.save!
	@@ -15,6 +15,14 @@ class EditTemplateControllerTest < Test::Unit::TestCase		@@ -15,6 +15,14 @@ class EditTemplateControllerTest < Test::Unit::TestCase
15	login_as 'ze'	15	login_as 'ze'
16	end	16	end
17		17
		18	+ def test_local_files_reference
		19	+ assert_local_files_reference
		20	+ end
		21	+
		22	+ def test_valid_xhtml
		23	+ assert_valid_xhtml
		24	+ end
		25	+
18	def test_redirect_to_design_editor_when_index_action_is_called	26	def test_redirect_to_design_editor_when_index_action_is_called
19	give_permission('ze', 'edit_environment_design', Environment.default)	27	give_permission('ze', 'edit_environment_design', Environment.default)
20	get :index	28	get :index