Download as
Browse Code »

Commit 01ffe8dbb3a6d9dd221a75650da76a7590767340

Authored by Daniela Feitosa
1 parent 59897e5e
Exists in master and in 23 other branches activate_plugin, api_fixies, api_tasks, article_blog_visualization_format, article_layout_refactoring, article_layout_temp, blog_page_bug, clone_article, communities_ratings, design_template, event_layout, fix_forum, fix_optional_fields, fix_suggest_article, folder_improvments, manage_organization, merge_deactive_and_ban, news_page, script_to_update, stable, template_mirror_block, tests, tests_fixies

Fix: set value to position on custom forms fields 

(ActionItem2775)
Showing 3 changed files with 26 additions and 1 deletions   Show diff stats
plugins/custom_forms/db/migrate/20130822001407_set_position_to_existent_custom_forms_plugin_fields.rb 0 → 100644
  Diff comments   View file @01ffe8d
... ... @@ -0,0 +1,9 @@
  1 +class SetPositionToExistentCustomFormsPluginFields < ActiveRecord::Migration
  2 + def self.up
  3 + update("UPDATE custom_forms_plugin_fields SET position = 0 WHERE position IS NULL")
  4 + end
  5 +
  6 + def self.down
  7 + say("Nothing to undo (cannot recover the data)")
  8 + end
  9 +end
... ...
plugins/custom_forms/lib/custom_forms_plugin/field.rb
  Diff comments   View file @01ffe8d
... ... @@ -15,8 +15,12 @@ class CustomFormsPlugin::Field &lt; ActiveRecord::Base
15 15  
16 16 before_create do |field|
17 17 if field.form.fields.exists?
18   - field.position = field.form.fields.order('position').last.position + 1
  18 + field.position = field.form.fields.order(:position).last.position + 1
19 19 end
20 20 end
  21 +
  22 + def position
  23 + self[:position] || 0
  24 + end
21 25 end
22 26  
... ...
plugins/custom_forms/test/unit/custom_forms_plugin/field_test.rb
  Diff comments   View file @01ffe8d
... ... @@ -81,5 +81,17 @@ class CustomFormsPlugin::FieldTest &lt; ActiveSupport::TestCase
81 81 assert_equal 1, field_1.position
82 82 assert_equal 2, field_2.position
83 83 end
  84 +
  85 + should 'not crash when adding new fields on a form with fields without position' do
  86 + form = CustomFormsPlugin::Form.create(:name => 'Free Software', :profile => fast_create(Profile))
  87 + field_0 = CustomFormsPlugin::Field.create(:name => 'License', :form => form)
  88 + field_0.position = nil
  89 + field_0.save
  90 +
  91 + assert_nothing_raised do
  92 + field_1 = CustomFormsPlugin::Field.create!(:name => 'URL', :form => form)
  93 + end
  94 + end
  95 +
84 96 end
85 97  
... ...