Download as
Browse Code »

Commit 1098be610d999b0a54c80a299a69453dd8f1e7b5

Authored by Antonio Terceiro
1 parent 9593b2d9
Exists in master and in 23 other branches activate_plugin, api_fixies, api_tasks, article_blog_visualization_format, article_layout_refactoring, article_layout_temp, blog_page_bug, clone_article, communities_ratings, design_template, event_layout, fix_forum, fix_optional_fields, fix_suggest_article, folder_improvments, manage_organization, merge_deactive_and_ban, news_page, script_to_update, stable, template_mirror_block, tests, tests_fixies

Replacing scary eval's with String#constantize

Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
app/controllers/admin/plugins_controller.rb
  Diff comments   View file @1098be6
1 1 class PluginsController < AdminController
2 2  
3 3 def index
4   - @active_plugins = Noosfero::Plugin.all.map {|plugin_name| eval(plugin_name)}.compact
  4 + @active_plugins = Noosfero::Plugin.all.map {|plugin_name| plugin_name.constantize }.compact
5 5 end
6 6  
7 7 post_only :update
... ...
lib/noosfero/plugin/manager.rb
  Diff comments   View file @1098be6
... ... @@ -12,7 +12,7 @@ class Noosfero::Plugin::Manager
12 12  
13 13 def enabled_plugins
14 14 @enabled_plugins ||= (Noosfero::Plugin.all & context.environment.enabled_plugins).map do |plugin|
15   - p = eval(plugin).new
  15 + p = plugin.constantize.new
16 16 p.context = context
17 17 p
18 18 end
... ...