Move marking as spam and ham into the background

ActionItem2306

Move marking as spam and ham into the background
ActionItem2306
Antonio Terceiro
1 parent 149b1d38
Showing 4 changed files with 18 additions and 8 deletions Show diff stats
app/models/comment.rb
app/models/comment_handler.rb
test/unit/comment_handler_test.rb
test/unit/comment_test.rb
@@ -91,7 +91,7 @@ class Comment &lt; ActiveRecord::Base
   after_create :schedule_notification
   def schedule_notification
-    Delayed::Job.enqueue CommentHandler.new(self.id)
+    Delayed::Job.enqueue CommentHandler.new(self.id, :verify_and_notify)
   end
   delegate :environment, :to => :profile
@@ -214,15 +214,23 @@ class Comment &lt; ActiveRecord::Base
   def spam!
     self.spam = true
     self.save!
-    plugins.dispatch(:comment_marked_as_spam, self)
+    Delayed::Job.enqueue(CommentHandler.new(self.id, :marked_as_spam))
     self
   end
   def ham!
     self.spam = false
     self.save!
-    plugins.dispatch(:comment_marked_as_ham, self)
+    Delayed::Job.enqueue(CommentHandler.new(self.id, :marked_as_ham))
     self
   end
+  def marked_as_spam
+    plugins.dispatch(:comment_marked_as_spam, self)
+  end
+
+  def marked_as_ham
+    plugins.dispatch(:comment_marked_as_ham, self)
+  end
+
 end
-class CommentHandler < Struct.new(:comment_id)
+class CommentHandler < Struct.new(:comment_id, :method)
   def perform
     comment = Comment.find(comment_id)
-    comment.verify_and_notify
+    comment.send(method)
   rescue ActiveRecord::RecordNotFound
     # just ignore non-existing comments
   end
@@ -12,11 +12,11 @@ class CommentHandlerTest &lt; ActiveSupport::TestCase
     handler.perform
   end
-  should 'call Comment#notify_by_mail' do
-    handler = CommentHandler.new(-1)
+  should 'call Comment#whatever_method' do
+    handler = CommentHandler.new(-1, :whatever_method)
     comment = Comment.new
     Comment.stubs(:find).with(-1).returns(comment)
-    comment.expects(:verify_and_notify)
+    comment.expects(:whatever_method)
     handler.perform
   end
@@ -517,6 +517,7 @@ class CommentTest &lt; ActiveSupport::TestCase
     c = create_comment
     c.spam!
+    process_delayed_job_queue
     assert_equal c, SpamNotification.marked_as_spam
   end
@@ -527,6 +528,7 @@ class CommentTest &lt; ActiveSupport::TestCase
     c = create_comment
     c.ham!
+    process_delayed_job_queue
     assert_equal c, SpamNotification.marked_as_ham
   end
1	-class CommentHandler < Struct.new(:comment_id)	1	+class CommentHandler < Struct.new(:comment_id, :method)
2		2
3	def perform	3	def perform
4	comment = Comment.find(comment_id)	4	comment = Comment.find(comment_id)
5	- comment.verify_and_notify	5	+ comment.send(method)
6	rescue ActiveRecord::RecordNotFound	6	rescue ActiveRecord::RecordNotFound
7	# just ignore non-existing comments	7	# just ignore non-existing comments
8	end	8	end