Download as
Browse Code »

Commit 391b7c0f7e4e9214fde69f1015338a0ac133d33a

Authored by Arthur Esposte
1 parent 7b118e80
Exists in master and in 22 other branches activate_plugin, api_fixies, api_tasks, article_blog_visualization_format, article_layout_refactoring, article_layout_temp, blog_page_bug, clone_article, communities_ratings, design_template, event_layout, fix_forum, fix_optional_fields, fix_suggest_article, folder_improvments, manage_organization, merge_deactive_and_ban, news_page, script_to_update, template_mirror_block, tests, tests_fixies

AI3204: Fixing People block plugin bug

Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
plugins/people_block/controllers/people_block_plugin_profile_controller.rb
  Diff comments   View file @391b7c0
... ... @@ -4,7 +4,7 @@ class PeopleBlockPluginProfileController < ProfileController
4 4  
5 5 def members
6 6 if is_cache_expired?(profile.members_cache_key(params))
7   - if(params[:role_key])
  7 + unless params[:role_key].blank?
8 8 role = Role.find_by_key_and_environment_id(params[:role_key], profile.environment)
9 9 @members = profile.members.with_role(role.id).includes(relations_to_include).paginate(:per_page => members_per_page, :page => params[:npage])
10 10 @members_title = role.name
... ...
plugins/people_block/test/functional/people_block_plugin_profile_controller_test.rb
  Diff comments   View file @391b7c0
... ... @@ -34,7 +34,7 @@ class PeopleBlockPluginProfileControllerTest < ActionController::TestCase
34 34 attr_accessor :profile, :block, :admin, :member, :moderator
35 35  
36 36 should 'list members without role_key' do
37   - get :members, :profile => profile.identifier
  37 + get :members, :profile => profile.identifier, :role_key => ""
38 38 assert_response :success
39 39 assert_template 'members'
40 40 assert_equivalent [@admin, @member, @moderator], assigns(:members)
... ...