[Mezuro] Added new way of handling exceptions: error_page

Alessandro Palmeira + Paulo Meirelles · Paulo Meireles
1 parent 3cb6f6bb
Showing 5 changed files with 21 additions and 20 deletions Show diff stats
plugins/mezuro/controllers/mezuro_plugin_myprofile_controller.rb
plugins/mezuro/lib/kalibro/base_tool.rb
plugins/mezuro/lib/kalibro/configuration.rb
plugins/mezuro/lib/kalibro/model.rb
plugins/mezuro/views/mezuro_plugin_myprofile/error_page.html.erb
@@ -2,11 +2,17 @@ class MezuroPluginMyprofileController &lt; ProfileController
   append_view_path File.join(File.dirname(__FILE__) + '/../views')
- 
+  rescue_from Exception do |exception|
+    message = URI.escape(CGI.escape(exception.message),'.')
+    redirect_to "/myprofile/#{profile.identifier}/plugin/mezuro/error_page?message=#{message}"
+  end
+
+  def error_page
+  end
+
   def choose_base_tool
     @configuration_content = profile.articles.find(params[:id])
     @base_tools = Kalibro::BaseTool.all_names
-    @base_tools = [] if @base_tools.first.is_a? Exception
   end
   def choose_metric
@@ -15,17 +21,17 @@ class MezuroPluginMyprofileController &lt; ProfileController
     base_tool = Kalibro::BaseTool.find_by_name(@base_tool)
     @supported_metrics = base_tool.nil? ? [] : base_tool.supported_metrics 
   end
-  
+
   def new_metric_configuration
     @configuration_content = profile.articles.find(params[:id])
     @metric = Kalibro::BaseTool.find_by_name(params[:base_tool]).metric params[:metric_name]
   end
-  
+
   def new_compound_metric_configuration
     @configuration_content = profile.articles.find(params[:id])
     @metric_configurations = @configuration_content.metric_configurations
   end
-  
+
   def edit_metric_configuration
     @configuration_content = profile.articles.find(params[:id])
     @metric_configuration = Kalibro::MetricConfiguration.find_by_configuration_name_and_metric_name(@configuration_content.name, params[:metric_name])
@@ -3,19 +3,11 @@ class Kalibro::BaseTool &lt; Kalibro::Model
   attr_accessor :name, :description, :supported_metric
   def self.all_names
-    begin
-      request("BaseTool", :get_base_tool_names)[:base_tool_name].to_a
-    rescue Exception => exception
-      [exception]
-    end
+    request("BaseTool", :get_base_tool_names)[:base_tool_name].to_a
   end
   def self.find_by_name(base_tool_name)
-    begin
-      new request("BaseTool", :get_base_tool, {:base_tool_name => base_tool_name})[:base_tool]
-    rescue Exception
-      nil
-    end
+    new request("BaseTool", :get_base_tool, {:base_tool_name => base_tool_name})[:base_tool]
   end
   def supported_metric=(value)
@@ -21,7 +21,7 @@ class Kalibro::Configuration &lt; Kalibro::Model
   def self.find_by_name(configuration_name)
     begin
       new request("Configuration", :get_configuration, {:configuration_name => configuration_name})[:configuration]
-    rescue Exception => error
+    rescue Exception
       nil
     end
   end
@@ -60,11 +60,11 @@ class Kalibro::Model
   end
   def destroy
-   # begin
+    begin
       self.class.request(destroy_endpoint, destroy_action, destroy_params)
-    #rescue Exception => exception
-	   # add_error exception
-    #end
+    rescue Exception => exception
+	    add_error exception
+    end
   end
   protected
@@ -0,0 +1,3 @@
+<h2> <%= "An error occured: " %> </h2>
+<%=h params[:message] %>
+<!-- The <%=h is for escaping the URL properly --!>
	@@ -21,7 +21,7 @@ class Kalibro::Configuration < Kalibro::Model		@@ -21,7 +21,7 @@ class Kalibro::Configuration < Kalibro::Model
21	def self.find_by_name(configuration_name)	21	def self.find_by_name(configuration_name)
22	begin	22	begin
23	new request("Configuration", :get_configuration, {:configuration_name => configuration_name})[:configuration]	23	new request("Configuration", :get_configuration, {:configuration_name => configuration_name})[:configuration]
24	- rescue Exception => error	24	+ rescue Exception
25	nil	25	nil
26	end	26	end
27	end	27	end
@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
	1	+<h2> <%= "An error occured: " %> </h2>
	2	+<%=h params[:message] %>
	3	+<!-- The <%=h is for escaping the URL properly --!>