[Mezuro] Moved create and save methods to model.rb

Alessandro Palmeira + Caio Salgado · Paulo Meireles
1 parent fb81a867
Showing 4 changed files with 43 additions and 38 deletions Show diff stats
plugins/mezuro/lib/kalibro/configuration.rb
plugins/mezuro/lib/kalibro/metric_configuration.rb
plugins/mezuro/lib/kalibro/model.rb
plugins/mezuro/lib/kalibro/project.rb
@@ -22,20 +22,12 @@ class Kalibro::Configuration &lt; Kalibro::Model
     new request("Configuration", :get_configuration, {:configuration_name => configuration_name})[:configuration]
   end
-  def self.create(configuration_content)
-	  new ({
-	    :name => configuration_content.name,
-  	  :description => configuration_content.description
-  	}).save
-  end
-
-  def save
-    begin
-      self.class.request("Configuration", :save_configuration, {:configuration => to_hash})
-	    true
-	  rescue Exception => error
-		  false
-	  end
+  def self.create(content)
+	  attributes = {
+	    :name => content.name,
+  	  :description => content.description
+  	}
+  	super attributes
   end
   def self.all_names
@@ -48,17 +48,6 @@ class Kalibro::MetricConfiguration &lt; Kalibro::Model
     metric_configuration
   end
-  def save
-    begin
-      self.class.request("MetricConfiguration", :save_metric_configuration, {
-        :metric_configuration => to_hash,
-        :configuration_name => configuration_name})
-      true
-    rescue Exception => error
-      false
-    end
-  end
-
   def destroy
     self.class.request("MetricConfiguration", :remove_metric_configuration, {
         :configuration_name => configuration_name,
@@ -75,5 +64,9 @@ class Kalibro::MetricConfiguration &lt; Kalibro::Model
   def native?(value)
     value.has_key?(:origin) ? true : false
   end
-
+  
+  def save_params
+    {:metric_configuration => to_hash, :configuration_name => configuration_name}
+  end
+  
 end
@@ -35,6 +35,19 @@ class Kalibro::Model
   def self.to_object value
     value.kind_of?(Hash) ? new(value) : value
   end 
+  
+  def self.create(attributes={})
+    new(attributes).save
+  end
+
+  def save
+    begin
+      self.class.request(save_endpoint, save_action, save_params)
+	    true
+	  rescue Exception => error
+		  false
+	  end
+  end
   protected
@@ -72,5 +85,20 @@ class Kalibro::Model
     milliseconds = "." + (date.sec_fraction * 60 * 60 * 24 * 1000).to_s
     date.to_s[0..18] + milliseconds + date.to_s[19..-1]
   end
-
+  
+  def class_name
+    self.class.name.gsub(/Kalibro::/,"")
+  end
+  
+  def save_endpoint
+    class_name
+  end
+  
+  def save_action
+    "save_#{class_name.underscore}".to_sym
+  end
+  
+  def save_params
+    {class_name.underscore.to_sym => self.to_hash}
+  end
 end
@@ -11,7 +11,7 @@ class Kalibro::Project &lt; Kalibro::Model
   end
   def self.create(content)
-    new({
+    attributes = {
       :name => content.name,
       :license => content.license,
       :description => content.description,
@@ -20,22 +20,14 @@ class Kalibro::Project &lt; Kalibro::Model
         :address => content.repository_url
       },
       :configuration_name => content.configuration_name
-    }).save
+    }
+    super attributes
   end
   def destroy
     self.class.request("Project", :remove_project, {:project_name => name})
   end
-  def save
-    begin
-      self.class.request("Project", :save_project, {:project => to_hash})
-      true
-    rescue Exception => error
-      false
-    end
-  end
-
   def repository=(value)
     @repository = Kalibro::Repository.to_object value
   end
	@@ -22,20 +22,12 @@ class Kalibro::Configuration < Kalibro::Model		@@ -22,20 +22,12 @@ class Kalibro::Configuration < Kalibro::Model
22	new request("Configuration", :get_configuration, {:configuration_name => configuration_name})[:configuration]	22	new request("Configuration", :get_configuration, {:configuration_name => configuration_name})[:configuration]
23	end	23	end
24		24
25	- def self.create(configuration_content)
26	- new ({
27	- :name => configuration_content.name,
28	- :description => configuration_content.description
29	- }).save
30	- end
31	-
32	- def save
33	- begin
34	- self.class.request("Configuration", :save_configuration, {:configuration => to_hash})
35	- true
36	- rescue Exception => error
37	- false
38	- end	25	+ def self.create(content)
		26	+ attributes = {
		27	+ :name => content.name,
		28	+ :description => content.description
		29	+ }
		30	+ super attributes
39	end	31	end
40		32
41	def self.all_names	33	def self.all_names
	@@ -35,6 +35,19 @@ class Kalibro::Model		@@ -35,6 +35,19 @@ class Kalibro::Model
35	def self.to_object value	35	def self.to_object value
36	value.kind_of?(Hash) ? new(value) : value	36	value.kind_of?(Hash) ? new(value) : value
37	end	37	end
		38	+
		39	+ def self.create(attributes={})
		40	+ new(attributes).save
		41	+ end
		42	+
		43	+ def save
		44	+ begin
		45	+ self.class.request(save_endpoint, save_action, save_params)
		46	+ true
		47	+ rescue Exception => error
		48	+ false
		49	+ end
		50	+ end
38		51
39	protected	52	protected
40		53
	@@ -72,5 +85,20 @@ class Kalibro::Model		@@ -72,5 +85,20 @@ class Kalibro::Model
72	milliseconds = "." + (date.sec_fraction * 60 * 60 * 24 * 1000).to_s	85	milliseconds = "." + (date.sec_fraction * 60 * 60 * 24 * 1000).to_s
73	date.to_s[0..18] + milliseconds + date.to_s[19..-1]	86	date.to_s[0..18] + milliseconds + date.to_s[19..-1]
74	end	87	end
75	-	88	+
		89	+ def class_name
		90	+ self.class.name.gsub(/Kalibro::/,"")
		91	+ end
		92	+
		93	+ def save_endpoint
		94	+ class_name
		95	+ end
		96	+
		97	+ def save_action
		98	+ "save_#{class_name.underscore}".to_sym
		99	+ end
		100	+
		101	+ def save_params
		102	+ {class_name.underscore.to_sym => self.to_hash}
		103	+ end
76	end	104	end