Download as
Browse Code »

Commit 85a349c76fce607372bcb91bbf481256fbdc2392

Authored by Antonio Terceiro
1 parent 2fbcd1d3
Exists in master and in 23 other branches activate_plugin, api_fixies, api_tasks, article_blog_visualization_format, article_layout_refactoring, article_layout_temp, blog_page_bug, clone_article, communities_ratings, design_template, event_layout, fix_forum, fix_optional_fields, fix_suggest_article, folder_improvments, manage_organization, merge_deactive_and_ban, news_page, script_to_update, stable, template_mirror_block, tests, tests_fixies

Fix bug introduced by "Displaying image title at <title> tag" 

(ActionItem1416)
Showing 6 changed files with 40 additions and 20 deletions   Show diff stats
app/helpers/folder_helper.rb
  Diff comments   View file @85a349c
... ... @@ -69,11 +69,4 @@ module FolderHelper
69 69 _('Edit folder')
70 70 end
71 71  
72   - def short_filename(filename, limit_chars = 43)
73   - return filename if filename.size <= limit_chars
74   - extname = File.extname(filename)
75   - basename = File.basename(filename,extname)
76   - str_complement = '(...)'
77   - return basename[0..(limit_chars - extname.size - str_complement.size - 1)] + str_complement + extname
78   - end
79 72 end
... ...
app/models/uploaded_file.rb
  Diff comments   View file @85a349c
... ... @@ -4,9 +4,11 @@
4 4 # of the file itself is kept. (FIXME?)
5 5 class UploadedFile < Article
6 6  
  7 + include Noosfero::Filenames
  8 +
7 9 settings_items :title, :type => 'string'
8 10 def title_with_default
9   - title_without_default || name
  11 + title_without_default || short_filename(name, 60)
10 12 end
11 13 alias_method_chain :title, :default
12 14  
... ...
lib/noosfero/filenames.rb 0 → 100644
  Diff comments   View file @85a349c
... ... @@ -0,0 +1,11 @@
  1 +module Noosfero::Filenames
  2 +
  3 + def short_filename(filename, limit_chars = 43)
  4 + return filename if filename.size <= limit_chars
  5 + extname = File.extname(filename)
  6 + basename = File.basename(filename,extname)
  7 + str_complement = '(...)'
  8 + return basename[0..(limit_chars - extname.size - str_complement.size - 1)] + str_complement + extname
  9 + end
  10 +
  11 +end
... ...
test/unit/application_helper_test.rb
  Diff comments   View file @85a349c
... ... @@ -567,18 +567,6 @@ class ApplicationHelperTest &lt; Test::Unit::TestCase
567 567 assert_equal environment.theme, current_theme
568 568 end
569 569  
570   - should 'trunc to 15 chars the big filename' do
571   - assert_equal 'AGENDA(...).mp3', short_filename('AGENDA_CULTURA_-_FESTA_DE_VAQUEIROS_PONTO_DE_SERRA_PRETA_BAIXA.mp3',15)
572   - end
573   -
574   - should 'trunc to default limit the big filename' do
575   - assert_equal 'AGENDA_CULTURA_-_FESTA_DE_VAQUEIRO(...).mp3', short_filename('AGENDA_CULTURA_-_FESTA_DE_VAQUEIROS_PONTO_DE_SERRA_PRETA_BAIXA.mp3')
576   - end
577   -
578   - should 'does not trunc short filename' do
579   - assert_equal 'filename.mp3', short_filename('filename.mp3')
580   - end
581   -
582 570 protected
583 571  
584 572 def url_for(args = {})
... ...
test/unit/noosfero_filenames.rb 0 → 100644
  Diff comments   View file @85a349c
... ... @@ -0,0 +1,20 @@
  1 +require File.dirname(__FILE__) + '/../test_helper'
  2 +
  3 +class NoosferoFilenamesTest < Test::Unit::TestCase
  4 +
  5 + include Noosfero::Filenames
  6 +
  7 + should 'trunc to 15 chars the big filename' do
  8 + assert_equal 'AGENDA(...).mp3', short_filename('AGENDA_CULTURA_-_FESTA_DE_VAQUEIROS_PONTO_DE_SERRA_PRETA_BAIXA.mp3',15)
  9 + end
  10 +
  11 + should 'trunc to default limit the big filename' do
  12 + assert_equal 'AGENDA_CULTURA_-_FESTA_DE_VAQUEIRO(...).mp3', short_filename('AGENDA_CULTURA_-_FESTA_DE_VAQUEIROS_PONTO_DE_SERRA_PRETA_BAIXA.mp3')
  13 + end
  14 +
  15 + should 'does not trunc short filename' do
  16 + assert_equal 'filename.mp3', short_filename('filename.mp3')
  17 + end
  18 +
  19 +end
  20 +
... ...
test/unit/uploaded_file_test.rb
  Diff comments   View file @85a349c
... ... @@ -150,4 +150,10 @@ class UploadedFileTest &lt; Test::Unit::TestCase
150 150 assert_equal 'test.txt', upload.title
151 151 end
152 152  
  153 + should 'use name as title by default but cut down the title' do
  154 + upload = UploadedFile.new(:uploaded_data => fixture_file_upload('/files/AGENDA_CULTURA_-_FESTA_DE_VAQUEIROS_PONTO_DE_SERRA_PRETA_BAIXA.txt'))
  155 + upload.valid?
  156 + assert_nil upload.errors[:title]
  157 + end
  158 +
153 159 end
... ...