ActionItem928: adding list of media when editing with tinymce

* added an iframe to list media * display images and documents to insert in editor * added a partial to upload files * added pagination for images and documents * adding scroll on the left and javascript to scroll down * listing folders with full_name

ActionItem928: adding list of media when editing with tinymce
* added an iframe to list media * display images and documents to insert in editor * added a partial to upload files * added pagination for images and documents * adding scroll on the left and javascript to scroll down * listing folders with full_name
Daniela Feitosa · Antonio Terceiro
1 parent dcebd712
Showing 16 changed files with 519 additions and 37 deletions Show diff stats
app/controllers/my_profile/cms_controller.rb
app/helpers/cms_helper.rb
app/views/cms/_document_link.rhtml
app/views/cms/_image_thumb.rhtml
app/views/cms/_media_listing.rhtml
app/views/cms/_select_folder.rhtml
app/views/cms/_tiny_mce_article.rhtml
app/views/cms/_upload_file.rhtml
app/views/cms/_upload_file_form.rhtml
app/views/cms/edit.rhtml
app/views/cms/media_listing.rhtml
app/views/cms/upload_files.rhtml
public/javascripts/application.js
public/stylesheets/controller_cms.css
public/stylesheets/media_listing.css
test/functional/cms_controller_test.rb
@@ -59,7 +59,9 @@ class CmsController &lt; MyProfileController
   def edit
     @article = profile.articles.find(params[:id])
     @parent_id = params[:parent_id]
-    @type = params[:type]
+    @type = params[:type] || @article.class.to_s
+
+    refuse_blocks
     if !@article.nil? && @article.blog? || !@type.nil? && @type == 'Blog'
       @back_url = url_for(:controller => 'profile_editor', :profile => profile.identifier)
     end
@@ -77,8 +79,8 @@ class CmsController &lt; MyProfileController
     # FIXME this method should share some logic wirh edit !!!
     # user must choose an article type first
+
     @type = params[:type]
-    
     if @type.blank?
       @article_types = []
       available_article_types.each do |type|
@@ -95,6 +97,7 @@ class CmsController &lt; MyProfileController
       if @type == 'Blog'
         @back_url = url_for(:controller => 'profile_editor', :profile => profile.identifier)
       end
+      refuse_blocks
     end
     raise "Invalid article type #{@type}" unless valid_article_type?(@type)
@@ -134,14 +137,21 @@ class CmsController &lt; MyProfileController
     @uploaded_files = []
     @article = @parent = check_parent(params[:parent_id])
     @target = @parent ? ('/%s/%s' % [profile.identifier, @parent.full_name]) : '/%s' % profile.identifier
+    @folders = Folder.find(:all, :conditions => { :profile_id => profile })
     record_coming_from_public_view if @article
     if request.post? && params[:uploaded_files]
       params[:uploaded_files].each do |file|
         @uploaded_files << UploadedFile.create(:uploaded_data => file, :profile => profile, :parent => @parent) unless file == ''
       end
       @errors = @uploaded_files.select { |f| f.errors.any? }
+      @back_to = params[:back_to]
       if @errors.any?
-        render :action => 'upload_files', :parent_id => @parent_id
+        if @back_to && @back_to == 'media_listing'
+          flash[:notice] = _('Could not upload all files')
+          redirect_back
+        else
+          render :action => 'upload_files', :parent_id => @parent_id
+        end
       else
         if params[:back_to]
           redirect_back
@@ -199,6 +209,39 @@ class CmsController &lt; MyProfileController
     end
   end
+  def media_listing
+    if params[:image_folder_id]
+      folder = profile.articles.find(params[:image_folder_id]) if !params[:image_folder_id].blank?
+      @images = (folder ? folder.children : UploadedFile.find(:all, :conditions => ["profile_id = ? AND parent_id is NULL", profile ])).select { |c| c.image? }
+    elsif params[:document_folder_id]
+      folder = profile.articles.find(params[:document_folder_id]) if !params[:document_folder_id].blank?
+      @documents = (folder ? folder.children : UploadedFile.find(:all, :conditions => ["profile_id = ? AND parent_id is NULL", profile ])).select { |c| c.kind_of?(UploadedFile) && !c.image? }
+    else
+      @documents = UploadedFile.find(:all, :conditions => ["profile_id = ? AND parent_id is NULL", profile ])
+      @images = @documents.select(&:image?)
+      @documents -= @images
+    end
+
+    @images = @images.paginate(:per_page => per_page, :page => params[:ipage]) if @images
+    @documents = @documents.paginate(:per_page => per_page, :page => params[:dpage]) if @documents
+
+    @folders = Folder.find(:all, :conditions => { :profile_id => profile })
+    @image_folders = @folders.select {|f| f.children.any? {|c| c.image?} }
+    @document_folders = @folders.select {|f| f.children.any? {|c| !c.image? && c.kind_of?(UploadedFile) } }
+
+    @back_to = 'media_listing'
+
+    respond_to do |format|
+      format.html { render :layout => false}
+      format.js {
+        render :update do |page|
+          page.replace_html 'media-listing-folder-images', :partial => 'image_thumb', :locals => {:images => @images } if !@images.blank?
+          page.replace_html 'media-listing-folder-documents', :partial => 'document_link', :locals => {:documents => @documents } if !@documents.blank?
+        end
+      }
+    end
+  end
+
   protected
   def redirect_back
@@ -206,6 +249,8 @@ class CmsController &lt; MyProfileController
       redirect_to :controller => 'profile_editor', :profile => @profile.identifier
     elsif params[:back_to] == 'public_view'
       redirect_to @article.view_url
+    elsif params[:back_to] == 'media_listing'
+      redirect_to :action => 'media_listing'
     elsif @article.parent
       redirect_to :action => 'view', :id => @article.parent
     else
@@ -239,7 +284,7 @@ class CmsController &lt; MyProfileController
   end
   def check_parent(id)
-    if id
+    if !id.blank?
       parent = profile.articles.find(id)
       if ! parent.allow_children?
         raise ArgumentError.new("cannot create child of article which does not accept children")
@@ -249,5 +294,15 @@ class CmsController &lt; MyProfileController
       nil
     end
   end
+
+  def refuse_blocks
+    if ['TinyMceArticle', 'Event', 'EnterpriseHomepage'].include?(@type)
+      @no_design_blocks = true
+    end
+  end
+
+  def per_page
+    10
+  end
 end
@@ -9,12 +9,21 @@ module CmsHelper
     mime_type.gsub('/', '_').gsub('-', '')
   end
-  def add_upload_file_field(name)
+  def add_upload_file_field(name, locals)
     button_to_function :add, name, nil do |page|
-      page.insert_html :bottom, :uploaded_files, :partial => 'upload_file', :object => UploadedFile.new
+      page.insert_html :bottom, :uploaded_files, :partial => 'upload_file', :locals => locals, :object => UploadedFile.new
     end
   end
+  def select_folder(object, method, collection, html_options, js_options)
+    labelled_form_field(_('Folder'), select(object, method, collection.map {|f| [ profile.identifier + '/' + f.full_name, f.id ] }, html_options.merge({:include_blank => "#{profile.identifier}"}), js_options))
+  end
+
+  def pagination_links(collection, options={})
+    options = {:prev_label => '&laquo; ', :next_label => ' &raquo;', :page_links => false}.merge(options)
+    will_paginate(collection, options)
+  end
+
   attr_reader :environment
   def options_for_article(article)
@@ -0,0 +1,10 @@
+<div id='media-listing-folder-documents' >
+  <ul>
+    <% documents.each do |document| %>
+      <li><%= link_to(image_tag(icon_for_article(document)) + document.name, document.view_url) %></li>
+    <% end %>
+  </ul>
+  <div id='pagination-documents'>
+    <%= pagination_links documents, :param_name => 'dpage', :params => {:document_folder_id => params[:document_folder_id]} %>
+  </div>
+</div>
@@ -0,0 +1,10 @@
+<div id='media-listing-folder-images' >
+  <ul>
+    <% images.each do |image| %>
+      <li><%= image_tag url_for(image.url) %></li>
+    <% end %>
+  </ul>
+  <div id='pagination-images'>
+    <%= pagination_links images, :param_name => 'ipage', :params => {:image_folder_id => params[:image_folder_id]} %>
+  </div>
+</div>
@@ -0,0 +1,3 @@
+<iframe id='media-listing-iframe' src="<%= url_for(:controller => 'cms', :action => 'media_listing', :profile => profile.identifier, :type => @type) %>">
+  <p><%= _('Your browser does not support iframes.') %></p>
+</iframe>
@@ -0,0 +1 @@
+<%= select('folder', 'folder_id', @image_folders.collect {|f| [ f.name, f.id ] }, {:include_blank => "#{profile.identifier}"}, :onchange => remote_function(:update => 'media-listing-folder-images', :with => "'folder_id=' + value", :url => { :action => :get_images }) ) %>
@@ -2,13 +2,15 @@
 <%= render :file => 'shared/tiny_mce' %>
-<% if profile.enterprise? && environment.enabled?('disable_cms') && !@article.name.blank? %>
-  <div>
-    <%= _('Title') %>: <%= @article.name %>
-  </div>
-<% else %>
-  <%= required labelled_form_field(_('Title'), text_field(:article, 'name', :size => '64')) %>
-<% end %>
+<div style='margin-left: 20px;'>
+  <% if profile.enterprise? && environment.enabled?('disable_cms') && !@article.name.blank? %>
+    <div>
+      <%= _('Title') %>: <%= @article.name %>
+    </div>
+  <% else %>
+    <%= required labelled_form_field(_('Title'), text_field(:article, 'name', :size => '64')) %>
+  <% end %>
-<%= labelled_form_field(_('Text'), text_area(:article, 'body', :cols => 40, :style => 'width:99%')) %>
+  <%= labelled_form_field(_('Text'), text_area(:article, 'body', :cols => 40, :style => 'width:100%')) %>
+</div>
-<p><%= file_field_tag('uploaded_files[]', :size => 50) %></p>
+<p><%= file_field_tag('uploaded_files[]', :size => size) %></p>
+<%= javascript_tag("$('uploaded_files').scrollTop = $('uploaded_files').scrollHeight") %>
@@ -0,0 +1,25 @@
+<% if @parent %>
+  <%= hidden_field_tag('parent_id', @parent.id) %>
+<% else %>
+  <h4><%= _('Choose folder to upload files:') %></h4>
+  <%= select_tag('parent_id', options_for_select([[profile.identifier, '']] + @folders.collect {|f| [ f.name, f.id ] })) %>
+<% end %>
+
+<div id='uploaded_files'>
+  <% 3.times do %>
+    <%= render :partial => 'upload_file', :locals => {:size => size} %>
+  <% end %>
+</div>
+
+<%= hidden_field_tag('back_to', @back_to) if @back_to %>
+
+<% button_bar do %>
+  <%= add_upload_file_field(_('More files'), {:size => size}) %>
+  <% if @back_to == 'media_listing' %>
+    <%= submit_button :save, _('Upload') %>
+  <% elsif @back_url %>
+    <%= submit_button :save, _('Upload'), :cancel => @back_url %>
+  <% else %>
+    <%= submit_button :save, _('Upload'), :cancel => {:action => (@parent ? 'view' : 'index'), :id => @parent } %>
+  <% end %>
+<% end %>
 <%= error_messages_for 'article' %>
-<% labelled_form_for 'article', @article, :html => { :multipart => true } do |f| %>
+<% labelled_form_for 'article', @article, :html => { :multipart => true, :style => 'width:57%;float:left;' } do |f| %>
   <%= hidden_field_tag("type", @type) if @type %>
@@ -38,3 +38,7 @@
     <% end %>
   <% end %>
 <% end %>
+
+<% if [TinyMceArticle, Event, EnterpriseHomepage].any?{|klass| @article.kind_of?(klass)} %>
+  <%= render :partial => 'media_listing' %>
+<% end %>
@@ -0,0 +1,62 @@
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<%= html_language %>" lang="<%= html_language %>">
+<head>
+  <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+  <%=
+      stylesheet_import( %w( media_listing button ) ) + "\n" +
+      stylesheet_import( %w( media_listing button ), :themed_source => true )
+  %>
+  <%= javascript_include_tag :defaults %>
+  <%= javascript_include_tag 'lowpro' %>
+  <%= stylesheet_link_tag '/designs/icons/default/style.css' %>
+</head>
+<body class='noosfero'>
+  <script type="text/javascript">
+    /* Adds a class to "msie" to the body element if a Microsoft browser is
+     * detected. This is needed to workaround several of their limitations.
+     */
+    if ( navigator.appVersion.indexOf("MSIE") > -1 ) {
+      document.body.className += " msie msie" +
+        navigator.appVersion.replace(/^.*MSIE\s+([0-9]+).*$/, "$1");
+    }
+    function registerDocumentSize() {
+      document.body.className = document.body.className.replace(/(^| )docSize.+( |$)/g, " ");
+      for ( var x=100; x<=1500; x+=100 ) {
+        if ( document.body.clientWidth > x ) {
+          document.body.className += " docSize-GT-" + x;
+        } else {
+          document.body.className += " docSize-LT-" + x;
+        }
+      }
+    }
+    registerDocumentSize();
+  </script>
+  <div id='media-listing'>
+    <div id='media-listing-images'>
+      <h3><%= _('Images') %></h3>
+      <%= select_folder('folder', 'image_folder_id', @image_folders, {}, :onchange => remote_function(:with => "'image_folder_id=' + value + '&ipage=1'", :url => { :action => :media_listing, :format => 'js' }) ) %>
+      <%= render :partial => 'image_thumb', :locals => { :images => @images } %>
+    </div><!-- id='media-listing-images' -->
+    <div id='media-listing-documents'>
+      <h3><%= _('Documents') %></h3>
+      <%= select_folder('folder', 'document_folder_id', @document_folders, {}, :onchange => remote_function(:with => "'document_folder_id=' + value + '&dpage=1'", :url => { :action => :media_listing }) ) %>
+      <%= render :partial => 'document_link', :locals => { :documents => @documents } %>
+    </div><!-- id='media-listing-documents' -->
+    <br style="clear:both" />
+    <p><%= _('If you want to add images or links to files in your article, click on the file you want, drag it to the text area and drop the file.') %></p>
+    <br style="clear:both" />
+  </div><!-- id='media-listing' -->
+  <div id='media-listing-upload'>
+    <div id="notice" onclick="Element.hide('notice');" style="display:none">
+      <% unless flash[:notice].nil? %>
+        <%= flash[:notice] unless flash[:notice].nil? %>
+        <%= javascript_tag(visual_effect( :appear, 'notice')) %>
+      <% end %>
+    </div>
+
+    <% form_for('uploaded_file', :url => {:action => 'upload_files'}, :html => {:multipart => true}) do |f| %>
+      <%= hidden_field_tag('back_to', @back_to) %>
+      <%= render :partial => 'upload_file_form', :locals => { :size => '30' } %>
+    <% end %>
+  </div><!-- id='media-listing-upload' -->
+</body>
+</html>
@@ -20,24 +20,5 @@
 <h5><%= _('Uploading files to %s') % content_tag('code', @target) %></h5>
 <% form_for('uploaded_file', :url => { :action => 'upload_files' }, :html => {:multipart => true}) do |f| %>
-
-  <div id='uploaded_files'>
-    <% 3.times do %>
-      <%= render :partial => 'upload_file' %>
-    <% end %>
-  </div>
-
-  <%= hidden_field_tag('parent_id', @parent.id) if @parent %>
-
-  <%= hidden_field_tag('back_to', @back_to) if @back_to %>
-
-  <% button_bar do %>
-    <%= add_upload_file_field _('More files') %>
-    <% if @back_url %>
-      <%= submit_button :save, _('Upload'), :cancel => @back_url %>
-    <% else %>
-      <%= submit_button :save, _('Upload'), :cancel => {:action => (@parent ? 'view' : 'index'), :id => @parent } %>
-    <% end %>
-  <% end %>
-
+  <%= render :partial => 'upload_file_form', :locals => { :size => '50'} %>
 <% end %>
@@ -41,3 +41,11 @@ function convToValidLogin( str ) {
             .replace( /[^-_a-z0-9]+/g, "" )
 }
+document.observe("dom:loaded", function() {
+  Event.addBehavior.reassignAfterAjax = true;
+  Event.addBehavior({
+    'div#pagination-images .pagination a' : Remote.Link,
+    'div#pagination-documents .pagination a' : Remote.Link
+  })
+});
+
@@ -145,3 +145,19 @@ div.file-manager-button a:hover {
 #fetch-external-feed #external-feed-options .formfield {
   display: block;
 }
+
+/* Media listing */
+
+#media-listing-iframe {
+  float: right;
+  width: 40%;
+  height: 630px;
+  border: none;
+  margin: 115px 20px 0px 0px;
+  padding: 0px;
+  overflow: hidden;
+}
+
+.msie #media-listing-iframe {
+  height: 610px;
+}
@@ -0,0 +1,146 @@
+body {
+  padding: 0px;
+  margin: 0px;
+  font-family: Verdana, sans-serif;
+  font-size: 14px;
+  color: #444;
+  background-color: #F0F0EE;
+  border: 1px solid #CCC;
+  overflow: hidden;
+}
+
+h3, h4, h5 {
+  margin: 10px 0px;
+}
+
+h3 {
+  font-size: 18px;
+}
+
+h4 {
+  font-size: 16px;
+}
+
+#media-listing {
+  width: 100%;
+  height: 65%;
+  margin: 0px;
+  padding: 0px;
+  border-bottom: 2px solid #444;
+}
+
+#media-listing p {
+  font-size: 14px;
+  margin: 5px 5px;
+}
+
+#media-listing li {
+  list-style: none;
+  margin: 0px;
+}
+
+#media-listing a {
+  text-decoration: none;
+}
+
+#media-listing select {
+  width: 80%;
+}
+
+#media-listing-images {
+  margin-top: 2px;
+  width: 46%;
+  height: 80%;
+  float: left;
+  text-align: center;
+}
+
+#media-listing-images img {
+  max-width: 80px;
+  max-height: 60px;
+}
+
+.msie6 #media-listing-images img,
+.msie7 #media-listing-images img {
+  width: 80px;
+  height: 60px;
+}
+
+#media-listing-folder-images {
+  height: 75%;
+}
+
+#media-listing ul {
+  padding: 0px;
+  margin: 5px;
+  height: 65%;
+  overflow: auto;
+  width: 98%;
+}
+
+#media-listing-documents ul {
+  text-align: left;
+}
+
+#media-listing-documents {
+  margin: 2px 0px 0px 2px;
+  width: 52%;
+  height: 80%;
+  float: left;
+  text-align: center;
+}
+
+#media-listing-folder-documents {
+  height: 75%;
+}
+
+#media-listing-folder-documents img {
+  border: none;
+}
+
+#media-listing-upload {
+  height: 38%;
+  width: 98%;
+  padding: 3px;
+}
+
+#media-listing-upload p {
+  margin: 5px 0px;
+}
+
+#media-listing-upload select {
+  width: 90%;
+}
+
+#uploaded_files {
+  overflow-x: hidden;
+  overflow-y: scroll;
+  height: 100px;
+}
+
+.msie #uploaded_files {
+  height: 100px;
+  padding: 0px;
+}
+
+.formlabel {
+  font-size: 11px;
+  display: block;
+}
+
+/* Notice */
+
+div#notice {
+  background: #fee;
+  border: 1px solid #933;
+  bottom: 150px;
+  color: black;
+  cursor: pointer;
+  font-weight: bold;
+  left: 50%;
+  margin-left: -150px;
+  padding: 5px;
+  position: absolute;
+  text-align: center;
+  width: 300px;
+}
@@ -278,7 +278,6 @@ class CmsControllerTest &lt; Test::Unit::TestCase
     assert_template 'upload_files'
   end
-
   should 'offer to create children' do
     Article.any_instance.stubs(:allow_children?).returns(true)
@@ -942,4 +941,154 @@ class CmsControllerTest &lt; Test::Unit::TestCase
     assert_tag :tag => 'input', :attributes => { :name => 'article[external_feed_builder][only_once]', :checked => 'checked', :value => 'true' }
   end
+  should 'display iframe for media listing when it is TinyMceArticle' do
+    image_folder = Folder.create(:profile => profile, :name => 'Image folder')
+    non_image_folder = Folder.create(:profile => profile, :name => 'Non image folder')
+
+    image = UploadedFile.create!(:profile => profile, :parent => image_folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    file = UploadedFile.create!(:profile => profile, :parent => non_image_folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+
+    get :new, :profile => profile.identifier, :type => 'TinyMceArticle'
+    assert_tag :tag => 'iframe', :attributes => { :src => "/myprofile/#{profile.identifier}/cms/media_listing?type=TinyMceArticle" }
+  end
+
+  should 'not display iframe for media listing when it is Folder' do
+    image_folder = Folder.create(:profile => profile, :name => 'Image folder')
+    non_image_folder = Folder.create(:profile => profile, :name => 'Non image folder')
+
+    image = UploadedFile.create!(:profile => profile, :parent => image_folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    file = UploadedFile.create!(:profile => profile, :parent => non_image_folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+
+    get :new, :profile => profile.identifier, :type => 'Folder'
+    assert_no_tag :tag => 'iframe', :attributes => { :src => "/myprofile/#{profile.identifier}/cms/media_listing" }
+  end
+
+  should 'display list of images' do
+    file = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    get :media_listing, :profile => profile.identifier
+    assert_tag :tag => 'div', :attributes => { :id => 'media-listing-images' }, :descendant => { :tag => 'img', :attributes => {:src => /#{file.name}/}}
+  end
+
+  should 'display list of documents' do
+    file = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+    get :media_listing, :profile => profile.identifier
+    assert_tag :tag => 'div', :attributes => { :id => 'media-listing-documents' }, :descendant => { :tag => 'a', :attributes => {:href => /#{file.name}/}}
+  end
+
+  should 'list image folders to select' do
+    image_folder = Folder.create(:profile => profile, :name => 'Image folder')
+    non_image_folder = Folder.create(:profile => profile, :name => 'Non image folder')
+
+    image = UploadedFile.create!(:profile => profile, :parent => image_folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    file = UploadedFile.create!(:profile => profile, :parent => non_image_folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+
+    get :media_listing, :profile => profile.identifier
+    assert_tag :tag => 'div', :attributes => { :id => 'media-listing-images' }, :descendant => { :tag => 'option', :content => /#{image_folder.name}/, :attributes => { :value => image_folder.id}}
+    assert_no_tag :tag => 'div', :attributes => { :id => 'media-listing-images' }, :descendant => { :tag => 'option', :content => /#{non_image_folder.name}/, :attributes => { :value => non_image_folder.id}}
+  end
+
+  should 'list documents folders to select' do
+    image_folder = Folder.create(:profile => profile, :name => 'Image folder')
+    non_image_folder = Folder.create(:profile => profile, :name => 'Non image folder')
+
+    image = UploadedFile.create!(:profile => profile, :parent => image_folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    file = UploadedFile.create!(:profile => profile, :parent => non_image_folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+
+    get :media_listing, :profile => profile.identifier
+    assert_no_tag :tag => 'div', :attributes => { :id => 'media-listing-documents' }, :descendant => { :tag => 'option', :content => /#{image_folder.name}/, :attributes => { :value => image_folder.id}}
+    assert_tag :tag => 'div', :attributes => { :id => 'media-listing-documents' }, :descendant => { :tag => 'option', :content => /#{non_image_folder.name}/, :attributes => { :value => non_image_folder.id}}
+  end
+
+  should 'get a list of images from a image folder' do
+    folder = Folder.create(:profile => profile, :name => 'Image folder')
+    other_folder = Folder.create(:profile => profile, :name => 'Non image folder')
+    image = UploadedFile.create!(:profile => profile, :parent => folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    file_in_folder = UploadedFile.create!(:profile => profile, :parent => folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+    image_in_other_folder = UploadedFile.create!(:profile => profile, :parent => other_folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+
+    get :media_listing, :profile => profile.identifier, :image_folder_id => folder.id, :format => 'js'
+
+    assert_includes assigns(:images), image
+    assert_not_includes assigns(:images), file_in_folder
+    assert_not_includes assigns(:images), image_in_other_folder
+  end
+
+  should 'get a list of images from profile' do
+    image = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    folder = Folder.create(:profile => profile, :name => 'Image folder')
+    image_in_folder = UploadedFile.create!(:profile => profile, :parent => folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    get :media_listing, :profile => profile.identifier, :image_folder_id => '', :format => 'js'
+
+    assert_includes assigns(:images), image
+    assert_not_includes assigns(:images), image_in_folder
+  end
+
+  should 'get a list of documents from a document folder' do
+    folder = Folder.create(:profile => profile, :name => 'Non images folder')
+    other_folder = Folder.create(:profile => profile, :name => 'Image folder')
+    file = UploadedFile.create!(:profile => profile, :parent => folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+    image = UploadedFile.create!(:profile => profile, :parent => folder, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+    file_in_other_folder = UploadedFile.create!(:profile => profile, :parent => other_folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+
+    get :media_listing, :profile => profile.identifier, :document_folder_id => folder.id, :format => 'js'
+
+    assert_includes assigns(:documents), file
+    assert_not_includes assigns(:documents), image
+    assert_not_includes assigns(:documents), file_in_other_folder
+  end
+
+  should 'get a list of documents from profile' do
+    file = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+    folder = Folder.create(:profile => profile, :name => 'Image folder')
+    file_in_folder = UploadedFile.create!(:profile => profile, :parent => folder, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+
+    get :media_listing, :profile => profile.identifier, :document_folder_id => '', :format => 'js'
+
+    assert_includes assigns(:documents), file
+    assert_not_includes assigns(:documents), file_in_folder
+  end
+
+  should 'display pagination links of images' do
+    @controller.stubs(:per_page).returns(1)
+    image = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/rails.png', 'image/png'))
+
+    fixture_filename = '/files/other-pic.jpg'
+    filename = RAILS_ROOT + '/test/fixtures' + fixture_filename
+    system('echo "image for test" | convert -background yellow -page 32x32 text:- %s' % filename)
+
+    image2 = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload(fixture_filename, 'image/jpg'))
+
+    get :media_listing, :profile => profile.identifier
+
+    assert_includes assigns(:images), image
+    assert_not_includes assigns(:images), image2
+
+    File.rm_f(filename)
+  end
+
+  should 'display pagination links of documents' do
+    @controller.stubs(:per_page).returns(1)
+    file = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/test.txt', 'text/plain'))
+    file2 = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('/files/feed.xml', 'text/xml'))
+
+    get :media_listing, :profile => profile.identifier
+
+    assert_includes assigns(:documents), file
+    assert_not_includes assigns(:documents), file2
+  end
+
+
+  should 'redirect to media listing when upload files from there' do
+    post :upload_files, :profile => profile.identifier, :back_to => 'media_listing', :uploaded_files => [fixture_file_upload('files/rails.png', 'image/png')]
+    assert_template nil
+    assert_redirected_to :action => 'media_listing'
+  end
+
+  should 'redirect to media listing when occur errors when upload files from there' do
+    file = UploadedFile.create!(:profile => profile, :uploaded_data => fixture_file_upload('files/rails.png', 'image/png'))
+
+    post :upload_files, :profile => profile.identifier, :back_to => 'media_listing', :uploaded_files => [fixture_file_upload('files/rails.png', 'image/png')]
+    assert_template nil
+    assert_redirected_to :action => 'media_listing'
+  end
 end
	@@ -59,7 +59,9 @@ class CmsController < MyProfileController		@@ -59,7 +59,9 @@ class CmsController < MyProfileController
59	def edit	59	def edit
60	@article = profile.articles.find(params[:id])	60	@article = profile.articles.find(params[:id])
61	@parent_id = params[:parent_id]	61	@parent_id = params[:parent_id]
62	- @type = params[:type]	62	+ @type = params[:type] \|\| @article.class.to_s
		63	+
		64	+ refuse_blocks
63	if !@article.nil? && @article.blog? \|\| !@type.nil? && @type == 'Blog'	65	if !@article.nil? && @article.blog? \|\| !@type.nil? && @type == 'Blog'
64	@back_url = url_for(:controller => 'profile_editor', :profile => profile.identifier)	66	@back_url = url_for(:controller => 'profile_editor', :profile => profile.identifier)
65	end	67	end
	@@ -77,8 +79,8 @@ class CmsController < MyProfileController		@@ -77,8 +79,8 @@ class CmsController < MyProfileController
77	# FIXME this method should share some logic wirh edit !!!	79	# FIXME this method should share some logic wirh edit !!!
78		80
79	# user must choose an article type first	81	# user must choose an article type first
		82	+
80	@type = params[:type]	83	@type = params[:type]
81	-
82	if @type.blank?	84	if @type.blank?
83	@article_types = []	85	@article_types = []
84	available_article_types.each do \|type\|	86	available_article_types.each do \|type\|
	@@ -95,6 +97,7 @@ class CmsController < MyProfileController		@@ -95,6 +97,7 @@ class CmsController < MyProfileController
95	if @type == 'Blog'	97	if @type == 'Blog'
96	@back_url = url_for(:controller => 'profile_editor', :profile => profile.identifier)	98	@back_url = url_for(:controller => 'profile_editor', :profile => profile.identifier)
97	end	99	end
		100	+ refuse_blocks
98	end	101	end
99		102
100	raise "Invalid article type #{@type}" unless valid_article_type?(@type)	103	raise "Invalid article type #{@type}" unless valid_article_type?(@type)
	@@ -134,14 +137,21 @@ class CmsController < MyProfileController		@@ -134,14 +137,21 @@ class CmsController < MyProfileController
134	@uploaded_files = []	137	@uploaded_files = []
135	@article = @parent = check_parent(params[:parent_id])	138	@article = @parent = check_parent(params[:parent_id])
136	@target = @parent ? ('/%s/%s' % [profile.identifier, @parent.full_name]) : '/%s' % profile.identifier	139	@target = @parent ? ('/%s/%s' % [profile.identifier, @parent.full_name]) : '/%s' % profile.identifier
		140	+ @folders = Folder.find(:all, :conditions => { :profile_id => profile })
137	record_coming_from_public_view if @article	141	record_coming_from_public_view if @article
138	if request.post? && params[:uploaded_files]	142	if request.post? && params[:uploaded_files]
139	params[:uploaded_files].each do \|file\|	143	params[:uploaded_files].each do \|file\|
140	@uploaded_files << UploadedFile.create(:uploaded_data => file, :profile => profile, :parent => @parent) unless file == ''	144	@uploaded_files << UploadedFile.create(:uploaded_data => file, :profile => profile, :parent => @parent) unless file == ''
141	end	145	end
142	@errors = @uploaded_files.select { \|f\| f.errors.any? }	146	@errors = @uploaded_files.select { \|f\| f.errors.any? }
		147	+ @back_to = params[:back_to]
143	if @errors.any?	148	if @errors.any?
144	- render :action => 'upload_files', :parent_id => @parent_id	149	+ if @back_to && @back_to == 'media_listing'
		150	+ flash[:notice] = _('Could not upload all files')
		151	+ redirect_back
		152	+ else
		153	+ render :action => 'upload_files', :parent_id => @parent_id
		154	+ end
145	else	155	else
146	if params[:back_to]	156	if params[:back_to]
147	redirect_back	157	redirect_back
	@@ -199,6 +209,39 @@ class CmsController < MyProfileController		@@ -199,6 +209,39 @@ class CmsController < MyProfileController
199	end	209	end
200	end	210	end
201		211
		212	+ def media_listing
		213	+ if params[:image_folder_id]
		214	+ folder = profile.articles.find(params[:image_folder_id]) if !params[:image_folder_id].blank?
		215	+ @images = (folder ? folder.children : UploadedFile.find(:all, :conditions => ["profile_id = ? AND parent_id is NULL", profile ])).select { \|c\| c.image? }
		216	+ elsif params[:document_folder_id]
		217	+ folder = profile.articles.find(params[:document_folder_id]) if !params[:document_folder_id].blank?
		218	+ @documents = (folder ? folder.children : UploadedFile.find(:all, :conditions => ["profile_id = ? AND parent_id is NULL", profile ])).select { \|c\| c.kind_of?(UploadedFile) && !c.image? }
		219	+ else
		220	+ @documents = UploadedFile.find(:all, :conditions => ["profile_id = ? AND parent_id is NULL", profile ])
		221	+ @images = @documents.select(&:image?)
		222	+ @documents -= @images
		223	+ end
		224	+
		225	+ @images = @images.paginate(:per_page => per_page, :page => params[:ipage]) if @images
		226	+ @documents = @documents.paginate(:per_page => per_page, :page => params[:dpage]) if @documents
		227	+
		228	+ @folders = Folder.find(:all, :conditions => { :profile_id => profile })
		229	+ @image_folders = @folders.select {\|f\| f.children.any? {\|c\| c.image?} }
		230	+ @document_folders = @folders.select {\|f\| f.children.any? {\|c\| !c.image? && c.kind_of?(UploadedFile) } }
		231	+
		232	+ @back_to = 'media_listing'
		233	+
		234	+ respond_to do \|format\|
		235	+ format.html { render :layout => false}
		236	+ format.js {
		237	+ render :update do \|page\|
		238	+ page.replace_html 'media-listing-folder-images', :partial => 'image_thumb', :locals => {:images => @images } if !@images.blank?
		239	+ page.replace_html 'media-listing-folder-documents', :partial => 'document_link', :locals => {:documents => @documents } if !@documents.blank?
		240	+ end
		241	+ }
		242	+ end
		243	+ end
		244	+
202	protected	245	protected
203		246
204	def redirect_back	247	def redirect_back
	@@ -206,6 +249,8 @@ class CmsController < MyProfileController		@@ -206,6 +249,8 @@ class CmsController < MyProfileController
206	redirect_to :controller => 'profile_editor', :profile => @profile.identifier	249	redirect_to :controller => 'profile_editor', :profile => @profile.identifier
207	elsif params[:back_to] == 'public_view'	250	elsif params[:back_to] == 'public_view'
208	redirect_to @article.view_url	251	redirect_to @article.view_url
		252	+ elsif params[:back_to] == 'media_listing'
		253	+ redirect_to :action => 'media_listing'
209	elsif @article.parent	254	elsif @article.parent
210	redirect_to :action => 'view', :id => @article.parent	255	redirect_to :action => 'view', :id => @article.parent
211	else	256	else
	@@ -239,7 +284,7 @@ class CmsController < MyProfileController		@@ -239,7 +284,7 @@ class CmsController < MyProfileController
239	end	284	end
240		285
241	def check_parent(id)	286	def check_parent(id)
242	- if id	287	+ if !id.blank?
243	parent = profile.articles.find(id)	288	parent = profile.articles.find(id)
244	if ! parent.allow_children?	289	if ! parent.allow_children?
245	raise ArgumentError.new("cannot create child of article which does not accept children")	290	raise ArgumentError.new("cannot create child of article which does not accept children")
	@@ -249,5 +294,15 @@ class CmsController < MyProfileController		@@ -249,5 +294,15 @@ class CmsController < MyProfileController
249	nil	294	nil
250	end	295	end
251	end	296	end
		297	+
		298	+ def refuse_blocks
		299	+ if ['TinyMceArticle', 'Event', 'EnterpriseHomepage'].include?(@type)
		300	+ @no_design_blocks = true
		301	+ end
		302	+ end
		303	+
		304	+ def per_page
		305	+ 10
		306	+ end
252	end	307	end
253		308
@@ -0,0 +1,10 @@		@@ -0,0 +1,10 @@
	1	+<div id='media-listing-folder-documents' >
	2	+ <ul>
	3	+ <% documents.each do \|document\| %>
	4	+ <li><%= link_to(image_tag(icon_for_article(document)) + document.name, document.view_url) %></li>
	5	+ <% end %>
	6	+ </ul>
	7	+ <div id='pagination-documents'>
	8	+ <%= pagination_links documents, :param_name => 'dpage', :params => {:document_folder_id => params[:document_folder_id]} %>
	9	+ </div>
	10	+</div>
@@ -0,0 +1,10 @@		@@ -0,0 +1,10 @@
	1	+<div id='media-listing-folder-images' >
	2	+ <ul>
	3	+ <% images.each do \|image\| %>
	4	+ <li><%= image_tag url_for(image.url) %></li>
	5	+ <% end %>
	6	+ </ul>
	7	+ <div id='pagination-images'>
	8	+ <%= pagination_links images, :param_name => 'ipage', :params => {:image_folder_id => params[:image_folder_id]} %>
	9	+ </div>
	10	+</div>
@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
	1	+<iframe id='media-listing-iframe' src="<%= url_for(:controller => 'cms', :action => 'media_listing', :profile => profile.identifier, :type => @type) %>">
	2	+ <p><%= _('Your browser does not support iframes.') %></p>
	3	+</iframe>
	@@ -0,0 +1 @@		@@ -0,0 +1 @@
		1	+<%= select('folder', 'folder_id', @image_folders.collect {\|f\| [ f.name, f.id ] }, {:include_blank => "#{profile.identifier}"}, :onchange => remote_function(:update => 'media-listing-folder-images', :with => "'folder_id=' + value", :url => { :action => :get_images }) ) %>
1	-<p><%= file_field_tag('uploaded_files[]', :size => 50) %></p>	1	+<p><%= file_field_tag('uploaded_files[]', :size => size) %></p>
		2	+<%= javascript_tag("$('uploaded_files').scrollTop = $('uploaded_files').scrollHeight") %>
@@ -0,0 +1,25 @@		@@ -0,0 +1,25 @@
	1	+<% if @parent %>
	2	+ <%= hidden_field_tag('parent_id', @parent.id) %>
	3	+<% else %>
	4	+ <h4><%= _('Choose folder to upload files:') %></h4>
	5	+ <%= select_tag('parent_id', options_for_select([[profile.identifier, '']] + @folders.collect {\|f\| [ f.name, f.id ] })) %>
	6	+<% end %>
	7	+
	8	+<div id='uploaded_files'>
	9	+ <% 3.times do %>
	10	+ <%= render :partial => 'upload_file', :locals => {:size => size} %>
	11	+ <% end %>
	12	+</div>
	13	+
	14	+<%= hidden_field_tag('back_to', @back_to) if @back_to %>
	15	+
	16	+<% button_bar do %>
	17	+ <%= add_upload_file_field(_('More files'), {:size => size}) %>
	18	+ <% if @back_to == 'media_listing' %>
	19	+ <%= submit_button :save, _('Upload') %>
	20	+ <% elsif @back_url %>
	21	+ <%= submit_button :save, _('Upload'), :cancel => @back_url %>
	22	+ <% else %>
	23	+ <%= submit_button :save, _('Upload'), :cancel => {:action => (@parent ? 'view' : 'index'), :id => @parent } %>
	24	+ <% end %>
	25	+<% end %>
@@ -0,0 +1,62 @@		@@ -0,0 +1,62 @@
	1	+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<%= html_language %>" lang="<%= html_language %>">
	2	+<head>
	3	+ <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
	4	+ <%=
	5	+ stylesheet_import( %w( media_listing button ) ) + "\n" +
	6	+ stylesheet_import( %w( media_listing button ), :themed_source => true )
	7	+ %>
	8	+ <%= javascript_include_tag :defaults %>
	9	+ <%= javascript_include_tag 'lowpro' %>
	10	+ <%= stylesheet_link_tag '/designs/icons/default/style.css' %>
	11	+</head>
	12	+<body class='noosfero'>
	13	+ <script type="text/javascript">
	14	+ /* Adds a class to "msie" to the body element if a Microsoft browser is
	15	+ * detected. This is needed to workaround several of their limitations.
	16	+ */
	17	+ if ( navigator.appVersion.indexOf("MSIE") > -1 ) {
	18	+ document.body.className += " msie msie" +
	19	+ navigator.appVersion.replace(/^.MSIE\s+([0-9]+).$/, "$1");
	20	+ }
	21	+ function registerDocumentSize() {
	22	+ document.body.className = document.body.className.replace(/(^\| )docSize.+( \|$)/g, " ");
	23	+ for ( var x=100; x<=1500; x+=100 ) {
	24	+ if ( document.body.clientWidth > x ) {
	25	+ document.body.className += " docSize-GT-" + x;
	26	+ } else {
	27	+ document.body.className += " docSize-LT-" + x;
	28	+ }
	29	+ }
	30	+ }
	31	+ registerDocumentSize();
	32	+ </script>
	33	+ <div id='media-listing'>
	34	+ <div id='media-listing-images'>
	35	+ <h3><%= _('Images') %></h3>
	36	+ <%= select_folder('folder', 'image_folder_id', @image_folders, {}, :onchange => remote_function(:with => "'image_folder_id=' + value + '&ipage=1'", :url => { :action => :media_listing, :format => 'js' }) ) %>
	37	+ <%= render :partial => 'image_thumb', :locals => { :images => @images } %>
	38	+ </div><!-- id='media-listing-images' -->
	39	+ <div id='media-listing-documents'>
	40	+ <h3><%= _('Documents') %></h3>
	41	+ <%= select_folder('folder', 'document_folder_id', @document_folders, {}, :onchange => remote_function(:with => "'document_folder_id=' + value + '&dpage=1'", :url => { :action => :media_listing }) ) %>
	42	+ <%= render :partial => 'document_link', :locals => { :documents => @documents } %>
	43	+ </div><!-- id='media-listing-documents' -->
	44	+ <br style="clear:both" />
	45	+ <p><%= _('If you want to add images or links to files in your article, click on the file you want, drag it to the text area and drop the file.') %></p>
	46	+ <br style="clear:both" />
	47	+ </div><!-- id='media-listing' -->
	48	+ <div id='media-listing-upload'>
	49	+ <div id="notice" onclick="Element.hide('notice');" style="display:none">
	50	+ <% unless flash[:notice].nil? %>
	51	+ <%= flash[:notice] unless flash[:notice].nil? %>
	52	+ <%= javascript_tag(visual_effect( :appear, 'notice')) %>
	53	+ <% end %>
	54	+ </div>
	55	+
	56	+ <% form_for('uploaded_file', :url => {:action => 'upload_files'}, :html => {:multipart => true}) do \|f\| %>
	57	+ <%= hidden_field_tag('back_to', @back_to) %>
	58	+ <%= render :partial => 'upload_file_form', :locals => { :size => '30' } %>
	59	+ <% end %>
	60	+ </div><!-- id='media-listing-upload' -->
	61	+</body>
	62	+</html>
	@@ -20,24 +20,5 @@		@@ -20,24 +20,5 @@
20	<h5><%= _('Uploading files to %s') % content_tag('code', @target) %></h5>	20	<h5><%= _('Uploading files to %s') % content_tag('code', @target) %></h5>
21		21
22	<% form_for('uploaded_file', :url => { :action => 'upload_files' }, :html => {:multipart => true}) do \|f\| %>	22	<% form_for('uploaded_file', :url => { :action => 'upload_files' }, :html => {:multipart => true}) do \|f\| %>
23	-
24	- <div id='uploaded_files'>
25	- <% 3.times do %>
26	- <%= render :partial => 'upload_file' %>
27	- <% end %>
28	- </div>
29	-
30	- <%= hidden_field_tag('parent_id', @parent.id) if @parent %>
31	-
32	- <%= hidden_field_tag('back_to', @back_to) if @back_to %>
33	-
34	- <% button_bar do %>
35	- <%= add_upload_file_field _('More files') %>
36	- <% if @back_url %>
37	- <%= submit_button :save, _('Upload'), :cancel => @back_url %>
38	- <% else %>
39	- <%= submit_button :save, _('Upload'), :cancel => {:action => (@parent ? 'view' : 'index'), :id => @parent } %>
40	- <% end %>
41	- <% end %>
42	-	23	+ <%= render :partial => 'upload_file_form', :locals => { :size => '50'} %>
43	<% end %>	24	<% end %>
	@@ -41,3 +41,11 @@ function convToValidLogin( str ) {		@@ -41,3 +41,11 @@ function convToValidLogin( str ) {
41	.replace( /[^-_a-z0-9]+/g, "" )	41	.replace( /[^-_a-z0-9]+/g, "" )
42	}	42	}
43		43
		44	+document.observe("dom:loaded", function() {
		45	+ Event.addBehavior.reassignAfterAjax = true;
		46	+ Event.addBehavior({
		47	+ 'div#pagination-images .pagination a' : Remote.Link,
		48	+ 'div#pagination-documents .pagination a' : Remote.Link
		49	+ })
		50	+});
		51	+