ActionItem990: Added pagination and cache to friends

Daniela Feitosa · Antonio Terceiro
1 parent 27667670
Showing 7 changed files with 53 additions and 4 deletions Show diff stats
app/controllers/public/profile_controller.rb
app/helpers/profile_helper.rb
app/models/person.rb
app/models/profile.rb
app/views/profile/friends.rhtml
config/environment.rb
public/stylesheets/controller_profile.css
@@ -28,7 +28,9 @@ class ProfileController &lt; PublicController
   end
   def friends
-    @friends= profile.friends
+    if is_cache_expired?(profile.friends_cache_key(params))
+      @friends = profile.friends.paginate(:per_page => per_page, :page => params[:npage])
+    end
   end
   def members
@@ -82,4 +84,7 @@ class ProfileController &lt; PublicController
     end
   end
+  def per_page
+    10
+  end
 end
@@ -12,4 +12,9 @@ module ProfileHelper
     end
   end
+  def pagination_links(collection, options={})
+    options = {:prev_label => '&laquo; ' + _('Previous'), :next_label => _('Next') + ' &raquo;'}.merge(options)
+    will_paginate(collection, options)
+  end
+
 end
@@ -38,7 +38,7 @@ class Person &lt; Profile
   end
   def remove_friend(friend)
-    friends.delete(friend)
+    Friendship.find(:first, :conditions => {:friend_id => friend, :person_id => id}).destroy
   end
   FIELDS = %w[
@@ -238,4 +238,26 @@ class Person &lt; Profile
     refused_communities << community
   end
+  def blocks_to_expire_cache
+    [CommunitiesBlock]
+  end
+
+  def cache_keys(params = {})
+    [communities_cache_key]
+  end
+
+  def communities_cache_key(params = {})
+    page = params[:npage] || '1'
+    identifier + '-communities-page-' + page
+  end
+
+  def friends_cache_key(params = {})
+    page = params[:npage] || '1'
+    identifier + '-friends-page-' + page
+  end
+
+  def manage_friends_cache_key(params = {})
+    page = params[:npage] || '1'
+    identifier + '-manage-friends-page-' + page
+  end
 end
@@ -606,4 +606,12 @@ class Profile &lt; ActiveRecord::Base
     self.articles.find(:all, :conditions => ['type in (?)', ['Folder', 'Blog']])
   end
+  def blocks_to_expire_cache
+    []
+  end
+
+  def cache_keys(params = {})
+    []
+  end
+
 end
@@ -3,12 +3,16 @@
 <h1><%= __("%s's friends") % profile.name %></h1>
-<% cache do%>
+<% cache_timeout(profile.friends_cache_key(params), 4.hours.from_now) do %>
 <ul class='profile-list'>
   <% @friends.each do |friend| %>
     <%= profile_image_link(friend) %>
   <% end%>
 </ul>
+
+  <div id='pagination-profiles'>
+    <%= pagination_links @friends, :param_name => 'npage' %>
+  </div>
 <% end %>
 <% button_bar do %>
@@ -67,7 +67,7 @@ Rails::Initializer.run do |config|
   # don't load the sweepers while loading the database
   unless $PROGRAM_NAME =~ /rake$/ && ARGV.first == 'db:schema:load'
-    config.active_record.observers = :article_sweeper
+    config.active_record.observers = :article_sweeper, :role_assignment_sweeper, :friendship_sweeper
   end
   # Make Active Record use UTC-base instead of local time
   # config.active_record.default_timezone = :utc
 @import url(profile-list-block.css);
+@import url(pagination.css);
 .button-bar {
   padding-top: 40px;
   clear: both;
 }
+
+#pagination-profiles .pagination span {
+  display: inline;
+}
	@@ -12,4 +12,9 @@ module ProfileHelper		@@ -12,4 +12,9 @@ module ProfileHelper
12	end	12	end
13	end	13	end
14		14
		15	+ def pagination_links(collection, options={})
		16	+ options = {:prev_label => '« ' + _('Previous'), :next_label => _('Next') + ' »'}.merge(options)
		17	+ will_paginate(collection, options)
		18	+ end
		19	+
15	end	20	end
	@@ -38,7 +38,7 @@ class Person < Profile		@@ -38,7 +38,7 @@ class Person < Profile
38	end	38	end
39		39
40	def remove_friend(friend)	40	def remove_friend(friend)
41	- friends.delete(friend)	41	+ Friendship.find(:first, :conditions => {:friend_id => friend, :person_id => id}).destroy
42	end	42	end
43		43
44	FIELDS = %w[	44	FIELDS = %w[
	@@ -238,4 +238,26 @@ class Person < Profile		@@ -238,4 +238,26 @@ class Person < Profile
238	refused_communities << community	238	refused_communities << community
239	end	239	end
240		240
		241	+ def blocks_to_expire_cache
		242	+ [CommunitiesBlock]
		243	+ end
		244	+
		245	+ def cache_keys(params = {})
		246	+ [communities_cache_key]
		247	+ end
		248	+
		249	+ def communities_cache_key(params = {})
		250	+ page = params[:npage] \|\| '1'
		251	+ identifier + '-communities-page-' + page
		252	+ end
		253	+
		254	+ def friends_cache_key(params = {})
		255	+ page = params[:npage] \|\| '1'
		256	+ identifier + '-friends-page-' + page
		257	+ end
		258	+
		259	+ def manage_friends_cache_key(params = {})
		260	+ page = params[:npage] \|\| '1'
		261	+ identifier + '-manage-friends-page-' + page
		262	+ end
241	end	263	end
	@@ -606,4 +606,12 @@ class Profile < ActiveRecord::Base		@@ -606,4 +606,12 @@ class Profile < ActiveRecord::Base
606	self.articles.find(:all, :conditions => ['type in (?)', ['Folder', 'Blog']])	606	self.articles.find(:all, :conditions => ['type in (?)', ['Folder', 'Blog']])
607	end	607	end
608		608
		609	+ def blocks_to_expire_cache
		610	+ []
		611	+ end
		612	+
		613	+ def cache_keys(params = {})
		614	+ []
		615	+ end
		616	+
609	end	617	end
	@@ -67,7 +67,7 @@ Rails::Initializer.run do \|config\|		@@ -67,7 +67,7 @@ Rails::Initializer.run do \|config\|
67		67
68	# don't load the sweepers while loading the database	68	# don't load the sweepers while loading the database
69	unless $PROGRAM_NAME =~ /rake$/ && ARGV.first == 'db:schema:load'	69	unless $PROGRAM_NAME =~ /rake$/ && ARGV.first == 'db:schema:load'
70	- config.active_record.observers = :article_sweeper	70	+ config.active_record.observers = :article_sweeper, :role_assignment_sweeper, :friendship_sweeper
71	end	71	end
72	# Make Active Record use UTC-base instead of local time	72	# Make Active Record use UTC-base instead of local time
73	# config.active_record.default_timezone = :utc	73	# config.active_record.default_timezone = :utc