ActionItem158: a better CMS

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1790 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem158: a better CMS
git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1790 3f533792-8f58-4932-b0fe-aaf55b0a4547
AntonioTerceiro
1 parent 7707a13c
Showing 8 changed files with 170 additions and 63 deletions Show diff stats
app/controllers/my_profile/cms_controller.rb
app/models/article.rb
app/models/folder.rb
app/views/cms/edit.rhtml
app/views/cms/view.rhtml
test/functional/cms_controller_test.rb
test/unit/article_test.rb
test/unit/folder_test.rb
@@ -19,12 +19,14 @@ class CmsController &lt; MyProfileController
   def view
     @article = profile.articles.find(params[:id])
-    @subitems = @article.children
+    @subitems = @article.children.reject {|item| item.folder? }
+    @folders = @article.children.select {|item| item.folder? }
   end
   def index
     @article = nil
-    @subitems = profile.top_level_articles
+    @subitems = profile.top_level_articles.reject {|item| item.folder? }
+    @folders = profile.top_level_articles.select {|item| item.folder?}
     render :action => 'view'
   end
@@ -35,7 +37,7 @@ class CmsController &lt; MyProfileController
     if request.post?
       @article.last_changed_by = user
       if @article.update_attributes(params[:article])
-        redirect_to :action => 'view', :id => @article.id
+        redirect_back
         return
       end
     end
@@ -78,7 +80,7 @@ class CmsController &lt; MyProfileController
     @article.last_changed_by = user
     if request.post?
       if @article.save
-        redirect_to :action => 'view', :id => @article.id
+        redirect_back
         return
       end
     end
@@ -102,5 +104,15 @@ class CmsController &lt; MyProfileController
     redirect_to :action => (@article.parent ? 'view' : 'index'), :id => @article.parent
   end
+  protected
+
+  def redirect_back
+    if @article.parent
+      redirect_to :action => 'view', :id => @article.parent
+    else
+      redirect_to :action => 'index'
+    end
+  end
+
 end
@@ -112,6 +112,10 @@ class Article &lt; ActiveRecord::Base
     true
   end
+  def folder?
+    false
+  end
+
   def self.find_by_initial(initial)
     self.find(:all, :order => 'articles.name', :conditions => [ 'articles.name like (?) or articles.name like (?)', initial + '%', initial.upcase + '%'])
   end
@@ -20,4 +20,8 @@ class Folder &lt; Article
     content_tag('ul', children.map { |child| content_tag('li', link_to(child.name, child.url)) }, :class => 'folder-listing')
   end
+  def folder?
+    true
+  end
+
 end
@@ -16,6 +16,11 @@
   %>
   <% button_bar do %>
-    <%= submit_button('save', _('Save'), :cancel => (@article.parent ? { :action => 'view', :id => @article.parent.id } : { :action => 'index' } )) %>
+    <%= submit_button :save, _('Save') %>
+    <% if @parent_id || @article.parent %>
+      <%= button :cancel, _('Cancel'), :action => 'view', :id => @parent_id || @article.parent %>
+    <% else %>
+      <%= button :cancel, _('Cancel'), :action => 'index' %>
+    <% end %>
   <% end %>
 <% end %>
@@ -9,68 +9,59 @@
     <%= icon('cms') %>
     <%= _('Content management') %>
   </h2>
-
-  <% button_bar(:style => 'margin-bottom: 1em;') do %>
-    <%= lightbox_button('new', _('New article'), :action => 'new') %>
-  <% end %>
-
 <% end %>
-<%# subitem %>
-<% if !@subitems.empty? && @article %>
-  <%= toggle_panel(_('Hide subitems'), _('Show subitems'), 'article-subitems') %>
+<% button_bar(:style => 'margin-bottom: 1em;') do %>
+  <% parent_id = ((@article && @article.allow_children?) ? @article : nil) %>
+  <%= button :add, _('New folder'), :action => 'new', :type => 'Folder', :parent_id => parent_id %>
+  <%= lightbox_button('new', _('New article'), :action => 'new', :parent_id => parent_id) %>
 <% end %>
-  
-<div id='article-subitems'>
-  <div class='file-manager-title'><%= @article ? _('Subitems') : _('Articles') %></div>
-  <div class='file-manager-small'>
-    <% unless @subitems.empty? %>
-      <ul>
-        <% @subitems.each do |item| %>
-          <li>
-          <%= file_manager_button(item.name, icon_for_article(item), :action => 'view', :id => item.id) %>
-          </li>
-        <% end %>
-      </ul>
-    <% end %>
-    <% if @article %>
-      <% button_bar(:class => 'file-manager-controls') do %>
-        <% if @article.allow_children? %>
-          <%= lightbox_button('new',  _('New subitem'), :action => 'new', :parent_id => @article.id) %>
-        <% end %>
-        <%= button('up', _('Go up one level'), :action => (@article.parent ? 'view' : 'index'), :id => @article.parent) %>
-      <% end %>
-    <% end %>
-  </div>
-</div> <!-- article-children -->
+<table width='100%'>
-<%# display the article content %>
-<div id='article-contents' style='clear: left;'>
-  <% if @article %>
-    <h2>
-      <%= @article.name %>
-      <%= image_tag(icon_for_article(@article)) %>
-    </h2>
-    <% button_bar(:id => 'article-controls') do %>
-
-      <ul>
-        <li>
-        <%= _('"%{article}", last changed by %{author}') % { :article => @article.name, :author => (@article.last_changed_by ? @article.last_changed_by.name : _('Unknown User')) } %>
-        </li>
-        <li>
-        <%= _('Public address of this article: %s') % link_to(url_for(@article.url), @article.url) %>
-        </li>
-        <li>
-        <%= _('Tags:') %> <%= @article.tag_list %>
-        </li>
-        <%= _('Categories:') %> <%= @article.categories.map { |item| item.name }.join(', ') %>
-      </ul>
+  <%# folders %>
+  <tr>
+    <th colspan='2'>
+      <%= _('Folders') %>
+    </th>
+  </tr>
+  <% if @folders.empty? %>
+    <tr><td colspan='2' align='center'><em><%= _('None') %></em></td></tr>
+  <% end %>
+  <% for folder in @folders %>
+    <tr>
+      <td>
+        <%= image_tag(icon_for_article(folder)) %>
+        <%= link_to folder.name, :action => 'view', :id => folder.id %>
+      </td>
+      <td>
+        <%= link_to _('Properties'), :action => 'edit', :id => folder.id %>
+        <%= link_to _('View'), folder.url %>
+      </td>
+    </tr>
+  <% end %>
-      <%= button('edit', _('Edit'), { :action => 'edit', :id => @article}) %>
-      <%= button('home', _('Use as homepage'), { :action => 'set_home_page', :id => @article }, { :method => :post  }) %>
-      <%= button('delete', _('Delete'), { :action => 'destroy', :id => @article }, :method => :post, :confirm => _('Are you sure you wan to remove this article?')) %>
-    <% end %>
-    <%= @article.to_html %>
+  <%# non-folder subitems %>
+  <tr>
+    <th colspan='2'>
+      <%= _('Articles') %>
+    </th>
+  </tr>
+  <% if @subitems.empty? %>
+    <tr><td colspan='2' align='center'><em><%= _('None') %></em></td></tr>
+  <% end %>
+  <% for item in @subitems %>
+    <tr>
+      <td>
+        <%= image_tag(icon_for_article(item)) %>
+        <%= link_to item.name, :id => item.id %>
+      </td>
+      <td>
+        <%= link_to _('Edit'), :action => 'edit', :id => item.id %>
+        <%= link_to _('View'), item.url %>
+      </td>
+    </tr>
   <% end %>
-</div>
+
+
+</table>
@@ -313,6 +313,89 @@ class CmsControllerTest &lt; Test::Unit::TestCase
     assert_tag :tag => 'input', :attributes => { :name => 'parent_id', :value => profile.home_page.id }
   end
+  should 'list folders at top level' do
+    f1 = Folder.new(:name => 'f1'); profile.articles << f1;  f1.save!
+    f2 = Folder.new(:name => 'f2'); profile.articles << f2;  f2.save!
+    get :index, :profile => profile.identifier
+    assert_equal [f1, f2], assigns(:folders)
+    assert_not_includes assigns(:subitems), f1
+    assert_not_includes assigns(:subitems), f2
+  end
+
+  should 'list folders inside another folder' do
+    parent = Folder.new(:name => 'parent'); profile.articles << parent;  parent.save!
+    f1 = Folder.new(:name => 'f1', :parent => parent); profile.articles << f1;  f1.save!
+    f2 = Folder.new(:name => 'f2', :parent => parent); profile.articles << f2;  f2.save!
+
+    get :view, :profile => profile.identifier, :id => parent.id
+    assert_equal [f1, f2], assigns(:folders)
+    assert_not_includes assigns(:subitems), f1
+    assert_not_includes assigns(:subitems), f2
+  end
+
+  should 'offer to create new top-level folder' do
+    get :index, :profile => profile.identifier
+    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/new?type=Folder"}
+  end
+
+  should 'offer to create sub-folder' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    get :view, :profile => profile.identifier, :id => f.id
+
+    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/new?parent_id=#{f.id}&amp;type=Folder" }
+  end
+
+  should 'redirect back to index after creating top-level article' do
+    post :new, :profile => profile.identifier, :type => 'TextileArticle', :article => { :name => 'test' }
+    assert_redirected_to :action => 'index'
+  end
+
+  should 'redirect back to folder after creating article inside it' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    post :new, :profile => profile.identifier, :type => 'TextileArticle', :parent_id => f.id, :article => { :name => 'test' }
+    assert_redirected_to :action => 'view', :id => f.id
+  end
+
+  should 'redirect back to index after editing top-level article' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    post :edit, :profile => profile.identifier, :id => f.id
+    assert_redirected_to :action => 'index'
+  end
+
+  should 'redirect back to folder after editing article inside it' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    a = TextileArticle.create!(:parent => f, :name => 'test', :profile_id => profile.id)
+
+    post :edit, :profile => profile.identifier, :id => a.id
+    assert_redirected_to :action => 'view', :id => f.id
+  end
+
+  should 'point back to index when cancelling creation of top-level article' do
+    get :new, :profile => profile.identifier, :type => 'Folder'
+    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms" }, :descendant => { :content => /Cancel/ }
+  end
+
+  should 'point back to index when cancelling edition of top-level article' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    get :edit, :profile => profile.identifier, :id => f.id
+
+    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms" }, :descendant => { :content => /Cancel/ }
+  end
+
+  should 'point back to folder when cancelling creation of an article inside it' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    get :new, :profile => profile.identifier, :type => 'Folder', :parent_id => f.id
+
+    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/view/#{f.id}" }, :descendant => { :content => /Cancel/ }
+  end
+
+  should 'point back to folder when cancelling edition of an article inside it' do
+    f = Folder.new(:name => 'f'); profile.articles << f; f.save!
+    a = TextileArticle.create!(:name => 'test', :parent => f, :profile_id => profile.id)
+    get :edit, :profile => profile.identifier, :id => a.id
+
+    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/view/#{f.id}" }, :descendant => { :content => /Cancel/ }
+  end
 end
@@ -229,4 +229,8 @@ class ArticleTest &lt; Test::Unit::TestCase
     assert_not_includes list, a2
   end
+  should 'identify itself as a non-folder' do
+    assert !Article.new.folder?, 'should identify itself as non-folder'
+  end
+
 end
@@ -30,4 +30,8 @@ class FolderTest &lt; ActiveSupport::TestCase
     assert_match(/<li><a href=".*\/testuser\/f\/otherarticle">otherarticle<\/a><\/li>/, f.to_html)
   end
+  should 'identify as folder' do
+    assert Folder.new.folder?, 'folder must identity itself as folder'
+  end
+
 end
	@@ -20,4 +20,8 @@ class Folder < Article		@@ -20,4 +20,8 @@ class Folder < Article
20	content_tag('ul', children.map { \|child\| content_tag('li', link_to(child.name, child.url)) }, :class => 'folder-listing')	20	content_tag('ul', children.map { \|child\| content_tag('li', link_to(child.name, child.url)) }, :class => 'folder-listing')
21	end	21	end
22		22
		23	+ def folder?
		24	+ true
		25	+ end
		26	+
23	end	27	end
	@@ -313,6 +313,89 @@ class CmsControllerTest < Test::Unit::TestCase		@@ -313,6 +313,89 @@ class CmsControllerTest < Test::Unit::TestCase
313	assert_tag :tag => 'input', :attributes => { :name => 'parent_id', :value => profile.home_page.id }	313	assert_tag :tag => 'input', :attributes => { :name => 'parent_id', :value => profile.home_page.id }
314	end	314	end
315		315
		316	+ should 'list folders at top level' do
		317	+ f1 = Folder.new(:name => 'f1'); profile.articles << f1; f1.save!
		318	+ f2 = Folder.new(:name => 'f2'); profile.articles << f2; f2.save!
316		319
		320	+ get :index, :profile => profile.identifier
		321	+ assert_equal [f1, f2], assigns(:folders)
		322	+ assert_not_includes assigns(:subitems), f1
		323	+ assert_not_includes assigns(:subitems), f2
		324	+ end
		325	+
		326	+ should 'list folders inside another folder' do
		327	+ parent = Folder.new(:name => 'parent'); profile.articles << parent; parent.save!
		328	+ f1 = Folder.new(:name => 'f1', :parent => parent); profile.articles << f1; f1.save!
		329	+ f2 = Folder.new(:name => 'f2', :parent => parent); profile.articles << f2; f2.save!
		330	+
		331	+ get :view, :profile => profile.identifier, :id => parent.id
		332	+ assert_equal [f1, f2], assigns(:folders)
		333	+ assert_not_includes assigns(:subitems), f1
		334	+ assert_not_includes assigns(:subitems), f2
		335	+ end
		336	+
		337	+ should 'offer to create new top-level folder' do
		338	+ get :index, :profile => profile.identifier
		339	+ assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/new?type=Folder"}
		340	+ end
		341	+
		342	+ should 'offer to create sub-folder' do
		343	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		344	+ get :view, :profile => profile.identifier, :id => f.id
		345	+
		346	+ assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/new?parent_id=#{f.id}&type=Folder" }
		347	+ end
		348	+
		349	+ should 'redirect back to index after creating top-level article' do
		350	+ post :new, :profile => profile.identifier, :type => 'TextileArticle', :article => { :name => 'test' }
		351	+ assert_redirected_to :action => 'index'
		352	+ end
		353	+
		354	+ should 'redirect back to folder after creating article inside it' do
		355	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		356	+ post :new, :profile => profile.identifier, :type => 'TextileArticle', :parent_id => f.id, :article => { :name => 'test' }
		357	+ assert_redirected_to :action => 'view', :id => f.id
		358	+ end
		359	+
		360	+ should 'redirect back to index after editing top-level article' do
		361	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		362	+ post :edit, :profile => profile.identifier, :id => f.id
		363	+ assert_redirected_to :action => 'index'
		364	+ end
		365	+
		366	+ should 'redirect back to folder after editing article inside it' do
		367	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		368	+ a = TextileArticle.create!(:parent => f, :name => 'test', :profile_id => profile.id)
		369	+
		370	+ post :edit, :profile => profile.identifier, :id => a.id
		371	+ assert_redirected_to :action => 'view', :id => f.id
		372	+ end
		373	+
		374	+ should 'point back to index when cancelling creation of top-level article' do
		375	+ get :new, :profile => profile.identifier, :type => 'Folder'
		376	+ assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms" }, :descendant => { :content => /Cancel/ }
		377	+ end
		378	+
		379	+ should 'point back to index when cancelling edition of top-level article' do
		380	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		381	+ get :edit, :profile => profile.identifier, :id => f.id
		382	+
		383	+ assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms" }, :descendant => { :content => /Cancel/ }
		384	+ end
		385	+
		386	+ should 'point back to folder when cancelling creation of an article inside it' do
		387	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		388	+ get :new, :profile => profile.identifier, :type => 'Folder', :parent_id => f.id
		389	+
		390	+ assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/view/#{f.id}" }, :descendant => { :content => /Cancel/ }
		391	+ end
		392	+
		393	+ should 'point back to folder when cancelling edition of an article inside it' do
		394	+ f = Folder.new(:name => 'f'); profile.articles << f; f.save!
		395	+ a = TextileArticle.create!(:name => 'test', :parent => f, :profile_id => profile.id)
		396	+ get :edit, :profile => profile.identifier, :id => a.id
		397	+
		398	+ assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/view/#{f.id}" }, :descendant => { :content => /Cancel/ }
		399	+ end
317		400
318	end	401	end
	@@ -229,4 +229,8 @@ class ArticleTest < Test::Unit::TestCase		@@ -229,4 +229,8 @@ class ArticleTest < Test::Unit::TestCase
229	assert_not_includes list, a2	229	assert_not_includes list, a2
230	end	230	end
231		231
		232	+ should 'identify itself as a non-folder' do
		233	+ assert !Article.new.folder?, 'should identify itself as non-folder'
		234	+ end
		235	+
232	end	236	end
	@@ -30,4 +30,8 @@ class FolderTest < ActiveSupport::TestCase		@@ -30,4 +30,8 @@ class FolderTest < ActiveSupport::TestCase
30	assert_match(/<li><a href=".*\/testuser\/f\/otherarticle">otherarticle<\/a><\/li>/, f.to_html)	30	assert_match(/<li><a href=".*\/testuser\/f\/otherarticle">otherarticle<\/a><\/li>/, f.to_html)
31	end	31	end
32		32
		33	+ should 'identify as folder' do
		34	+ assert Folder.new.folder?, 'folder must identity itself as folder'
		35	+ end
		36	+
33	end	37	end