Refactor software_communities.

Signed-off-by: Thiago Ribeiro <thiagitosouza@gmail.com> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> Signed-off-by: Luciano Prestes <lucianopcbr@gmail.com> (cherry picked from commit 0d4a8d9838dadcbf6b54fb058fc04c6be71ee4f7) (cherry picked from commit dfd6263e9d63b98d7199991458492789aeaa4c79)

Refactor software_communities.
Signed-off-by: Thiago Ribeiro <thiagitosouza@gmail.com> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> Signed-off-by: Luciano Prestes <lucianopcbr@gmail.com> (cherry picked from commit 0d4a8d9838dadcbf6b54fb058fc04c6be71ee4f7) (cherry picked from commit dfd6263e9d63b98d7199991458492789aeaa4c79)
Luciano Prestes · Thiago Ribeiro
1 parent 557e1fd1
Showing 16 changed files with 167 additions and 130 deletions Show diff stats
src/noosfero-spb/software_communities/controllers/software_communities_plugin_controller.rb
src/noosfero-spb/software_communities/controllers/software_communities_plugin_myprofile_controller.rb
src/noosfero-spb/software_communities/lib/create_software.rb
src/noosfero-spb/software_communities/lib/database_helper.rb
src/noosfero-spb/software_communities/lib/library_helper.rb
src/noosfero-spb/software_communities/lib/license_helper.rb
src/noosfero-spb/software_communities/lib/operating_system_helper.rb
src/noosfero-spb/software_communities/lib/software_communities_plugin.rb
src/noosfero-spb/software_communities/lib/software_helper.rb
src/noosfero-spb/software_communities/lib/software_info.rb
src/noosfero-spb/software_communities/lib/software_language_helper.rb
src/noosfero-spb/software_communities/test/functional/software_communities_plugin_myprofile_controller_test.rb
src/noosfero-spb/software_communities/test/unit/software_info_validation_test.rb
src/noosfero-spb/software_communities/views/_main_software_editor_extras.html.erb
src/noosfero-spb/software_communities/views/software_communities_plugin_myprofile/_license_info_fields.html.erb
src/noosfero-spb/software_communities/views/software_communities_plugin_myprofile/_main_software_editor_extras.html.erb
@@ -5,11 +5,9 @@ class SoftwareCommunitiesPluginController &lt; ApplicationController
   def get_license_data
     return render :json=>{} if !request.xhr? || params[:query].nil?
-    data = if params[:query].empty?
-             LicenseInfo.all
-           else
-             LicenseInfo.where("version ILIKE ?", "%#{params[:query]}%").select("id, version")
-           end
+    data = LicenseHelper.find_licenses(params[:query]) if params[:query]
+    data ||= LicenseInfo.all
+
     render :json=> data.collect { |license|
       {:id=>license.id, :label=>license.version}
     }
@@ -44,11 +42,7 @@ class SoftwareCommunitiesPluginController &lt; ApplicationController
   protected
   def get_model_by_params_field
-    case params[:field]
-    when "software_language"
-      return ProgrammingLanguage
-    else
-      return DatabaseDescription
-    end
+    return DatabaseDescription unless params[:field] == "software_language"
+    return ProgrammingLanguage
   end
 end
@@ -9,13 +9,13 @@ class SoftwareCommunitiesPluginMyprofileController &lt; MyProfileController
     @community = Community.new(params[:community])
     @community.environment = environment
-    @software_info = SoftwareInfo.new(params[:software_info])
-    @license_info = if params[:license].blank? or params[:license][:license_infos_id].blank?
-      LicenseInfo.new
-    else
-      LicenseInfo.find(params[:license][:license_infos_id])
-    end
+    @license_info = LicenseInfo.find_by_id(params[:license][:license_infos_id]) if params[:license]
+    @license_info ||= LicenseInfo.new
+
+    @software_info = SoftwareInfo.new(params[:software_info])
+    @software_info.community = @community
+    @software_info.license_info = @license_info
     control_software_creation
     update_new_software_errors
@@ -26,7 +26,7 @@ class SoftwareCommunitiesPluginMyprofileController &lt; MyProfileController
     return unless request.post?
-    @software_info = constroy_software
+    @software_info = create_software
     software_info_insert_models.call(@list_libraries, 'libraries')
     software_info_insert_models.call(@list_languages, 'software_languages')
     software_info_insert_models.call(@list_databases, 'software_databases')
@@ -70,17 +70,25 @@ class SoftwareCommunitiesPluginMyprofileController &lt; MyProfileController
   def add_software_erros
       @errors = []
-      @errors |= @community.errors.full_messages if @community
+      if @community
+        error = @community.errors.delete(:identifier)
+        @errors |= [_("Domain %s") % error.first ] if error
+        @errors |= @community.errors.full_messages
+      end
       @errors |= @software_info.errors.full_messages if @software_info
       @errors |= @license_info.errors.full_messages if @license_info
   end
   def control_software_creation
-    valid_models = request.post? && (@community.valid? && @software_info.valid? && @license_info.valid?)
-    if valid_models
-      send_software_to_moderation
-    else
-      add_software_erros
+    if request.post?
+      valid_models = @community.valid?
+      valid_models &= @software_info.valid?
+      valid_models &= @license_info.valid?
+      if valid_models
+        send_software_to_moderation
+      else
+        add_software_erros
+      end
     end
   end
@@ -91,7 +99,7 @@ class SoftwareCommunitiesPluginMyprofileController &lt; MyProfileController
     }
   end
-  def constroy_software
+  def create_software
     @software_info = @profile.software_info
     another_license_version = nil
     another_license_link = nil
@@ -136,7 +144,7 @@ class SoftwareCommunitiesPluginMyprofileController &lt; MyProfileController
     add_admin_to_community
-    if  !environment.admins.include?(current_user.person)
+    if !environment.admins.include?(current_user.person)
       session[:notice] = _('Your new software request will be evaluated by an'\
                            'administrator. You will be notified.')
       redirect_to user.admin_url
@@ -5,12 +5,14 @@ class CreateSoftware &lt; Task
   validates_presence_of :name
   attr_accessible :name, :finality, :repository_link, :requestor, :environment,
-                  :reject_explanation, :license_info
+                  :reject_explanation, :license_info, :identifier, :another_license_version,
+                  :another_license_link
   alias :environment :target
   alias :environment= :target=
-  DATA_FIELDS = ['name', 'finality', 'license_info', 'repository_link']
+  DATA_FIELDS = ['name', 'identifier', 'finality', 'license_info', 'repository_link',
+                 'another_license_version', 'another_license_link']
   DATA_FIELDS.each do |field|
     settings_items field.to_sym
   end
@@ -21,15 +23,21 @@ class CreateSoftware &lt; Task
       template_id = software_template.id
     end
+    identifier = self.identifier
+    identifier ||= self.name.to_slug
+
     community = Community.create!(:name => self.name,
+                                  :identifier => identifier,
                                   :template_id => template_id)
     community.environment = self.environment
     community.add_admin(self.requestor)
-    software = SoftwareInfo.create!(:finality => self.finality,
+    software = SoftwareInfo.new(:finality => self.finality,
     :repository_link => self.repository_link, :community_id => community.id,
     :license_info => self.license_info)
+    software.verify_license_info(self.another_license_version, self.another_license_link)
+    software.save!
   end
   def title
@@ -34,12 +34,7 @@ class DatabaseHelper &lt; DynamicTableHelper
   def self.valid_list_database? list_databases
     return false if list_databases.nil? or list_databases.length == 0
-
-    list_databases.each do |database|
-      return false unless database.valid?
-    end
-
-    true
+    return !list_databases.any?{|database| !database.valid?}
   end
   def self.database_as_tables(list_databases, disabled=false)
@@ -51,14 +46,10 @@ class DatabaseHelper &lt; DynamicTableHelper
   def self.database_html_structure(database_data, disabled)
     database_id = database_data[:database_description_id]
-    database_name = if database_data[:database_description_id].blank?
-      ""
-    else
-      DatabaseDescription.find(
+    database_name = database_id.blank? ? "" : DatabaseDescription.find(
         database_data[:database_description_id],
         :select=>"name"
       ).name
-    end
     data = {
       model_name: MODEL_NAME,
@@ -83,4 +74,4 @@ class DatabaseHelper &lt; DynamicTableHelper
   def self.add_dynamic_table
     database_as_tables(nil).first.call
   end
-end
 \ No newline at end of file
+end
@@ -20,12 +20,7 @@ class LibraryHelper &lt; DynamicTableHelper
   def self.valid_list_library? list_libraries
     return true if list_libraries.nil? or list_libraries.length == 0
-
-    list_libraries.each do |library|
-      return false unless library.valid?
-    end
-
-    true
+    return !list_libraries.any?{|library| !library.valid?}
   end
   def self.libraries_as_tables list_libraries, disabled=false
@@ -59,4 +54,4 @@ class LibraryHelper &lt; DynamicTableHelper
   def self.add_dynamic_table
     libraries_as_tables(nil).first.call
   end
-end
 \ No newline at end of file
+end
 module LicenseHelper
-  def self.getListLicenses
-    LicenseInfo.all
+  def self.find_licenses query
+    licenses = LicenseInfo.where("version ILIKE ?", "%#{query}%").select("id, version")
+    licenses.reject!{|license| license.version == "Another"}
+    license_another = LicenseInfo.find_by_version("Another")
+    licenses << license_another if license_another
+    licenses
   end
-end
 \ No newline at end of file
+end
@@ -25,12 +25,8 @@ class OperatingSystemHelper &lt; DynamicTableHelper
   end
   def self.valid_list_operating_system? list_operating_system
-    return !(list_operating_system.nil? || list_operating_system.length == 0)
-
-    list_operating_system.each do |operating_system|
-      return false unless operating_system.valid?
-    end
-    true
+    return false if (list_operating_system.nil? || list_operating_system.length == 0)
+    return !list_operating_system.any?{|os| !os.valid?}
   end
   def self.operating_system_as_tables(list_operating_system, disabled=false)
@@ -22,8 +22,8 @@ class SoftwareCommunitiesPlugin &lt; Noosfero::Plugin
   end
   def profile_tabs
-    if context.profile.community?
-      return profile_tabs_software if context.profile.software?
+    if context.profile.community? && context.profile.software?
+      return profile_tabs_software
     end
   end
@@ -107,7 +107,6 @@ class SoftwareCommunitiesPlugin &lt; Noosfero::Plugin
         is_admin ||= user_rating.organization.admins.include?(current_user.person)
         if is_admin and profile.software?
-
             render :file => 'organization_ratings_extra_fields_show_data',
                    :locals => {:user_rating => user_rating}
         end
@@ -23,22 +23,6 @@ module SoftwareHelper
   end
   def self.all_table_is_empty? table, ignored_fields=[]
-    filled_fields = []
-
-    table.each do |key, value|
-      unless ignored_fields.include? key
-        filled_fields << if value.empty?
-          false
-        else
-          true
-        end
-      end
-    end
-
-    if filled_fields.include? true
-      false
-    else
-      true
-    end
+    return !table.keys.any?{|key| ignored_fields.include?(key) ? false : !table[key].empty?}
   end
 end
@@ -84,7 +84,7 @@ class SoftwareInfo &lt; ActiveRecord::Base
   validates_length_of :finality, :maximum => 120
   validates_length_of :objectives, :maximum => 4000
   validates_length_of :features, :maximum => 4000
-  validates_presence_of :finality
+  validates_presence_of :finality, :community
   validate :validate_acronym
@@ -166,13 +166,16 @@ class SoftwareInfo &lt; ActiveRecord::Base
     another_license_link = attributes.delete(:another_license_link)
     software_info = SoftwareInfo.new(attributes)
-    if !environment.admins.include? requestor
+    unless environment.admins.include? requestor
       CreateSoftware.create!(
         attributes.merge(
           :requestor => requestor,
           :environment => environment,
           :name => name,
-          :license_info => license_info
+          :identifier => identifier,
+          :license_info => license_info,
+          :another_license_version => another_license_version,
+          :another_license_link => another_license_link
         )
       )
     else
@@ -189,15 +192,15 @@ class SoftwareInfo &lt; ActiveRecord::Base
         community.template_id = software_template.id
       end
-      software_info.license_info = license_info
-      software_info.save
-      community.software_info = software_info
       community.save!
       community.add_admin(requestor)
+
+      software_info.community = community
+      software_info.license_info = license_info
+      software_info.verify_license_info(another_license_version, another_license_link)
+      software_info.save!
     end
-    software_info.verify_license_info(another_license_version, another_license_link)
-    software_info.save!
     software_info
   end
@@ -50,10 +50,9 @@ class SoftwareLanguageHelper &lt; DynamicTableHelper
   def self.language_html_structure(language_data, disabled)
     language_id = language_data[:programming_language_id]
-    language_name = if language_data[:programming_language_id].blank?
-      ""
-    else
-      ProgrammingLanguage.find(
+    language_name = ""
+    unless language_data[:programming_language_id].blank?
+      language_name = ProgrammingLanguage.find(
         language_data[:programming_language_id],
         :select=>"name"
       ).name
@@ -203,9 +203,100 @@ class SoftwareCommunitiesPluginMyprofileControllerTest &lt; ActionController::TestC
       :profile => @person.identifier
     )
-    assert_equal SoftwareInfo.last.license_info_id, license_another.id
-    assert_equal SoftwareInfo.last.license_info.id, nil
-    assert_equal SoftwareInfo.last.license_info.version, another_license_version
-    assert_equal SoftwareInfo.last.license_info.link, another_license_link
+    assert_equal license_another.id, SoftwareInfo.last.license_info_id
+    assert_equal nil, SoftwareInfo.last.license_info.id
+    assert_equal another_license_version, SoftwareInfo.last.license_info.version
+    assert_equal another_license_link, SoftwareInfo.last.license_info.link
   end
+
+  should "create software_info after finish task with 'Another' license_info" do
+    license_another = LicenseInfo.create(:version => "Another", :link => "#")
+
+    another_license_version = "Different License"
+    another_license_link = "http://diferent.link"
+
+    post(
+      :new_software,
+      :community => { :name => "New Software", :identifier => "new-software" },
+      :software_info => { :finality => "something", :repository_link => "" },
+      :license => { :license_infos_id => license_another.id,
+        :version => another_license_version,
+        :link=> another_license_link
+      },
+      :profile => @person.identifier
+    )
+
+    @environment.add_admin(@person)
+    Task.last.send('finish', @person)
+
+    assert_equal license_another.id, SoftwareInfo.last.license_info_id
+    assert_equal nil, SoftwareInfo.last.license_info.id
+    assert_equal another_license_version, SoftwareInfo.last.license_info.version
+    assert_equal another_license_link, SoftwareInfo.last.license_info.link
+  end
+
+  should "show error messages on create software_info" do
+    post(
+      :new_software,
+      :community => {},
+      :software_info => {},
+      :license => {},
+      :profile => @person.identifier
+    )
+    assert_includes @response.body, "Domain can't be blank"
+    assert_includes @response.body, "Name can't be blank"
+    assert_includes @response.body, "Finality can't be blank"
+    assert_includes @response.body, "Version can't be blank"
+  end
+
+  should "show domain not available error" do
+    @environment.add_admin(@person)
+
+    post(
+      :new_software,
+      :community => {:name =>"New Software", :identifier => "new-software"},
+      :software_info => {:finality => "something", :repository_link => ""},
+      :license =>{:license_infos_id => LicenseInfo.last.id},
+      :profile => @person.identifier
+    )
+    post(
+      :new_software,
+      :community => {:name =>"New Software", :identifier => "new-software"},
+      :software_info => {:finality => "something", :repository_link => ""},
+      :license =>{:license_infos_id => LicenseInfo.last.id},
+      :profile => @person.identifier
+    )
+
+    assert_includes @response.body, "Domain is not available"
+  end
+
+  should "create software with admin moderation" do
+    @environment.enable('admin_must_approve_new_communities')
+
+    post(
+      :new_software,
+      :community => {:name =>"New Software", :identifier => "new-software"},
+      :software_info => {:finality => "something", :repository_link => ""},
+      :license =>{:license_infos_id => LicenseInfo.last.id},
+      :profile => @person.identifier
+    )
+
+    @environment.add_admin(@person)
+    Task.last.send('finish', @person)
+
+    assert_equal "New Software", Task.last.data[:name]
+    assert_equal "New Software", SoftwareInfo.last.community.name
+  end
+
+  should "dont create software without accept task" do
+    assert_no_difference 'SoftwareInfo.count' do
+      post(
+        :new_software,
+        :community => {:name =>"New Software", :identifier => "new-software"},
+        :software_info => {:finality => "something", :repository_link => ""},
+        :license =>{:license_infos_id => LicenseInfo.last.id},
+        :profile => @person.identifier
+      )
+    end
+ end
 end
@@ -49,6 +49,7 @@ class SoftwareInfoValidationTest &lt; ActiveSupport::TestCase
     @software_info.features = "Do a lot of things"
     @software_info.objectives = "All tests should pass !"
+    @software_info.community = @community
   end
   def teardown
@@ -1,32 +0,0 @@
-<h2><%= _('Software Information') %></h2>
-
-<%= label_tag("name", _('Name'), {:class => 'formlabel'}) %>
-
-<div id='software-name-field' class='formfield'>
-  <span id='software-hostname'><%= context.profile.environment.default_hostname %>/</span>
-  <%= text_field_tag(:name, context.profile.software_info.community.name) %>
-</div>
-
-<h3> <%= _("Finality") %> </h3>
-<div id="finality">
-  <%= text_field_tag(:finality, context.profile.software_info.finality) %>
-</div>
-
-<h3> <%= _("Licenses") %> </h3>
-<div id='licenses'>
-  <%= select_tag(:id, options_for_select(LicenseHelper.getListLicenses.collect{|l| [l.version, l.id]}, :selected => context.profile.software_info.license_info.id), :onchange => "get_license_link('version')") %>
-  <br />
-
-  <h4> <%= _("License link") %> </h4>
-  <% LicenseHelper.getListLicenses.each do | license |  %>
-    <input type="hidden" id = "version_<%=license.id %>" value = "<%=license.link%>">
-  <% end %>
-
-  <a id = "version_link" href="<%= context.profile.software_info.license_info.link %>" target="BLANK"> <%= context.profile.software_info.license_info.link %> </a>
-</div>
-
-<div class="formfieldline formfield type-text">
-  <%= label_tag "repository_url", _("Link to Repository: ") %>
-  <%= text_field_tag(:reository_url) %>
-</div>
-
-<% LicenseHelper.getListLicenses.each do | license |  %>
-  <input type="hidden" id = "version_<%=license.id %>" value = "<%=license.link%>">
-<% end %>
-
 <%= text_field_tag "license_info[version]", license_version, :id=>"license_info_version", :class=>"license_info_version", :placeholder=>_('Autocomplete field, type some license') %>
 <%= hidden_field_tag "license[license_infos_id]", license_id, :id=>"license_info_id", :class=>"license_info_id", :data => {:label=>license_version} %>
@@ -5,7 +5,7 @@
 </div>
 <div class= <%= @error_software_acronym %> >
-  <%= label_tag("software[acronym]", _('Short Name'), {:class => 'formlabel mandatory'}) %>
+  <%= label_tag("software[acronym]", _('Short Name'), {:class => 'formlabel'}) %>
   <%= text_field_tag("software[acronym]", @profile.software_info.acronym, :id => 'software_acronym_id', :maxlength=>"10") %>
 </div>
	@@ -23,22 +23,6 @@ module SoftwareHelper		@@ -23,22 +23,6 @@ module SoftwareHelper
23	end	23	end
24		24
25	def self.all_table_is_empty? table, ignored_fields=[]	25	def self.all_table_is_empty? table, ignored_fields=[]
26	- filled_fields = []
27	-
28	- table.each do \|key, value\|
29	- unless ignored_fields.include? key
30	- filled_fields << if value.empty?
31	- false
32	- else
33	- true
34	- end
35	- end
36	- end
37	-
38	- if filled_fields.include? true
39	- false
40	- else
41	- true
42	- end	26	+ return !table.keys.any?{\|key\| ignored_fields.include?(key) ? false : !table[key].empty?}
43	end	27	end
44	end	28	end
	@@ -203,9 +203,100 @@ class SoftwareCommunitiesPluginMyprofileControllerTest < ActionController::TestC		@@ -203,9 +203,100 @@ class SoftwareCommunitiesPluginMyprofileControllerTest < ActionController::TestC
203	:profile => @person.identifier	203	:profile => @person.identifier
204	)	204	)
205		205
206	- assert_equal SoftwareInfo.last.license_info_id, license_another.id
207	- assert_equal SoftwareInfo.last.license_info.id, nil
208	- assert_equal SoftwareInfo.last.license_info.version, another_license_version
209	- assert_equal SoftwareInfo.last.license_info.link, another_license_link	206	+ assert_equal license_another.id, SoftwareInfo.last.license_info_id
		207	+ assert_equal nil, SoftwareInfo.last.license_info.id
		208	+ assert_equal another_license_version, SoftwareInfo.last.license_info.version
		209	+ assert_equal another_license_link, SoftwareInfo.last.license_info.link
210	end	210	end
		211	+
		212	+ should "create software_info after finish task with 'Another' license_info" do
		213	+ license_another = LicenseInfo.create(:version => "Another", :link => "#")
		214	+
		215	+ another_license_version = "Different License"
		216	+ another_license_link = "http://diferent.link"
		217	+
		218	+ post(
		219	+ :new_software,
		220	+ :community => { :name => "New Software", :identifier => "new-software" },
		221	+ :software_info => { :finality => "something", :repository_link => "" },
		222	+ :license => { :license_infos_id => license_another.id,
		223	+ :version => another_license_version,
		224	+ :link=> another_license_link
		225	+ },
		226	+ :profile => @person.identifier
		227	+ )
		228	+
		229	+ @environment.add_admin(@person)
		230	+ Task.last.send('finish', @person)
		231	+
		232	+ assert_equal license_another.id, SoftwareInfo.last.license_info_id
		233	+ assert_equal nil, SoftwareInfo.last.license_info.id
		234	+ assert_equal another_license_version, SoftwareInfo.last.license_info.version
		235	+ assert_equal another_license_link, SoftwareInfo.last.license_info.link
		236	+ end
		237	+
		238	+ should "show error messages on create software_info" do
		239	+ post(
		240	+ :new_software,
		241	+ :community => {},
		242	+ :software_info => {},
		243	+ :license => {},
		244	+ :profile => @person.identifier
		245	+ )
		246	+ assert_includes @response.body, "Domain can't be blank"
		247	+ assert_includes @response.body, "Name can't be blank"
		248	+ assert_includes @response.body, "Finality can't be blank"
		249	+ assert_includes @response.body, "Version can't be blank"
		250	+ end
		251	+
		252	+ should "show domain not available error" do
		253	+ @environment.add_admin(@person)
		254	+
		255	+ post(
		256	+ :new_software,
		257	+ :community => {:name =>"New Software", :identifier => "new-software"},
		258	+ :software_info => {:finality => "something", :repository_link => ""},
		259	+ :license =>{:license_infos_id => LicenseInfo.last.id},
		260	+ :profile => @person.identifier
		261	+ )
		262	+ post(
		263	+ :new_software,
		264	+ :community => {:name =>"New Software", :identifier => "new-software"},
		265	+ :software_info => {:finality => "something", :repository_link => ""},
		266	+ :license =>{:license_infos_id => LicenseInfo.last.id},
		267	+ :profile => @person.identifier
		268	+ )
		269	+
		270	+ assert_includes @response.body, "Domain is not available"
		271	+ end
		272	+
		273	+ should "create software with admin moderation" do
		274	+ @environment.enable('admin_must_approve_new_communities')
		275	+
		276	+ post(
		277	+ :new_software,
		278	+ :community => {:name =>"New Software", :identifier => "new-software"},
		279	+ :software_info => {:finality => "something", :repository_link => ""},
		280	+ :license =>{:license_infos_id => LicenseInfo.last.id},
		281	+ :profile => @person.identifier
		282	+ )
		283	+
		284	+ @environment.add_admin(@person)
		285	+ Task.last.send('finish', @person)
		286	+
		287	+ assert_equal "New Software", Task.last.data[:name]
		288	+ assert_equal "New Software", SoftwareInfo.last.community.name
		289	+ end
		290	+
		291	+ should "dont create software without accept task" do
		292	+ assert_no_difference 'SoftwareInfo.count' do
		293	+ post(
		294	+ :new_software,
		295	+ :community => {:name =>"New Software", :identifier => "new-software"},
		296	+ :software_info => {:finality => "something", :repository_link => ""},
		297	+ :license =>{:license_infos_id => LicenseInfo.last.id},
		298	+ :profile => @person.identifier
		299	+ )
		300	+ end
		301	+ end
211	end	302	end
	@@ -49,6 +49,7 @@ class SoftwareInfoValidationTest < ActiveSupport::TestCase		@@ -49,6 +49,7 @@ class SoftwareInfoValidationTest < ActiveSupport::TestCase
49		49
50	@software_info.features = "Do a lot of things"	50	@software_info.features = "Do a lot of things"
51	@software_info.objectives = "All tests should pass !"	51	@software_info.objectives = "All tests should pass !"
		52	+ @software_info.community = @community
52	end	53	end
53		54
54	def teardown	55	def teardown
	@@ -1,32 +0,0 @@	@@ -1,32 +0,0 @@
1	-<h2><%= _('Software Information') %></h2>
2	-
3	-<%= label_tag("name", _('Name'), {:class => 'formlabel'}) %>
4	-
5	-<div id='software-name-field' class='formfield'>
6	- <span id='software-hostname'><%= context.profile.environment.default_hostname %>/</span>
7	- <%= text_field_tag(:name, context.profile.software_info.community.name) %>
8	-</div>
9	-
10	-<h3> <%= _("Finality") %> </h3>
11	-<div id="finality">
12	- <%= text_field_tag(:finality, context.profile.software_info.finality) %>
13	-</div>
14	-
15	-<h3> <%= _("Licenses") %> </h3>
16	-<div id='licenses'>
17	- <%= select_tag(:id, options_for_select(LicenseHelper.getListLicenses.collect{\|l\| [l.version, l.id]}, :selected => context.profile.software_info.license_info.id), :onchange => "get_license_link('version')") %>
18	- <br />
19	-
20	- <h4> <%= _("License link") %> </h4>
21	- <% LicenseHelper.getListLicenses.each do \| license \| %>
22	- <input type="hidden" id = "version_<%=license.id %>" value = "<%=license.link%>">
23	- <% end %>
24	-
25	- <a id = "version_link" href="<%= context.profile.software_info.license_info.link %>" target="BLANK"> <%= context.profile.software_info.license_info.link %> </a>
26	-</div>
27	-
28	-<div class="formfieldline formfield type-text">
29	- <%= label_tag "repository_url", _("Link to Repository: ") %>
30	- <%= text_field_tag(:reository_url) %>
31	-</div>
32	-
1	-<% LicenseHelper.getListLicenses.each do \| license \| %>
2	- <input type="hidden" id = "version_<%=license.id %>" value = "<%=license.link%>">
3	-<% end %>
4	-
5	<%= text_field_tag "license_info[version]", license_version, :id=>"license_info_version", :class=>"license_info_version", :placeholder=>_('Autocomplete field, type some license') %>	1	<%= text_field_tag "license_info[version]", license_version, :id=>"license_info_version", :class=>"license_info_version", :placeholder=>_('Autocomplete field, type some license') %>
6	<%= hidden_field_tag "license[license_infos_id]", license_id, :id=>"license_info_id", :class=>"license_info_id", :data => {:label=>license_version} %>	2	<%= hidden_field_tag "license[license_infos_id]", license_id, :id=>"license_info_id", :class=>"license_info_id", :data => {:label=>license_version} %>
7		3
	@@ -5,7 +5,7 @@		@@ -5,7 +5,7 @@
5	</div>	5	</div>
6		6
7	<div class= <%= @error_software_acronym %> >	7	<div class= <%= @error_software_acronym %> >
8	- <%= label_tag("software[acronym]", _('Short Name'), {:class => 'formlabel mandatory'}) %>	8	+ <%= label_tag("software[acronym]", _('Short Name'), {:class => 'formlabel'}) %>
9	<%= text_field_tag("software[acronym]", @profile.software_info.acronym, :id => 'software_acronym_id', :maxlength=>"10") %>	9	<%= text_field_tag("software[acronym]", @profile.software_info.acronym, :id => 'software_acronym_id', :maxlength=>"10") %>
10	</div>	10	</div>
11		11