Download as
Browse Code »

Commit 9503be63c331a6b14d86c9f4adf9680be5371030

Authored by Gust
Committed by Gabriela Navarro
1 parent 84fb263e
Exists in master and in 79 other branches add_sisp_to_chef, add_super_archives_plugin, api_for_colab, automates_core_packing, backup_not_prod, changes_in_buttons_on_content_panel, colab_automated_login, colab_spb_plugin_recipe, colab_widgets_settings, design_validation, dev_env_minimal, disable_email_dev, fix_breadcrumbs_position, fix_categories_software_link, fix_edit_institution, fix_edit_software_with_another_license, fix_get_license_info, fix_gitlab_assets_permission, fix_list_style_inside_article, fix_list_style_on_folder_elements, fix_members_pagination, fix_merge_request_url, fix_models_translations, fix_no_license, fix_software_api, fix_software_block_migration, fix_software_communities_translations, fix_software_communities_unit_test, fix_style_create_institution_admin_panel, fix_superarchives_imports, fix_sym_links_noosfero, focus_search_field_theme, gov-user-refactoring, gov-user-refactoring-rails4, header_fix, institution_modal_on_rating, kalibro-conf-refactoring, kalibro-processor-package, lxc_settings, margin_fix, mezuro_cookbook, prezento, refactor_download_block, refactor_software_communities, refactor_software_for_sisp, register_page, release-process, release-process-v2, remove-unused-images, remove_broken_theme, remove_secondary_email_from_user, remove_sisp_buttons, removing_super_archives_email, review_message, scope2method, signals_user_noosfero, sisp_catalog_header, sisp_colab_config, sisp_dev, sisp_dev_master, sisp_simple_version, software_as_organization, software_catalog_style_fix, software_communities_html_refactor, software_infos_api, spb_minimal_env, spb_to_rails4, spec_refactor, stable-4.1, stable-4.2, stable-4.x, temp_soft_comm_refactoring, theme_header, theme_javascript_refactory, thread_dropdown, thread_page, update_search_by_categories, update_software_api, update_softwares_boxes

Add library validations and tests 

Signed-off-by: Luiz Matos <luizff.matos@gmail.com>
Signed-off-by: Gustavo Jaruga <darksshades@gmail.com>
Showing 2 changed files with 18 additions and 1 deletions   Show diff stats
lib/library.rb
  Diff comments   View file @9503be6
@@ -4,8 +4,10 @@ class Library &lt; ActiveRecord::Base @@ -4,8 +4,10 @@ class Library &lt; ActiveRecord::Base
4 4
5 attr_accessible :name, :version, :license, :software_info_id 5 attr_accessible :name, :version, :license, :software_info_id
6 6
7 - #TODO: review validations  
8 validate :validate_name, :validate_version, :validate_license 7 validate :validate_name, :validate_version, :validate_license
  8 + validates :name, length: { within: 0..20 }
  9 + validates_length_of :version, maximum: 20, too_long: _("Library is too long (maximum is 20 characters)")
  10 + validates_length_of :license, maximum: 20, too_long: _("Library is too long (maximum is 20 characters)")
9 11
10 def validate_name 12 def validate_name
11 self.errors.add(:name, _("can't be blank")) if self.name.blank? && self.errors[:name].blank? 13 self.errors.add(:name, _("can't be blank")) if self.name.blank? && self.errors[:name].blank?
test/unit/library_validation_test.rb
  Diff comments   View file @9503be6
@@ -31,4 +31,19 @@ class LibraryValidationTest &lt; ActiveSupport::TestCase @@ -31,4 +31,19 @@ class LibraryValidationTest &lt; ActiveSupport::TestCase
31 @library.license = "" 31 @library.license = ""
32 assert !@library.save 32 assert !@library.save
33 end 33 end
  34 +
  35 + should "Don't save Library if name is too long" do
  36 + @library.name = "A too long name to be a valid name for library"
  37 + assert !@library.save
  38 + end
  39 +
  40 + should "Don't save Library if version is too long" do
  41 + @library.version = "A too long version to be a valid version for library"
  42 + assert !@library.save
  43 + end
  44 +
  45 + should "Don't save Library if license is too long" do
  46 + @library.license = "A too long license to be a valid license for library"
  47 + assert !@library.save
  48 + end
34 end 49 end