Download as
Browse Code »

Commit aaf1af118849af7c1d72c0d159f75bab8b3f309d

Authored by Melissa Wen
2 parents 437de872 1e140e55
Exists in master and in 29 other branches add_sisp_to_chef, add_super_archives_plugin, automates_core_packing, changes_in_buttons_on_content_panel, colab_automated_login, colab_spb_plugin_recipe, colab_widgets_settings, disable_email_dev, fix_breadcrumbs_position, fix_categories_software_link, fix_edit_institution, fix_gitlab_assets_permission, fix_list_style_on_folder_elements, fix_software_communities_translations, fix_software_communities_unit_test, fix_style_create_institution_admin_panel, lxc_settings, mezuro_cookbook, refactor_download_block, remove_broken_theme, remove_sisp_buttons, software_communities_html_refactor, software_infos_api, spb_to_rails4, stable-4.1, stable-4.2, theme_header, theme_javascript_refactory, update_search_by_categories

Merge branch 'theme_javascript_enhancement' into 'master' 

Javascript refactor

* Uses cache in loop and reuses DOM access in variables.

See merge request !152
Showing 1 changed file with 5 additions and 6 deletions   Show diff stats
src/noosfero-spb/noosfero-spb-theme/theme.js
  Diff comments   View file @aaf1af1
... ... @@ -154,11 +154,11 @@ $('#link-buscar').click(function(e) {
154 154  
155 155 function setEvents(){
156 156 // Fade css
157   - $('.software-block-finality').css('opacity', 0);
158   - $('.software-block-finality').css('top', 0);
  157 + $('.software-block-finality').css({'opacity':0, 'top':0});
159 158 // End Fade CSS
160   - $(".software-block").mouseover(show_finality);
161   - $(".software-block").mouseout(hide_finality);
  159 + var software_block = $('.software-block');
  160 + software_block.mouseover(show_finality);
  161 + software_block.mouseout(hide_finality);
162 162  
163 163 var showOptions = $("#filter-option-catalog-software");
164 164 var hideOptions = $("#filter-option-catalog-close");
... ... @@ -173,7 +173,7 @@ $('#link-buscar').click(function(e) {
173 173 var folderList = article.getElementsByClassName('folder-content')[0];
174 174 var folderItens = folderList.getElementsByClassName('item-description');
175 175  
176   - for(var i = 0; i < folderItens.length; i++) {
  176 + for(var i = 0, var loop_length = folderItens.length; i < loop_length; i++) {
177 177 split_file_extension(folderItens[i].getElementsByTagName('a')[0]);
178 178 }
179 179 } catch(e) {
... ... @@ -195,7 +195,6 @@ $(&#39;#link-buscar&#39;).click(function(e) {
195 195 $('.star-tooltip').html("?");
196 196 }
197 197  
198   -
199 198 function set_arrow_direction() {
200 199 var additional_data_bar = $('.comments-display-fields');
201 200  
... ...