Download as
Browse Code »

Commit c9f7f5a84af15cc2a675fbba679e8ba4ac2ed2ca

Authored by Gust
Committed by Gabriela Navarro
1 parent 9503be63
Exists in master and in 79 other branches add_sisp_to_chef, add_super_archives_plugin, api_for_colab, automates_core_packing, backup_not_prod, changes_in_buttons_on_content_panel, colab_automated_login, colab_spb_plugin_recipe, colab_widgets_settings, design_validation, dev_env_minimal, disable_email_dev, fix_breadcrumbs_position, fix_categories_software_link, fix_edit_institution, fix_edit_software_with_another_license, fix_get_license_info, fix_gitlab_assets_permission, fix_list_style_inside_article, fix_list_style_on_folder_elements, fix_members_pagination, fix_merge_request_url, fix_models_translations, fix_no_license, fix_software_api, fix_software_block_migration, fix_software_communities_translations, fix_software_communities_unit_test, fix_style_create_institution_admin_panel, fix_superarchives_imports, fix_sym_links_noosfero, focus_search_field_theme, gov-user-refactoring, gov-user-refactoring-rails4, header_fix, institution_modal_on_rating, kalibro-conf-refactoring, kalibro-processor-package, lxc_settings, margin_fix, mezuro_cookbook, prezento, refactor_download_block, refactor_software_communities, refactor_software_for_sisp, register_page, release-process, release-process-v2, remove-unused-images, remove_broken_theme, remove_secondary_email_from_user, remove_sisp_buttons, removing_super_archives_email, review_message, scope2method, signals_user_noosfero, sisp_catalog_header, sisp_colab_config, sisp_dev, sisp_dev_master, sisp_simple_version, software_as_organization, software_catalog_style_fix, software_communities_html_refactor, software_infos_api, spb_minimal_env, spb_to_rails4, spec_refactor, stable-4.1, stable-4.2, stable-4.x, temp_soft_comm_refactoring, theme_header, theme_javascript_refactory, thread_dropdown, thread_page, update_search_by_categories, update_software_api, update_softwares_boxes

Add database validations and tests 

Signed-off-by: Luiz Matos <luizff.matos@gmail.com>
Signed-off-by: Gustavo Jaruga <darksshades@gmail.com>
Showing 2 changed files with 13 additions and 0 deletions   Show diff stats
lib/software_database.rb
  Diff comments   View file @c9f7f5a
... ... @@ -4,6 +4,9 @@ class SoftwareDatabase &lt; ActiveRecord::Base
4 4 belongs_to :software_info
5 5 belongs_to :database_description
6 6  
  7 + validates_length_of :version, maximum: 20, too_long: _("Software database is too long (maximum is 20 characters)")
  8 + validates_length_of :operating_system, maximum: 20, too_long: _("Software database is too long (maximum is 20 characters)")
  9 +
7 10 validates_presence_of :database_description_id, :version, :operating_system
8 11  
9 12 end
... ...
test/unit/database_validation_test.rb
  Diff comments   View file @c9f7f5a
... ... @@ -33,4 +33,14 @@ class DatabaseValidationTest &lt; ActiveSupport::TestCase
33 33 @database.version = " "
34 34 assert_equal true, !@database.save
35 35 end
  36 +
  37 + should "Don't save database if version is too long" do
  38 + @database.version = "A too long version to be a valid version for database"
  39 + assert !@database.save
  40 + end
  41 +
  42 + should "Don't save database if operating system is too long" do
  43 + @database.operating_system = "A too long operating system to be a valid operating system for library"
  44 + assert !@database.save
  45 + end
36 46 end
... ...