Commit d908bfc4a93726921883c102fe71adac7f313bb4
1 parent
5d33a2d4
Exists in
master
and in
2 other branches
Bit field saved_rev_wraparound_mode of type int should have explicitly unsigned …
…integral, explicitly signed integral, or enumeration type.
Showing
1 changed file
with
49 additions
and
49 deletions
Show diff stats
src/include/internals.h
... | ... | @@ -324,34 +324,34 @@ struct _h3270 |
324 | 324 | // flags |
325 | 325 | LIB3270_HOST_TYPE host_type; ///< @brief Host type. |
326 | 326 | |
327 | - int selected : 1; ///< @brief Has selected region? | |
328 | - int has_copy : 1; ///< @brief Has copy? | |
329 | - int rectsel : 1; ///< @brief Selected region is a rectangle ? | |
330 | - int vcontrol : 1; ///< @brief Visible control ? | |
331 | - int modified_sel : 1; | |
332 | - int mono : 1; ///< @brief Forces monochrome display | |
333 | - int m3279 : 1; | |
334 | - int extended : 1; ///< @brief Extended data stream. | |
335 | - int typeahead : 1; | |
336 | - int numeric_lock : 1; | |
337 | - int oerr_lock : 1; ///< @brief If true, operator errors will lock the keyboard. | |
338 | - int unlock_delay : 1; ///< @brief If true the unlock delay feature is enabled. @see lib3270_set_unlock_delay | |
339 | - int auto_reconnect_inprogress : 1; | |
327 | + unsigned int selected : 1; ///< @brief Has selected region? | |
328 | + unsigned int has_copy : 1; ///< @brief Has copy? | |
329 | + unsigned int rectsel : 1; ///< @brief Selected region is a rectangle ? | |
330 | + unsigned int vcontrol : 1; ///< @brief Visible control ? | |
331 | + unsigned int modified_sel : 1; | |
332 | + unsigned int mono : 1; ///< @brief Forces monochrome display | |
333 | + unsigned int m3279 : 1; | |
334 | + unsigned int extended : 1; ///< @brief Extended data stream. | |
335 | + unsigned int typeahead : 1; | |
336 | + unsigned int numeric_lock : 1; | |
337 | + unsigned int oerr_lock : 1; ///< @brief If true, operator errors will lock the keyboard. | |
338 | + unsigned int unlock_delay : 1; ///< @brief If true the unlock delay feature is enabled. @see lib3270_set_unlock_delay | |
339 | + unsigned int auto_reconnect_inprogress : 1; | |
340 | 340 | unsigned int colors : 5; |
341 | - int apl_mode : 1; ///< @brief If true enables APL mode. | |
342 | - int icrnl : 1; | |
343 | - int inlcr : 1; | |
344 | - int onlcr : 1; | |
345 | - int bsd_tm : 1; | |
346 | - int syncing : 1; | |
347 | - int reverse : 1; ///< @brief reverse-input mode | |
348 | - int dbcs : 1; | |
349 | - int linemode : 1; | |
350 | - int trace_skipping : 1; | |
351 | - int need_tls_follows : 1; | |
352 | - int cut_xfer_in_progress : 1; | |
353 | - int formatted : 1; ///< @brief Formatted screen flag | |
354 | - int starting : 1; ///< @brief Is starting (no first screen)? | |
341 | + unsigned int apl_mode : 1; ///< @brief If true enables APL mode. | |
342 | + unsigned int icrnl : 1; | |
343 | + unsigned int inlcr : 1; | |
344 | + unsigned int onlcr : 1; | |
345 | + unsigned int bsd_tm : 1; | |
346 | + unsigned int syncing : 1; | |
347 | + unsigned int reverse : 1; ///< @brief reverse-input mode | |
348 | + unsigned int dbcs : 1; | |
349 | + unsigned int linemode : 1; | |
350 | + unsigned int trace_skipping : 1; | |
351 | + unsigned int need_tls_follows : 1; | |
352 | + unsigned int cut_xfer_in_progress : 1; | |
353 | + unsigned int formatted : 1; ///< @brief Formatted screen flag | |
354 | + unsigned int starting : 1; ///< @brief Is starting (no first screen)? | |
355 | 355 | |
356 | 356 | struct lib3270_toggle |
357 | 357 | { |
... | ... | @@ -440,9 +440,9 @@ struct _h3270 |
440 | 440 | unsigned char default_cs; |
441 | 441 | unsigned char default_ic; |
442 | 442 | char reply_mode; |
443 | - int trace_primed : 1; | |
444 | - int ticking : 1; | |
445 | - int mticking : 1; | |
443 | + unsigned int trace_primed : 1; | |
444 | + unsigned int ticking : 1; | |
445 | + unsigned int mticking : 1; | |
446 | 446 | int crm_nattr; |
447 | 447 | unsigned char crm_attr[16]; |
448 | 448 | unsigned char * zero_buf; /**< @brief Empty buffer, for area clears */ |
... | ... | @@ -532,9 +532,9 @@ struct _h3270 |
532 | 532 | int dft_buffersize; ///< @brief Buffer size (LIMIN, LIMOUT) |
533 | 533 | |
534 | 534 | // rpq.c |
535 | - int rpq_complained : 1; | |
535 | + unsigned int rpq_complained : 1; | |
536 | 536 | #if !defined(_WIN32) |
537 | - int omit_due_space_limit : 1; | |
537 | + unsigned int omit_due_space_limit : 1; | |
538 | 538 | #endif |
539 | 539 | |
540 | 540 | char * rpq_warnbuf; |
... | ... | @@ -557,28 +557,28 @@ struct _h3270 |
557 | 557 | int once_cset; |
558 | 558 | int saved_cursor; |
559 | 559 | |
560 | - int held_wrap : 1; | |
560 | + unsigned int held_wrap : 1; | |
561 | 561 | |
562 | - int insert_mode : 1; | |
563 | - int auto_newline_mode : 1; | |
562 | + unsigned int insert_mode : 1; | |
563 | + unsigned int auto_newline_mode : 1; | |
564 | 564 | |
565 | - int appl_cursor : 1; | |
566 | - int saved_appl_cursor : 1; | |
565 | + unsigned int appl_cursor : 1; | |
566 | + unsigned int saved_appl_cursor : 1; | |
567 | 567 | |
568 | - int wraparound_mode : 1; | |
569 | - int saved_wraparound_mode : 1; | |
568 | + unsigned int wraparound_mode : 1; | |
569 | + unsigned int saved_wraparound_mode : 1; | |
570 | 570 | |
571 | - int rev_wraparound_mode : 1; | |
572 | - int saved_rev_wraparound_mode : 1; | |
571 | + unsigned int rev_wraparound_mode : 1; | |
572 | + unsigned int saved_rev_wraparound_mode : 1; | |
573 | 573 | |
574 | - int allow_wide_mode : 1; | |
575 | - int saved_allow_wide_mode : 1; | |
574 | + unsigned int allow_wide_mode : 1; | |
575 | + unsigned int saved_allow_wide_mode : 1; | |
576 | 576 | |
577 | - int wide_mode : 1; | |
578 | - int saved_wide_mode : 1; | |
577 | + unsigned int wide_mode : 1; | |
578 | + unsigned int saved_wide_mode : 1; | |
579 | 579 | |
580 | - int saved_altbuffer : 1; | |
581 | - int ansi_reset : 1; /**< @brief Non zero if the ansi_reset() was called in this session */ | |
580 | + unsigned int saved_altbuffer : 1; | |
581 | + unsigned int ansi_reset : 1; /**< @brief Non zero if the ansi_reset() was called in this session */ | |
582 | 582 | |
583 | 583 | int ansi_ch; |
584 | 584 | int cs_to_change; |
... | ... | @@ -652,8 +652,8 @@ struct _h3270 |
652 | 652 | |
653 | 653 | struct |
654 | 654 | { |
655 | - int host : 1; ///< @brief Non zero if host requires SSL. | |
656 | - int download_crl : 1; ///< @brief Non zero to download CRL. | |
655 | + unsigned int host : 1; ///< @brief Non zero if host requires SSL. | |
656 | + unsigned int download_crl : 1; ///< @brief Non zero to download CRL. | |
657 | 657 | LIB3270_SSL_STATE state; |
658 | 658 | int error; |
659 | 659 | const LIB3270_SSL_MESSAGE * message; ///< @brief Pointer to SSL messages for current state. | ... | ... |