Download as
Browse Code »

Commit 5d954f922d8814114f603fd52bf61022a70224b1

Authored by Perry Werneck
1 parent 1721891b
Exists in master and in 1 other branch develop

Refactoring D-Bus request.

Showing 3 changed files with 6 additions and 4 deletions   Show diff stats
client/src/core/linux/request.cc
  Diff comments   View file @5d954f9
... ... @@ -87,10 +87,7 @@
87 87  
88 88 IPC::Request & IPC::Request::push(int type, const void *value) {
89 89  
90   - DBusMessageIter iter;
91   - dbus_message_iter_init_append(request.msg, &iter);
92   -
93   - if (!dbus_message_iter_append_basic(&iter,type,value)) {
  90 + if (!dbus_message_iter_append_basic(&request.iter,type,value)) {
94 91 throw std::runtime_error("Can't append value");
95 92 }
96 93  
... ...
client/src/include/lib3270/ipc/request.h
  Diff comments   View file @5d954f9
... ... @@ -114,6 +114,7 @@
114 114 /// @brief Message who will be sent to server.
115 115 struct {
116 116 DBusMessage * msg;
  117 + DBusMessageIter iter;
117 118 } request;
118 119  
119 120 DBusConnection * conn;
... ...
client/src/session/remote/linux/request.cc
  Diff comments   View file @5d954f9
... ... @@ -60,6 +60,8 @@
60 60 throw std::runtime_error("Can't create D-Bus Method Call");
61 61 }
62 62  
  63 + dbus_message_iter_init_append(request.msg, &request.iter);
  64 +
63 65 }
64 66  
65 67 IPC::Request::Request(const IPC::Session &session, bool isSet, const char *property) : Request(session.conn) {
... ... @@ -75,6 +77,8 @@
75 77 throw std::runtime_error("Can't create D-Bus Property Call");
76 78 }
77 79  
  80 + dbus_message_iter_init_append(request.msg, &request.iter);
  81 +
78 82 //
79 83 // https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-properties
80 84 // org.freedesktop.DBus.Properties.Get (in STRING interface_name,
... ...