Download as
Browse Code »

Commit 7fa8b5302669bd68a31c7fafa49565396579ee44

Authored by Perry Werneck
1 parent 2545f306
Exists in master and in 1 other branch develop

Fixing as requested on review of https://build.opensuse.org/request/show/731972: 

 `%clean` is long redundant.
 `%post \n /sbin/ldconfig` should become `%post -p /sbin/ldconfig`.
 `exit 0` is redundant.
 `%defattr` is redundant (unless you still target SLE12).
 `Group: Development/Libraries/C and C++` for libv3270-devel.
 `rm -Rf $RPM_BUILD_ROOT` is redundant.
 `$RPM_BUILD_ROOT` is ancient and can be replaced by `%buildroot`.
Showing 1 changed file with 3 additions and 12 deletions   Show diff stats
rpm/libv3270.spec
  Diff comments   View file @7fa8b53
@@ -138,12 +138,9 @@ NOCONFIGURE=1 ./autogen.sh @@ -138,12 +138,9 @@ NOCONFIGURE=1 ./autogen.sh
138 --enable-pic 138 --enable-pic
139 139
140 %build 140 %build
141 -make clean  
142 make all 141 make all
143 142
144 %install 143 %install
145 -rm -rf $RPM_BUILD_ROOT  
146 -  
147 %makeinstall 144 %makeinstall
148 145
149 %files 146 %files
@@ -182,16 +179,10 @@ rm -rf $RPM_BUILD_ROOT @@ -182,16 +179,10 @@ rm -rf $RPM_BUILD_ROOT
182 /usr/share/glade/pixmaps/hicolor/16x16/actions/widget-v3270-terminal.png 179 /usr/share/glade/pixmaps/hicolor/16x16/actions/widget-v3270-terminal.png
183 /usr/share/glade/pixmaps/hicolor/22x22/actions/widget-v3270-terminal.png 180 /usr/share/glade/pixmaps/hicolor/22x22/actions/widget-v3270-terminal.png
184 181
185 -%pre  
186 -/sbin/ldconfig  
187 -exit 0 182 +%pre -p /sbin/ldconfig
188 183
189 -%post  
190 -/sbin/ldconfig  
191 -exit 0 184 +%post -p /sbin/ldconfig
192 185
193 -%postun  
194 -/sbin/ldconfig  
195 -exit 0 186 +%postun -p /sbin/ldconfig
196 187
197 %changelog 188 %changelog