Commit d9e8ef651a9888e5170593758837f4cc51920d3a

Authored by Perry Werneck
1 parent a3e7f000
Exists in master and in 1 other branch develop

Fixing lgtm alerts.

src/dialogs/save/save.c
@@ -179,7 +179,7 @@ static void icon_press(GtkEntry *entry, G_GNUC_UNUSED GtkEntryIconPosition icon_ @@ -179,7 +179,7 @@ static void icon_press(GtkEntry *entry, G_GNUC_UNUSED GtkEntryIconPosition icon_
179 179
180 } 180 }
181 181
182 - static void fileformat_changed(GtkComboBox *formats, GtkEntry *entry) 182 + static void fileformat_changed(GtkComboBox *fmts, GtkEntry *entry)
183 { 183 {
184 const gchar * text = gtk_entry_get_text(entry); 184 const gchar * text = gtk_entry_get_text(entry);
185 185
@@ -191,7 +191,7 @@ static void icon_press(GtkEntry *entry, G_GNUC_UNUSED GtkEntryIconPosition icon_ @@ -191,7 +191,7 @@ static void icon_press(GtkEntry *entry, G_GNUC_UNUSED GtkEntryIconPosition icon_
191 return; 191 return;
192 192
193 extension++; 193 extension++;
194 - const gchar * format = gtk_combo_box_get_active_id(formats); 194 + const gchar * format = gtk_combo_box_get_active_id(fmts);
195 if(*format == '.') 195 if(*format == '.')
196 format++; 196 format++;
197 197
src/include/terminal.h
@@ -115,15 +115,15 @@ @@ -115,15 +115,15 @@
115 GtkWidget parent; 115 GtkWidget parent;
116 116
117 // flags 117 // flags
118 - int selecting : 1; ///< @brief Selecting region  
119 - int moving : 1; ///< @brief Moving selected region  
120 - int resizing : 1; ///< @brief Resizing selected region  
121 - int scaled_fonts : 1; ///< @brief Use scaled fonts  
122 - int drawing : 1; ///< @brief Draw widget?  
123 - int freeze : 1; ///< @brief Truee when the "save settings" signal is disabled.  
124 - int append : 1; ///< @brief Next smart-copy operation will be append.  
125 - int copying : 1; ///< @brief Copy with center mouse button  
126 - int open_url : 1; ///< @brief Emit 'open-url' signal when and http:// or https:// url is selected by 'word-select' action. 118 + unsigned int selecting : 1; ///< @brief Selecting region
  119 + unsigned int moving : 1; ///< @brief Moving selected region
  120 + unsigned int resizing : 1; ///< @brief Resizing selected region
  121 + unsigned int scaled_fonts : 1; ///< @brief Use scaled fonts
  122 + unsigned int drawing : 1; ///< @brief Draw widget?
  123 + unsigned int freeze : 1; ///< @brief True when the "save settings" signal is disabled.
  124 + unsigned int append : 1; ///< @brief Next smart-copy operation will be append.
  125 + unsigned int copying : 1; ///< @brief Copy with center mouse button
  126 + unsigned int open_url : 1; ///< @brief Emit 'open-url' signal when and http:// or https:// url is selected by 'word-select' action.
127 127
128 /// @brief Action properties. 128 /// @brief Action properties.
129 // GtkResponseType responses[V3270_TOGGLEABLE_DIALOG_CUSTOM]; 129 // GtkResponseType responses[V3270_TOGGLEABLE_DIALOG_CUSTOM];
@@ -203,7 +203,7 @@ @@ -203,7 +203,7 @@
203 // Blink 203 // Blink
204 struct 204 struct
205 { 205 {
206 - int show : 1; ///< @brief Show element? 206 + unsigned int show : 1; ///< @brief Show element?
207 GSource * timer; ///< @brief Timer source. 207 GSource * timer; ///< @brief Timer source.
208 } blink; 208 } blink;
209 209
src/selection/text.c
@@ -124,7 +124,7 @@ gchar * v3270_convert_to_3270_charset(GtkWidget *widget, const gchar *text, cons @@ -124,7 +124,7 @@ gchar * v3270_convert_to_3270_charset(GtkWidget *widget, const gchar *text, cons
124 124
125 g_autofree gchar *string = g_strdup(text); 125 g_autofree gchar *string = g_strdup(text);
126 126
127 - // FIXME (perry#1#): Is there any better way for a "sed" here? 127 + // Is there any better way for a "sed" here?
128 for(f=0;f<G_N_ELEMENTS(xlat);f++) 128 for(f=0;f<G_N_ELEMENTS(xlat);f++)
129 { 129 {
130 gchar *ptr = g_strstr_len(string,-1,xlat[f].from); 130 gchar *ptr = g_strstr_len(string,-1,xlat[f].from);