Download as
Browse Code »

Commit 15e7387a308eb9ffb3a754c7f19f81eb707262db

Authored by Sergio Oliveira
1 parent 29117f5a
Exists in master and in 30 other branches 1.12.x, add_requests_as_dep, celery_service, change-passwd-signal, colab-signals, colab-vcard, colab_search, colab_tag, colab_tag_merge, detach_super_archives, fix-dashboard, fix-message-preview, fix_app_label, fix_header, fixed_gitlab_import, go_to_profile_panel, mobile_user_scalable, paginate-threads, profile_integration, refactor-data-import, remove-gitlab-plugin, removing_namespace, search_block, search_filters, split_screen, startplugin, timestamp_plugins, translation_review, user_regex, validate-passwd

Fixed flake8 warnings/errors

Showing 4 changed files with 5 additions and 9 deletions   Show diff stats
colab/plugins/gitlab/signals.py
  Diff comments   View file @15e7387
@@ -2,15 +2,14 @@ from colab.plugins.utils.signals import AbstractSignal @@ -2,15 +2,14 @@ from colab.plugins.utils.signals import AbstractSignal
2 from colab.plugins.gitlab.tasks import handling_method 2 from colab.plugins.gitlab.tasks import handling_method
3 from colab.signals.signals import register_signal, connect_signal 3 from colab.signals.signals import register_signal, connect_signal
4 4
  5 +
5 class GitlabSignals(AbstractSignal): 6 class GitlabSignals(AbstractSignal):
6 7
7 short_name = 'gitlab' 8 short_name = 'gitlab'
8 signals_list = ['gitlab_create_project'] 9 signals_list = ['gitlab_create_project']
9 10
10 -  
11 def register_signal(self): 11 def register_signal(self):
12 register_signal(self.short_name, self.signals_list) 12 register_signal(self.short_name, self.signals_list)
13 -  
14 13
15 def connect_signal(self): 14 def connect_signal(self):
16 connect_signal(self.signals_list[0], self.short_name, handling_method) 15 connect_signal(self.signals_list[0], self.short_name, handling_method)
colab/plugins/utils/apps.py
  Diff comments   View file @15e7387
@@ -13,7 +13,6 @@ class ColabProxiedAppConfig(AppConfig): @@ -13,7 +13,6 @@ class ColabProxiedAppConfig(AppConfig):
13 self._import_signals(app_name) 13 self._import_signals(app_name)
14 self.signals.register_signal() 14 self.signals.register_signal()
15 15
16 -  
17 def _import_signals(self, app_name): 16 def _import_signals(self, app_name):
18 self.module_path = app_name + '.signals' 17 self.module_path = app_name + '.signals'
19 self.module = importlib.import_module(self.module_path) 18 self.module = importlib.import_module(self.module_path)
@@ -27,6 +26,5 @@ class ColabProxiedAppConfig(AppConfig): @@ -27,6 +26,5 @@ class ColabProxiedAppConfig(AppConfig):
27 self.signals = module_item() 26 self.signals = module_item()
28 break 27 break
29 28
30 -  
31 def ready(self): 29 def ready(self):
32 self.signals.connect_signal() 30 self.signals.connect_signal()
colab/plugins/utils/signals.py
  Diff comments   View file @15e7387
@@ -2,7 +2,7 @@ @@ -2,7 +2,7 @@
2 from abc import abstractmethod 2 from abc import abstractmethod
3 3
4 4
5 -class AbstractSignal(object) 5 +class AbstractSignal(object):
6 6
7 @abstractmethod 7 @abstractmethod
8 def register_signal(self): 8 def register_signal(self):
colab/signals/signals.py
  Diff comments   View file @15e7387
  1 +
1 from django.dispatch import Signal 2 from django.dispatch import Signal
2 -from colab.signals.celery import app  
3 3
4 from .exceptions import SignalDoesNotExist 4 from .exceptions import SignalDoesNotExist
5 5
6 -  
7 registered_signals = {} 6 registered_signals = {}
8 signal_instances = {} 7 signal_instances = {}
9 8
@@ -17,7 +16,7 @@ Signal.__reduce__ = reducer @@ -17,7 +16,7 @@ Signal.__reduce__ = reducer
17 def register_signal(plugin_name, list_signals): 16 def register_signal(plugin_name, list_signals):
18 for signal in list_signals: 17 for signal in list_signals:
19 if signal in registered_signals: 18 if signal in registered_signals:
20 - if not plugin_name in registered_signals[signal]: 19 + if plugin_name not in registered_signals[signal]:
21 registered_signals[signal].append(plugin_name) 20 registered_signals[signal].append(plugin_name)
22 else: 21 else:
23 registered_signals[signal] = [] 22 registered_signals[signal] = []
@@ -28,7 +27,7 @@ def register_signal(plugin_name, list_signals): @@ -28,7 +27,7 @@ def register_signal(plugin_name, list_signals):
28 def connect_signal(signal_name, sender, handling_method): 27 def connect_signal(signal_name, sender, handling_method):
29 if signal_name in signal_instances: 28 if signal_name in signal_instances:
30 signal_instances[signal_name].connect(handling_method.delay, 29 signal_instances[signal_name].connect(handling_method.delay,
31 - sender=sender) 30 + sender=sender)
32 else: 31 else:
33 raise SignalDoesNotExist 32 raise SignalDoesNotExist
34 33