Download as
Browse Code »

Commit aef211b9ad52f33f55cbb6199fdd2cf85db2672d

Authored by Carlos Coêlho
Committed by Sergio Oliveira
1 parent cfee3a09
Exists in master and in 39 other branches 1.12.x, add_requests_as_dep, celery_service, change-passwd-signal, check-port, colab-signals, colab-vcard, colab_search, colab_tag, colab_tag_merge, community_association, detach_super_archives, fix-dashboard, fix-message-preview, fix_app_label, fix_cache_count_spb, fix_header, fixed_gitlab_import, go_to_profile_panel, header_footer, layout-fix, mobile_user_scalable, move_out_plugins, paginate-threads, profile_integration, refactor-data-import, remove-gitlab-plugin, removing_namespace, search_block, search_filters, spb-release/3.0, split_screen, stable, startplugin, timestamp_plugins, translation_review, user_regex, validate-passwd, workin_whoosh_temp

Validated blank space in username field 

Validated a case where the user was able to insert blank space in
username field in the Register step

Signed-off-by: Carlos Oliveira <carlospecter@gmail.com>
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Showing 1 changed file with 13 additions and 6 deletions   Show diff stats
colab/accounts/forms.py
  Diff comments   View file @aef211b
@@ -32,11 +32,6 @@ class UserForm(forms.ModelForm): @@ -32,11 +32,6 @@ class UserForm(forms.ModelForm):
32 # Forces username to be lowercase always 32 # Forces username to be lowercase always
33 widget=forms.TextInput(attrs={'style' : 'text-transform: lowercase;'}), 33 widget=forms.TextInput(attrs={'style' : 'text-transform: lowercase;'}),
34 ) 34 )
35 - email = forms.EmailField(  
36 -  
37 - # Forces email to be a read-only field  
38 - widget=forms.TextInput(attrs={'readonly': 'readonly'})  
39 - )  
40 required = ('first_name', 'last_name', 'email', 'username') 35 required = ('first_name', 'last_name', 'email', 'username')
41 36
42 class Meta: 37 class Meta:
@@ -53,8 +48,20 @@ class UserForm(forms.ModelForm): @@ -53,8 +48,20 @@ class UserForm(forms.ModelForm):
53 field.required = True 48 field.required = True
54 49
55 50
56 -  
57 class UserCreationForm(UserForm): 51 class UserCreationForm(UserForm):
  52 + email = forms.EmailField(
  53 +
  54 + # Forces email to be a read-only field
  55 + widget=forms.TextInput(attrs={'readonly': 'readonly'})
  56 + )
  57 +
  58 + def clean_username(self):
  59 + username = self.cleaned_data['username']
  60 + username = username.strip()
  61 + if len(username) is 0:
  62 + raise forms.ValidationError('This field should not be blank.')
  63 + return username
  64 +
58 class Meta: 65 class Meta:
59 model = User 66 model = User
60 fields = ('first_name', 'last_name', 'email', 'username') 67 fields = ('first_name', 'last_name', 'email', 'username')