Download as
Browse Code »

Commit e4fe56f664901be40a15e369134258114f9b9a64

Authored by Carlos Coêlho
Committed by Sergio Oliveira
1 parent e80461ab
Exists in master and in 39 other branches 1.12.x, add_requests_as_dep, celery_service, change-passwd-signal, check-port, colab-signals, colab-vcard, colab_search, colab_tag, colab_tag_merge, community_association, detach_super_archives, fix-dashboard, fix-message-preview, fix_app_label, fix_cache_count_spb, fix_header, fixed_gitlab_import, go_to_profile_panel, header_footer, layout-fix, mobile_user_scalable, move_out_plugins, paginate-threads, profile_integration, refactor-data-import, remove-gitlab-plugin, removing_namespace, search_block, search_filters, spb-release/3.0, split_screen, stable, startplugin, timestamp_plugins, translation_review, user_regex, validate-passwd, workin_whoosh_temp

Corrected empty checking for user and username 

Signed-off-by: Carlos Oliveira <carlospecter@gmail.com>
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
colab/accounts/auth.py
  Diff comments   View file @e4fe56f
@@ -14,7 +14,7 @@ class ColabBrowserIDBackend(BrowserIDBackend): @@ -14,7 +14,7 @@ class ColabBrowserIDBackend(BrowserIDBackend):
14 14
15 user = self.User.objects.filter(emails__address=email) 15 user = self.User.objects.filter(emails__address=email)
16 16
17 - if len(user) is not 0: 17 + if not user:
18 return user 18 return user
19 19
20 return self.User.objects.create_user( 20 return self.User.objects.create_user(
colab/accounts/forms.py
  Diff comments   View file @e4fe56f
@@ -58,7 +58,7 @@ class UserCreationForm(UserForm): @@ -58,7 +58,7 @@ class UserCreationForm(UserForm):
58 def clean_username(self): 58 def clean_username(self):
59 username = self.cleaned_data['username'] 59 username = self.cleaned_data['username']
60 username = username.strip() 60 username = username.strip()
61 - if len(username) is 0: 61 + if not username:
62 raise forms.ValidationError('This field should not be blank.') 62 raise forms.ValidationError('This field should not be blank.')
63 return username 63 return username
64 64