Download as
Browse Code »

Commit f1ff2fc7373ad36fdd4c4df1e644cf5cf7bc24e2

Authored by Lucas Kanashiro
Committed by Sergio Oliveira
1 parent 5975ae7b
Exists in master and in 30 other branches 1.12.x, add_requests_as_dep, celery_service, change-passwd-signal, colab-signals, colab-vcard, colab_search, colab_tag, colab_tag_merge, detach_super_archives, fix-dashboard, fix-message-preview, fix_app_label, fix_header, fixed_gitlab_import, go_to_profile_panel, mobile_user_scalable, paginate-threads, profile_integration, refactor-data-import, remove-gitlab-plugin, removing_namespace, search_block, search_filters, split_screen, startplugin, timestamp_plugins, translation_review, user_regex, validate-passwd

colab.signals: raise exception in send method 

If signal is not registered before call send.

Signed-off-by: Lucas Moura <lucas.moura128@gmail.com>
Showing 2 changed files with 4 additions and 1 deletions   Show diff stats
colab/signals/signals.py
  Diff comments   View file @f1ff2fc
@@ -29,3 +29,5 @@ class Signals(): @@ -29,3 +29,5 @@ class Signals():
29 def send(self, signal_name, sender, **kwargs): 29 def send(self, signal_name, sender, **kwargs):
30 if signal_name in self.signal_instances: 30 if signal_name in self.signal_instances:
31 self.signal_instances[signal_name].send(sender=sender) 31 self.signal_instances[signal_name].send(sender=sender)
  32 + else:
  33 + raise Exception("Signal does not exist!")
colab/signals/tests/test_signals.py
  Diff comments   View file @f1ff2fc
@@ -79,4 +79,5 @@ class SignalsTest(TestCase): @@ -79,4 +79,5 @@ class SignalsTest(TestCase):
79 self.assertTrue(mock.is_called) 79 self.assertTrue(mock.is_called)
80 80
81 81
82 - 82 + def test_send_signal_not_registered(self):
  83 + self.assertRaises(Exception, self.signals.send, 'test_signal', 'test')