Using custom exception

Sergio Oliveira
1 parent 2f08f0d5
Showing 4 changed files with 17 additions and 6 deletions Show diff stats
colab/exceptions.py
colab/signals/exceptions.py
colab/signals/signals.py
colab/signals/tests/test_signals.py
@@ -0,0 +1,3 @@
+
+class ColabException(Exception):
+    """Base class for all exceptions raised by Colab"""
@@ -0,0 +1,6 @@
+
+from ..exceptions import ColabException
+
+
+class SignalDoesNotExist(ColabException):
+    """Expcetion raised when signal does not exist"""
 from django.dispatch import Signal
 from colab.signals.celery import app
+from .exceptions import SignalDoesNotExist
+
 registered_signals = {}
 signal_instances = {}
@@ -28,11 +30,11 @@ def connect_signal(signal_name, sender, handling_method):
         signal_instances[signal_name].connect(handling_method.delay,
                 sender=sender)
     else:
-        raise Exception("Signal does not exist!")
+        raise SignalDoesNotExist
 def send(signal_name, sender, **kwargs):
     if signal_name in signal_instances:
         signal_instances[signal_name].send(sender=sender, **kwargs)
     else:
-        raise Exception("Signal does not exist!")
+        raise SignalDoesNotExist
@@ -9,8 +9,8 @@ from django.test import TestCase
 from mock import patch, MagicMock, PropertyMock
-from colab.signals.signals import (registered_signals, register_signal,
-                                   connect_signal, send)
+from ..signals import registered_signals, register_signal, connect_signal, send
+from ..exceptions import SignalDoesNotExist
 class SignalsTest(TestCase):
@@ -43,7 +43,7 @@ class SignalsTest(TestCase):
         handling_method = 'Test'
         signal_name = 'Test'
-        self.assertRaises(Exception, connect_signal, signal_name,
+        self.assertRaises(SignalDoesNotExist, connect_signal, signal_name,
                           sender, handling_method)
     @patch('colab.signals.signals.Signal.connect')
@@ -76,4 +76,4 @@ class SignalsTest(TestCase):
         self.assertTrue(mock.is_called)
     def test_send_signal_not_registered(self):
-        self.assertRaises(Exception, send, 'test_signal', 'test')
+        self.assertRaises(SignalDoesNotExist, send, 'test_signal', 'test')
@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
	1	+
	2	+class ColabException(Exception):
	3	+ """Base class for all exceptions raised by Colab"""
@@ -0,0 +1,6 @@		@@ -0,0 +1,6 @@
	1	+
	2	+from ..exceptions import ColabException
	3	+
	4	+
	5	+class SignalDoesNotExist(ColabException):
	6	+ """Expcetion raised when signal does not exist"""