Carlos Coêlho · Sergio Oliveira · Sergio Oliveira · Carlos Coêlho · Carlos Coêlho · Carlos Coêlho
 """
  
 # Build paths inside the project like this: os.path.join(BASE_DIR, ...)
+import mimetypes
 import os
-BASE_DIR = os.path.dirname(__file__)
  
-# Used for settings translation
+from django.contrib.messages import constants as messages
-        now = timezone.now()
-        days_ago = lambda date: (now - date).days
-        get_score = lambda weight, created: max(weight - (days_ago(created)
-                                                // 3), 5)
-
         vote_score = 0
         replies_score = 0
         for msg in self.message_set.all():
             # Calculate replies_score
-            replies_score += get_score(300, msg.received_time)
+            replies_score += self.get_score(300, msg.received_time)
  
             # Calculate vote_score
             for vote in msg.vote_set.all():
-                vote_score += get_score(100, vote.created)
+                vote_score += self.get_score(100, vote.created)
@@ -3,17 +3,16 @@
                                  self.subject_token,
                                  self.message_set.count())
  
+    def days_ago(self, date):
 """
  
 import os
+from django.core.wsgi import get_wsgi_application
 SUPER_ARCHIVES_EXCLUDE = []
 SUPER_ARCHIVES_LOCK_FILE = '/var/lock/colab/import_emails.lock'
  
-# Feedzilla  (planet)
-from feedzilla.settings import *  # noqa (flake8 ignore)
9	9	"""
10	10
11	11	# Build paths inside the project like this: os.path.join(BASE_DIR, ...)
	12	+import mimetypes
12	13	import os
13		-BASE_DIR = os.path.dirname(__file__)
14	14
15		-# Used for settings translation
	15	+from django.contrib.messages import constants as messages
1		Link here Rodrigo Siqueira de Melo @rodrigo 2015-02-11 17:07:41 UTC How about jumping one line between "from" and the comment? Just idea.. Write Preview How about jumping one line between "from" and the comment? Just idea.. Choose File ... File name... Cancel
210		- now = timezone.now()
211		- days_ago = lambda date: (now - date).days
212		- get_score = lambda weight, created: max(weight - (days_ago(created)
213		- // 3), 5)
214		-
215	218	vote_score = 0
216	219	replies_score = 0
217	220	for msg in self.message_set.all():
218	221	# Calculate replies_score
219		- replies_score += get_score(300, msg.received_time)
	222	+ replies_score += self.get_score(300, msg.received_time)
220	223
221	224	# Calculate vote_score
222	225	for vote in msg.vote_set.all():
223		- vote_score += get_score(100, vote.created)
	226	+ vote_score += self.get_score(100, vote.created)
2		Link here Rodrigo Siqueira de Melo @rodrigo 2015-02-11 17:16:24 UTC Why you defined 300 at line number 222 and 100 here? Write Preview Why you defined 300 at line number 222 and 100 here? Choose File ... File name... Cancel Link here Sergio Oliveira @seocam 2015-02-22 20:48:53 UTC @rodrigosiqueiramelo is that question for me? You can use @username to make direct questions. The 100 and 300 are just weights. When calculating the relevance score for a thread each reply is 3x stronger than a vote in the same thread. That's because the vote it's not for the thread but for an answer. In fact so far voting is not a broadly used feature. As this relevance algorithm is very primitive ideas for improving it are very welcome. Write Preview @rodrigosiqueiramelo is that question for me? You can use @username to make direct questions. The 100 and 300 are just weights. When calculating the relevance score for a thread each reply is 3x stronger than a vote in the same thread. That's because the vote it's not for the thread but for an answer. In fact so far voting is not a broadly used feature. As this relevance algorithm is very primitive ideas for improving it are very welcome. Choose File ... File name... Cancel
182	186	self.subject_token,
183	187	self.message_set.count())
184	188
	189	+ def days_ago(self, date):
2		Link here Sergio Oliveira @seocam 2015-02-22 20:51:47 UTC I would define both days_ago and get_score as protected methods. It doesn't make sense to expose than as a model method: thread.days_ago(date)? thread.get_score(weight, created)? This is even confusing since it actually won't return thread.score. Write Preview I would define both days_ago and get_score as protected methods. It doesn't make sense to expose than as a model method: thread.days_ago(date)? thread.get_score(weight, created)? This is even confusing since it actually won't return thread.score. Choose File ... File name... Cancel Link here Carlos Coêlho @carlos 2015-02-22 21:40:39 UTC Understood, we'll change them into protected methods. Write Preview Understood, we'll change them into protected methods. Choose File ... File name... Cancel
8	8	"""
9	9
10	10	import os
	11	+from django.core.wsgi import get_wsgi_application
3		Link here Sergio Oliveira @seocam 2015-02-22 20:53:03 UTC Does that work? I believe django generates this file in that way for a reason. We must set settings before trying to import django stuff. Write Preview Does that work? I believe django generates this file in that way for a reason. We must set settings before trying to import django stuff. Choose File ... File name... Cancel Link here Carlos Coêlho @carlos 2015-02-22 21:34:25 UTC Maybe we'll need to add a flag to ignore these lines on both wsgi.py and settings.py, don't you think? We've changed them because the build was failing. Write Preview Maybe we'll need to add a flag to ignore these lines on both wsgi.py and settings.py, don't you think? We've changed them because the build was failing. Choose File ... File name... Cancel build_status.png Link here Sergio Oliveira @seocam 2015-02-23 14:39:42 UTC flake8 added the E402 and E731 recently. It also affected Django repo: https://github.com/django/django/commit/6e23c9be46a3ab74c39daba5ce344b818ac30608 Their solution was to ignore these errors (they already ignore other errors). Independent on the solution I believe we should deal with it in a different MR. Write Preview flake8 added the E402 and E731 recently. It also affected Django repo: https://github.com/django/django/commit/6e23c9be46a3ab74c39daba5ce344b818ac30608 Their solution was to ignore these errors (they already ignore other errors). Independent on the solution I believe we should deal with it in a different MR. Choose File ... File name... Cancel
256	258	SUPER_ARCHIVES_EXCLUDE = []
257	259	SUPER_ARCHIVES_LOCK_FILE = '/var/lock/colab/import_emails.lock'
258	260
259		-# Feedzilla (planet)
260		-from feedzilla.settings import * # noqa (flake8 ignore)
1		Link here Sergio Oliveira @seocam 2015-02-22 20:58:29 UTC ??? Why are you changing feedzilla stuff out-of feedzilla area? The settings are grouped by tool for making it easier to find/change it. Write Preview ??? Why are you changing feedzilla stuff out-of feedzilla area? The settings are grouped by tool for making it easier to find/change it. Choose File ... File name... Cancel