Software Público Brasileiro

@rodrigosiqueiramelo @carlospecter

Why are you initializing the same variable twice with the same value and no other change between the redefinitions?

Mailing receives a kwargs dict, there's no args list as function parameter.

Why not use address_list function instead of mailing_lists? It returns mailing_lists too, but it's only used once in the file.

Same here about the usage of address_lists.

Maybe those for loops can be refactored, since they are very similar.

Just an idea, we believe that the code would be more understandable if you change the name "Q" to something more specific. For example ...import Q as (better_name)...

It would be better if q1 and q2 had more meaningful names.

Why not try to validate name, because it'll return KeyError if it doesn't exist, or try to use the get method.

Is this supposed to be a tuple or str? If str, there's no meaning using the parenthesis else add a comma to the end of the str to tell it's a tuple.

Tip: try using a more meaningful name instead of ml.

ALL done.

97	102	return []
98	103
99	104	return users.json()
	105	+
	106	+
	107	+def get_user_mailinglists(user):
	108	+ lists_for_user = []
	109	+ emails = ''
	110	+
	111	+ if user:
	112	+ emails = user.emails.values_list('address', flat=True)
	113	+
	114	+ lists_for_user = []
1		Link here Carlos Coêlho @carlos 2015-03-06 12:55:47 UTC Why are you initializing the same variable twice with the same value and no other change between the redefinitions? Write Preview Why are you initializing the same variable twice with the same value and no other change between the redefinitions? Choose File ... File name... Cancel

64	65	return lists.json()
65	66
66	67
	68	+def is_private_list(name):
	69	+ return dict(all_lists(private=True))[name]
	70	+
	71	+
67	72	def all_lists(args, *kwargs):
68		- return address_lists('', args, *kwargs)
	73	+ return mailing_lists(args, *kwargs)
1		Link here Carlos Coêlho @carlos 2015-03-06 13:01:03 UTC Mailing receives a kwargs dict, there's no args list as function parameter. Write Preview Mailing receives a kwargs dict, there's no args list as function parameter. Choose File ... File name... Cancel

38	38
39	39
40	40	def update_subscription(address, lists):
41		- current_lists = address_lists(address)
	41	+ current_lists = mailing_lists(address=address)
1		Link here Carlos Coêlho @carlos 2015-03-06 13:03:19 UTC Why not use address_list function instead of mailing_lists? It returns mailing_lists too, but it's only used once in the file. Write Preview Why not use address_list function instead of mailing_lists? It returns mailing_lists too, but it's only used once in the file. Choose File ... File name... Cancel

66	67
	68	+def is_private_list(name):
	69	+ return dict(all_lists(private=True))[name]
	70	+
	71	+
67	72	def all_lists(args, *kwargs):
68		- return address_lists('', args, *kwargs)
	73	+ return mailing_lists(args, *kwargs)
69	74
70	75
71	76	def user_lists(user):
72	77	list_set = set()
73	78
74	79	for email in user.emails.values_list('address', flat=True):
75		- list_set.update(address_lists(email))
	80	+ list_set.update(mailing_lists(address=email))
1		Link here Carlos Coêlho @carlos 2015-03-06 13:03:47 UTC Same here about the usage of address_lists. Write Preview Same here about the usage of address_lists. Choose File ... File name... Cancel

	17	+ latest_threads = []
	18	+ lists_for_user = []
15	19
16		- latest_threads = Thread.objects.all()[:6]
	20	+ user = None
	21	+ if request.user.is_authenticated():
	22	+ user = User.objects.get(username=request.user)
	23	+ lists_for_user = mailman.get_user_mailinglists(user)
17	24
18		- latest_results, count_types = get_collaboration_data()
	25	+ for t in all_threads:
	26	+ if not t.mailinglist.is_private or \
	27	+ t.mailinglist.name in lists_for_user:
	28	+ latest_threads.append(t)
	29	+
	30	+ hottest_threads = []
1		Link here Carlos Coêlho @carlos 2015-03-06 14:43:34 UTC Maybe those for loops can be refactored, since they are very similar. Write Preview Maybe those for loops can be refactored, since they are very similar. Choose File ... File name... Cancel

Software Público Brasileiro

Merge Request #40

Private mailman lists

Merged by Sergio Oliveira 2015-03-09 21:08:13 UTC

6	6	from django.core.cache import cache
7	7	from django.utils.translation import ugettext as _
8	8	from django.conf import settings
	9	+from django.db.models import Q
1		Link here Carlos Coêlho @carlos 2015-03-06 14:48:00 UTC Just an idea, we believe that the code would be more understandable if you change the name "Q" to something more specific. For example ...import Q as (better_name)... Write Preview Just an idea, we believe that the code would be more understandable if you change the name "Q" to something more specific. For example ...import Q as (better_name)... Choose File ... File name... Cancel

79	79	return body.strip()
80	80
81	81	def get_received_datetime(self):
82		- if self not in ('Received'):
	82	+ if ('Received') not in self:
1		Link here Carlos Coêlho @carlos 2015-03-06 15:00:28 UTC Is this supposed to be a tuple or str? If str, there's no meaning using the parenthesis else add a comma to the end of the str to tell it's a tuple. Write Preview Is this supposed to be a tuple or str? If str, there's no meaning using the parenthesis else add a comma to the end of the str to tell it's a tuple. Choose File ... File name... Cancel

122	134	def get(self, request):
123	135	MAX = 6
124	136	context = {}
125		- all_lists = mailman.all_lists(description=True)
	137	+
	138	+ all_privates = {}
	139	+ private_mailinglist = MailingList.objects.filter(is_private=True)
	140	+ for ml in private_mailinglist:
1		Link here Carlos Coêlho @carlos 2015-03-06 15:08:34 UTC Tip: try using a more meaningful name instead of ml. Write Preview Tip: try using a more meaningful name instead of ml. Choose File ... File name... Cancel

Merge Request #40

How to merge

Private mailman lists

Merged by Sergio Oliveira 2015-03-09 21:08:13 UTC $('.time_ago').timeago().tooltip()

Merged by Sergio Oliveira 2015-03-09 21:08:13 UTC