Merge Request #89
← To merge requests
From
lock-proxy-imports
into
spb-release/3.0
Commits (2)
-
Signed-off-by: Sergio Oliveira <sergio@tracy.com.br>
-
Signed-off-by: Sergio Oliveira <sergio@tracy.com.br>
-
@seocam: lines 27 and 28 from import_proxy_data.py, when creating the lock file isn't it better to do it with a try-except wrapping it around? I learned that the default '/var/lock/colab' directory is created already here (https://portal.softwarepublico.gov.br/gitlab/softwarepublico/softwarepublico/blob/master/cookbooks/colab/recipes/default.rb#L31) so it's OK for now, but if the file changes, in the future, to some other file which colab user doesn't have writing rights then an OSError is raised.
-
Line 28 won't work because the script (as colab user) tries to create a directory "/var/lock", which belongs to root user.
-
Fixing this, i believe that everything is ok.
-
mentioned in commit a52454bb02d3909aa4731a29512d1ef12cd4bd63
started a discussion on commit
5bebd24b