Project has now correct owner and creator. Increased test coverage

Dmitriy Zaporozhets
1 parent 91995909
Showing 15 changed files with 241 additions and 113 deletions Show diff stats
app/controllers/dashboard_controller.rb
app/controllers/groups_controller.rb
app/models/project.rb
app/models/user.rb
app/roles/account.rb
app/roles/namespaced_project.rb
app/views/admin/projects/show.html.haml
app/views/dashboard/_groups.html.haml
db/migrate/20130102143055_rename_owner_to_creator_for_project.rb
db/schema.rb
spec/factories.rb
spec/models/project_security_spec.rb
spec/models/project_spec.rb
spec/models/user_spec.rb
spec/roles/account_role_spec.rb
@@ -20,7 +20,7 @@ class DashboardController &lt; ApplicationController
     @projects = @projects.page(params[:page]).per(30)
-    @events = Event.in_projects(current_user.project_ids)
+    @events = Event.in_projects(current_user.authorized_projects.pluck(:id))
     @events = @event_filter.apply_filter(@events)
     @events = @events.limit(20).offset(params[:offset] || 0)
@@ -70,7 +70,7 @@ class GroupsController &lt; ApplicationController
   end
   def projects
-    @projects ||= group.projects.authorized_for(current_user).sorted_by_activity
+    @projects ||= current_user.authorized_projects.where(namespace_id: group.id).sorted_by_activity
   end
   def project_ids
@@ -32,7 +32,7 @@ class Project &lt; ActiveRecord::Base
   attr_accessible :name, :path, :description, :default_branch, :issues_enabled,
                   :wall_enabled, :merge_requests_enabled, :wiki_enabled, as: [:default, :admin]
-  attr_accessible :namespace_id, :owner_id, as: :admin
+  attr_accessible :namespace_id, :creator_id, as: :admin
   attr_accessor :error_code
@@ -40,10 +40,10 @@ class Project &lt; ActiveRecord::Base
   belongs_to :group, foreign_key: "namespace_id", conditions: "type = 'Group'"
   belongs_to :namespace
-  # TODO: replace owner with creator.
-  # With namespaces a project owner will be a namespace owner
-  # so this field makes sense only for global projects
-  belongs_to :owner, class_name: "User"
+  belongs_to :creator,
+    class_name: "User",
+    foreign_key: "creator_id"
+
   has_many :users,          through: :users_projects
   has_many :events,         dependent: :destroy
   has_many :merge_requests, dependent: :destroy
@@ -62,7 +62,7 @@ class Project &lt; ActiveRecord::Base
   delegate :name, to: :owner, allow_nil: true, prefix: true
   # Validations
-  validates :owner, presence: true
+  validates :creator, presence: true
   validates :description, length: { within: 0..2000 }
   validates :name, presence: true, length: { within: 0..255 },
             format: { with: Gitlab::Regex.project_name_regex,
@@ -89,8 +89,7 @@ class Project &lt; ActiveRecord::Base
   class << self
     def authorized_for user
-      projects = includes(:users_projects, :namespace)
-      projects = projects.where("users_projects.user_id = :user_id or projects.owner_id = :user_id or namespaces.owner_id = :user_id", user_id: user.id)
+      raise "DERECATED"
     end
     def active
@@ -104,8 +103,10 @@ class Project &lt; ActiveRecord::Base
     def find_with_namespace(id)
       if id.include?("/")
         id = id.split("/")
-        namespace_id = Namespace.find_by_path(id.first).id
-        where(namespace_id: namespace_id).find_by_path(id.second)
+        namespace = Namespace.find_by_path(id.first)
+        return nil unless namespace
+
+        where(namespace_id: namespace.id).find_by_path(id.second)
       else
         where(path: id, namespace_id: nil).last
       end
@@ -125,7 +126,7 @@ class Project &lt; ActiveRecord::Base
         #
         project.path = project.name.dup.parameterize
-        project.owner = user
+        project.creator = user
         # Apply namespace if user has access to it
         # else fallback to user namespace
@@ -174,8 +175,8 @@ class Project &lt; ActiveRecord::Base
   end
   def check_limit
-    unless owner.can_create_project?
-      errors[:base] << ("Your own projects limit is #{owner.projects_limit}! Please contact administrator to increase it")
+    unless creator.can_create_project?
+      errors[:base] << ("Your own projects limit is #{creator.projects_limit}! Please contact administrator to increase it")
     end
   rescue
     errors[:base] << ("Can't check your ability to create project")
@@ -268,4 +269,12 @@ class Project &lt; ActiveRecord::Base
       Notify.project_was_moved_email(member.id).deliver
     end
   end
+
+  def owner
+    if namespace
+      namespace_owner
+    else
+      creator
+    end
+  end
 end
@@ -51,7 +51,6 @@ class User &lt; ActiveRecord::Base
   has_many :groups, class_name: "Group", foreign_key: :owner_id
   has_many :keys, dependent: :destroy
-  has_many :projects, through: :users_projects
   has_many :users_projects, dependent: :destroy
   has_many :issues, foreign_key: :author_id, dependent: :destroy
   has_many :notes, foreign_key: :author_id, dependent: :destroy
@@ -82,6 +81,9 @@ class User &lt; ActiveRecord::Base
   scope :active, where(blocked:  false)
   scope :alphabetically, order('name ASC')
+  #
+  # Class methods
+  #
   class << self
     def filter filter_name
       case filter_name
@@ -126,9 +128,63 @@ class User &lt; ActiveRecord::Base
     end
   end
+  #
+  # Instance methods
+  #
   def generate_password
     if self.force_random_password
       self.password = self.password_confirmation = Devise.friendly_token.first(8)
     end
   end
+
+
+  # Namespaces user has access to
+  def namespaces
+    namespaces = []
+
+    # Add user account namespace
+    namespaces << self.namespace if self.namespace
+
+    # Add groups you can manage
+    namespaces += if admin
+                    Group.all
+                  else
+                    groups.all
+                  end
+    namespaces
+  end
+
+  # Groups where user is an owner
+  def owned_groups
+    groups
+  end
+
+  # Groups user has access to
+  def authorized_groups
+    @authorized_groups ||= begin
+                           groups = Group.where(id: self.authorized_projects.pluck(:namespace_id)).all
+                           groups = groups + self.groups
+                           groups.uniq
+                         end
+  end
+
+
+  # Projects user has access to
+  def authorized_projects
+    project_ids = users_projects.pluck(:project_id)
+    project_ids = project_ids | owned_projects.pluck(:id)
+    Project.where(id: project_ids)
+  end
+
+  # Projects in user namespace
+  def personal_projects
+    Project.personal(self)
+  end
+
+  # Projects where user is an owner
+  def owned_projects
+    Project.where("(projects.namespace_id IN (:namespaces)) OR
+                  (projects.namespace_id IS NULL AND projects.creator_id = :user_id)",
+                  namespaces: namespaces.map(&:id), user_id: self.id)
+  end
 end
@@ -25,7 +25,7 @@ module Account
   end
   def can_create_project?
-    projects_limit > my_own_projects.count
+    projects_limit > personal_projects.count
   end
   def can_create_group?
@@ -56,10 +56,6 @@ module Account
     MergeRequest.where("author_id = :id or assignee_id = :id", id: self.id)
   end
-  def project_ids
-    projects.map(&:id)
-  end
-
   # Remove user from all projects and
   # set blocked attribute to true
   def block
@@ -86,22 +82,7 @@ module Account
   end
   def projects_sorted_by_activity
-    projects.sorted_by_activity
-  end
-
-  def namespaces
-    namespaces = []
-
-    # Add user account namespace
-    namespaces << self.namespace if self.namespace
-
-    # Add groups you can manage
-    namespaces += if admin
-                    Group.all
-                  else
-                    groups.all
-                  end
-    namespaces
+    authorized_projects.sorted_by_activity
   end
   def several_namespaces?
@@ -111,20 +92,4 @@ module Account
   def namespace_id
     namespace.try :id
   end
-
-  def authorized_groups
-    @authorized_groups ||= begin
-                           groups = Group.where(id: self.projects.pluck(:namespace_id)).all
-                           groups = groups + self.groups
-                           groups.uniq
-                         end
-  end
-
-  def authorized_projects
-    Project.authorized_for(self)
-  end
-
-  def my_own_projects
-    Project.personal(self)
-  end
 end
@@ -50,14 +50,6 @@ module NamespacedProject
     namespace.try(:owner)
   end
-  def chief
-    if namespace
-      namespace_owner
-    else
-      owner
-    end
-  end
-
   def path_with_namespace
     if namespace
       namespace.path + '/' + path
@@ -49,8 +49,8 @@
       %b
         Owned by:
     %td
-      - if @project.chief
-        = link_to @project.chief.name, admin_user_path(@project.chief)
+      - if @project.owner
+        = link_to @project.owner_name, admin_user_path(@project.owner)
       - else
         (deleted)
   %tr
@@ -58,7 +58,7 @@
       %b
         Created by:
     %td
-      = @project.owner_name || '(deleted)'
+      = @project.creator.try(:name) || '(deleted)'
   %tr
     %td
       %b
@@ -17,4 +17,4 @@
             &rarr;
           %span.last_activity
             %strong Projects:
-            %span= group.projects.authorized_for(current_user).count
+            %span= current_user.authorized_projects.where(namespace_id: group.id).count
@@ -0,0 +1,5 @@
+class RenameOwnerToCreatorForProject < ActiveRecord::Migration
+  def change
+    rename_column :projects, :owner_id, :creator_id
+  end
+end
@@ -11,7 +11,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
-ActiveRecord::Schema.define(:version => 20121219095402) do
+ActiveRecord::Schema.define(:version => 20130102143055) do
   create_table "events", :force => true do |t|
     t.string   "target_type"
@@ -148,7 +148,7 @@ ActiveRecord::Schema.define(:version =&gt; 20121219095402) do
     t.datetime "created_at",                               :null => false
     t.datetime "updated_at",                               :null => false
     t.boolean  "private_flag",           :default => true, :null => false
-    t.integer  "owner_id"
+    t.integer  "creator_id"
     t.string   "default_branch"
     t.boolean  "issues_enabled",         :default => true, :null => false
     t.boolean  "wall_enabled",           :default => true, :null => false
@@ -157,8 +157,8 @@ ActiveRecord::Schema.define(:version =&gt; 20121219095402) do
     t.integer  "namespace_id"
   end
+  add_index "projects", ["creator_id"], :name => "index_projects_on_owner_id"
   add_index "projects", ["namespace_id"], :name => "index_projects_on_namespace_id"
-  add_index "projects", ["owner_id"], :name => "index_projects_on_owner_id"
   create_table "protected_branches", :force => true do |t|
     t.integer  "project_id", :null => false
@@ -9,7 +9,7 @@ FactoryGirl.define do
   sequence(:url) { Faker::Internet.uri('http') }
-  factory :user, aliases: [:author, :assignee, :owner] do
+  factory :user, aliases: [:author, :assignee, :owner, :creator] do
     email { Faker::Internet.email }
     name
     username { Faker::Internet.user_name }
@@ -26,7 +26,7 @@ FactoryGirl.define do
   factory :project do
     sequence(:name) { |n| "project#{n}" }
     path { name.downcase.gsub(/\s/, '_') }
-    owner
+    creator
   end
   factory :group do
@@ -8,7 +8,7 @@ describe Project do
       @u1 = create(:user)
       @u2 = create(:user)
       @u3 = create(:user)
-      @u4 = @p1.chief
+      @u4 = @p1.owner
       @abilities = Six.new
       @abilities << Ability
@@ -24,7 +24,7 @@ describe Project do
   describe "Associations" do
     it { should belong_to(:group) }
     it { should belong_to(:namespace) }
-    it { should belong_to(:owner).class_name('User') }
+    it { should belong_to(:creator).class_name('User') }
     it { should have_many(:users) }
     it { should have_many(:events).dependent(:destroy) }
     it { should have_many(:merge_requests).dependent(:destroy) }
@@ -41,7 +41,7 @@ describe Project do
   describe "Mass assignment" do
     it { should_not allow_mass_assignment_of(:namespace_id) }
-    it { should_not allow_mass_assignment_of(:owner_id) }
+    it { should_not allow_mass_assignment_of(:creator_id) }
     it { should_not allow_mass_assignment_of(:private_flag) }
   end
@@ -55,20 +55,15 @@ describe Project do
     it { should validate_presence_of(:path) }
     it { should validate_uniqueness_of(:path) }
     it { should ensure_length_of(:path).is_within(0..255) }
-    # TODO: Formats
-
     it { should ensure_length_of(:description).is_within(0..2000) }
-
-    # TODO: Formats
-
-    it { should validate_presence_of(:owner) }
+    it { should validate_presence_of(:creator) }
     it { should ensure_inclusion_of(:issues_enabled).in_array([true, false]) }
     it { should ensure_inclusion_of(:wall_enabled).in_array([true, false]) }
     it { should ensure_inclusion_of(:merge_requests_enabled).in_array([true, false]) }
     it { should ensure_inclusion_of(:wiki_enabled).in_array([true, false]) }
     it "should not allow new projects beyond user limits" do
-      project.stub(:owner).and_return(double(can_create_project?: false, projects_limit: 1))
+      project.stub(:creator).and_return(double(can_create_project?: false, projects_limit: 1))
       project.should_not be_valid
       project.errors[:base].first.should match(/Your own projects limit is 1/)
     end
@@ -134,7 +129,7 @@ describe Project do
     it { should respond_to(:transfer) }
     it { should respond_to(:name_with_namespace) }
     it { should respond_to(:namespace_owner) }
-    it { should respond_to(:chief) }
+    it { should respond_to(:owner) }
     it { should respond_to(:path_with_namespace) }
   end
@@ -211,4 +206,75 @@ describe Project do
       @merge_request.last_commit.id.should == "bcf03b5de6c33f3869ef70d68cf06e679d1d7f9a"
     end
   end
+
+  describe :create_by_user do
+    before do
+      @user = create :user
+      @opts = {
+        name: "GitLab"
+      }
+    end
+
+    context 'user namespace' do
+      before do
+        @project = Project.create_by_user(@opts, @user)
+      end
+
+      it { @project.should be_valid }
+      it { @project.owner.should == @user }
+      it { @project.namespace.should == @user.namespace }
+    end
+
+    context 'user namespace' do
+      before do
+        @group = create :group, owner: @user
+        @opts.merge!(namespace_id: @group.id)
+        @project = Project.create_by_user(@opts, @user)
+      end
+
+      it { @project.should be_valid }
+      it { @project.owner.should == @user }
+      it { @project.namespace.should == @group }
+    end
+  end
+
+  describe :find_with_namespace do
+    context 'with namespace' do
+      before do
+        @group = create :group, name: 'gitlab'
+        @project = create(:project, name: 'gitlab-ci', namespace: @group)
+      end
+
+      it { Project.find_with_namespace('gitlab/gitlab-ci').should == @project }
+      it { Project.find_with_namespace('gitlab-ci').should be_nil }
+    end
+
+    context 'w/o namespace' do
+      before do
+        @project = create(:project, name: 'gitlab-ci')
+      end
+
+      it { Project.find_with_namespace('gitlab-ci').should == @project }
+      it { Project.find_with_namespace('gitlab/gitlab-ci').should be_nil }
+    end
+  end
+
+  describe :to_param do
+    context 'with namespace' do
+      before do
+        @group = create :group, name: 'gitlab'
+        @project = create(:project, name: 'gitlab-ci', namespace: @group)
+      end
+
+      it { @project.to_param.should == "gitlab/gitlab-ci" }
+    end
+
+    context 'w/o namespace' do
+      before do
+        @project = create(:project, name: 'gitlab-ci')
+      end
+
+      it { @project.to_param.should == "gitlab-ci" }
+    end
+  end
 end
@@ -39,7 +39,6 @@ describe User do
   describe "Associations" do
     it { should have_one(:namespace) }
     it { should have_many(:users_projects).dependent(:destroy) }
-    it { should have_many(:projects) }
     it { should have_many(:groups) }
     it { should have_many(:keys).dependent(:destroy) }
     it { should have_many(:events).class_name('Event').dependent(:destroy) }
@@ -119,4 +118,71 @@ describe User do
       user.authentication_token.should_not be_blank
     end
   end
+
+  describe 'projects' do
+    before do
+      ActiveRecord::Base.observers.enable(:user_observer)
+      @user = create :user
+      @project = create :project, namespace: @user.namespace
+    end
+
+    it { @user.authorized_projects.should include(@project) }
+    it { @user.owned_projects.should include(@project) }
+    it { @user.personal_projects.should include(@project) }
+  end
+
+  describe 'groups' do
+    before do
+      ActiveRecord::Base.observers.enable(:user_observer)
+      @user = create :user
+      @group = create :group, owner: @user
+    end
+
+    it { @user.several_namespaces?.should be_true }
+    it { @user.namespaces.should == [@user.namespace, @group] }
+    it { @user.authorized_groups.should == [@group] }
+    it { @user.owned_groups.should == [@group] }
+  end
+
+  describe 'namespaced' do
+    before do
+      ActiveRecord::Base.observers.enable(:user_observer)
+      @user = create :user
+      @project = create :project, namespace: @user.namespace
+    end
+
+    it { @user.several_namespaces?.should be_false }
+    it { @user.namespaces.should == [@user.namespace] }
+  end
+
+  describe 'blocking user' do
+    let(:user) { create(:user, name: 'John Smith') }
+
+    it "should block user" do
+      user.block
+      user.blocked.should be_true
+    end
+  end
+
+  describe 'filter' do
+    before do
+      @user = create :user
+      @admin = create :user, admin: true
+      @blocked = create :user, blocked: true
+    end
+
+    it { User.filter("admins").should == [@admin] }
+    it { User.filter("blocked").should == [@blocked] }
+    it { User.filter("wop").should == [@user, @admin, @blocked] }
+    it { User.filter(nil).should == [@user, @admin] }
+  end
+
+  describe :not_in_project do
+    before do
+      @user = create :user
+      @project = create :project
+    end
+
+    it { User.not_in_project(@project).should == [@user, @project.owner] }
+  end
 end
@@ -10,35 +10,4 @@ describe User, &quot;Account&quot; do
     it { user.can_create_project?.should be_true }
     it { user.first_name.should == 'John' }
   end
-
-  describe 'blocking user' do
-    let(:user) { create(:user, name: 'John Smith') }
-
-    it "should block user" do
-      user.block
-      user.blocked.should be_true
-    end
-  end
-
-  describe 'projects' do
-    before do
-      ActiveRecord::Base.observers.enable(:user_observer)
-      @user = create :user
-      @project = create :project, namespace: @user.namespace
-    end
-
-    it { @user.authorized_projects.should include(@project) }
-    it { @user.my_own_projects.should include(@project) }
-  end
-
-  describe 'namespaced' do
-    before do
-      ActiveRecord::Base.observers.enable(:user_observer)
-      @user = create :user
-      @project = create :project, namespace: @user.namespace
-    end
-
-    it { @user.several_namespaces?.should be_false }
-    it { @user.namespaces.should == [@user.namespace] }
-  end
 end
	@@ -20,7 +20,7 @@ class DashboardController < ApplicationController		@@ -20,7 +20,7 @@ class DashboardController < ApplicationController
20		20
21	@projects = @projects.page(params[:page]).per(30)	21	@projects = @projects.page(params[:page]).per(30)
22		22
23	- @events = Event.in_projects(current_user.project_ids)	23	+ @events = Event.in_projects(current_user.authorized_projects.pluck(:id))
24	@events = @event_filter.apply_filter(@events)	24	@events = @event_filter.apply_filter(@events)
25	@events = @events.limit(20).offset(params[:offset] \|\| 0)	25	@events = @events.limit(20).offset(params[:offset] \|\| 0)
26		26
	@@ -70,7 +70,7 @@ class GroupsController < ApplicationController		@@ -70,7 +70,7 @@ class GroupsController < ApplicationController
70	end	70	end
71		71
72	def projects	72	def projects
73	- @projects \|\|= group.projects.authorized_for(current_user).sorted_by_activity	73	+ @projects \|\|= current_user.authorized_projects.where(namespace_id: group.id).sorted_by_activity
74	end	74	end
75		75
76	def project_ids	76	def project_ids
	@@ -51,7 +51,6 @@ class User < ActiveRecord::Base		@@ -51,7 +51,6 @@ class User < ActiveRecord::Base
51	has_many :groups, class_name: "Group", foreign_key: :owner_id	51	has_many :groups, class_name: "Group", foreign_key: :owner_id
52		52
53	has_many :keys, dependent: :destroy	53	has_many :keys, dependent: :destroy
54	- has_many :projects, through: :users_projects
55	has_many :users_projects, dependent: :destroy	54	has_many :users_projects, dependent: :destroy
56	has_many :issues, foreign_key: :author_id, dependent: :destroy	55	has_many :issues, foreign_key: :author_id, dependent: :destroy
57	has_many :notes, foreign_key: :author_id, dependent: :destroy	56	has_many :notes, foreign_key: :author_id, dependent: :destroy
	@@ -82,6 +81,9 @@ class User < ActiveRecord::Base		@@ -82,6 +81,9 @@ class User < ActiveRecord::Base
82	scope :active, where(blocked: false)	81	scope :active, where(blocked: false)
83	scope :alphabetically, order('name ASC')	82	scope :alphabetically, order('name ASC')
84		83
		84	+ #
		85	+ # Class methods
		86	+ #
85	class << self	87	class << self
86	def filter filter_name	88	def filter filter_name
87	case filter_name	89	case filter_name
	@@ -126,9 +128,63 @@ class User < ActiveRecord::Base		@@ -126,9 +128,63 @@ class User < ActiveRecord::Base
126	end	128	end
127	end	129	end
128		130
		131	+ #
		132	+ # Instance methods
		133	+ #
129	def generate_password	134	def generate_password
130	if self.force_random_password	135	if self.force_random_password
131	self.password = self.password_confirmation = Devise.friendly_token.first(8)	136	self.password = self.password_confirmation = Devise.friendly_token.first(8)
132	end	137	end
133	end	138	end
		139	+
		140	+
		141	+ # Namespaces user has access to
		142	+ def namespaces
		143	+ namespaces = []
		144	+
		145	+ # Add user account namespace
		146	+ namespaces << self.namespace if self.namespace
		147	+
		148	+ # Add groups you can manage
		149	+ namespaces += if admin
		150	+ Group.all
		151	+ else
		152	+ groups.all
		153	+ end
		154	+ namespaces
		155	+ end
		156	+
		157	+ # Groups where user is an owner
		158	+ def owned_groups
		159	+ groups
		160	+ end
		161	+
		162	+ # Groups user has access to
		163	+ def authorized_groups
		164	+ @authorized_groups \|\|= begin
		165	+ groups = Group.where(id: self.authorized_projects.pluck(:namespace_id)).all
		166	+ groups = groups + self.groups
		167	+ groups.uniq
		168	+ end
		169	+ end
		170	+
		171	+
		172	+ # Projects user has access to
		173	+ def authorized_projects
		174	+ project_ids = users_projects.pluck(:project_id)
		175	+ project_ids = project_ids \| owned_projects.pluck(:id)
		176	+ Project.where(id: project_ids)
		177	+ end
		178	+
		179	+ # Projects in user namespace
		180	+ def personal_projects
		181	+ Project.personal(self)
		182	+ end
		183	+
		184	+ # Projects where user is an owner
		185	+ def owned_projects
		186	+ Project.where("(projects.namespace_id IN (:namespaces)) OR
		187	+ (projects.namespace_id IS NULL AND projects.creator_id = :user_id)",
		188	+ namespaces: namespaces.map(&:id), user_id: self.id)
		189	+ end
134	end	190	end
	@@ -25,7 +25,7 @@ module Account		@@ -25,7 +25,7 @@ module Account
25	end	25	end
26		26
27	def can_create_project?	27	def can_create_project?
28	- projects_limit > my_own_projects.count	28	+ projects_limit > personal_projects.count
29	end	29	end
30		30
31	def can_create_group?	31	def can_create_group?
	@@ -56,10 +56,6 @@ module Account		@@ -56,10 +56,6 @@ module Account
56	MergeRequest.where("author_id = :id or assignee_id = :id", id: self.id)	56	MergeRequest.where("author_id = :id or assignee_id = :id", id: self.id)
57	end	57	end
58		58
59	- def project_ids
60	- projects.map(&:id)
61	- end
62	-
63	# Remove user from all projects and	59	# Remove user from all projects and
64	# set blocked attribute to true	60	# set blocked attribute to true
65	def block	61	def block
	@@ -86,22 +82,7 @@ module Account		@@ -86,22 +82,7 @@ module Account
86	end	82	end
87		83
88	def projects_sorted_by_activity	84	def projects_sorted_by_activity
89	- projects.sorted_by_activity
90	- end
91	-
92	- def namespaces
93	- namespaces = []
94	-
95	- # Add user account namespace
96	- namespaces << self.namespace if self.namespace
97	-
98	- # Add groups you can manage
99	- namespaces += if admin
100	- Group.all
101	- else
102	- groups.all
103	- end
104	- namespaces	85	+ authorized_projects.sorted_by_activity
105	end	86	end
106		87
107	def several_namespaces?	88	def several_namespaces?
	@@ -111,20 +92,4 @@ module Account		@@ -111,20 +92,4 @@ module Account
111	def namespace_id	92	def namespace_id
112	namespace.try :id	93	namespace.try :id
113	end	94	end
114	-
115	- def authorized_groups
116	- @authorized_groups \|\|= begin
117	- groups = Group.where(id: self.projects.pluck(:namespace_id)).all
118	- groups = groups + self.groups
119	- groups.uniq
120	- end
121	- end
122	-
123	- def authorized_projects
124	- Project.authorized_for(self)
125	- end
126	-
127	- def my_own_projects
128	- Project.personal(self)
129	- end
130	end	95	end
	@@ -50,14 +50,6 @@ module NamespacedProject		@@ -50,14 +50,6 @@ module NamespacedProject
50	namespace.try(:owner)	50	namespace.try(:owner)
51	end	51	end
52		52
53	- def chief
54	- if namespace
55	- namespace_owner
56	- else
57	- owner
58	- end
59	- end
60	-
61	def path_with_namespace	53	def path_with_namespace
62	if namespace	54	if namespace
63	namespace.path + '/' + path	55	namespace.path + '/' + path
	@@ -17,4 +17,4 @@		@@ -17,4 +17,4 @@
17	→	17	→
18	%span.last_activity	18	%span.last_activity
19	%strong Projects:	19	%strong Projects:
20	- %span= group.projects.authorized_for(current_user).count	20	+ %span= current_user.authorized_projects.where(namespace_id: group.id).count
@@ -0,0 +1,5 @@		@@ -0,0 +1,5 @@
	1	+class RenameOwnerToCreatorForProject < ActiveRecord::Migration
	2	+ def change
	3	+ rename_column :projects, :owner_id, :creator_id
	4	+ end
	5	+end
	@@ -9,7 +9,7 @@ FactoryGirl.define do		@@ -9,7 +9,7 @@ FactoryGirl.define do
9		9
10	sequence(:url) { Faker::Internet.uri('http') }	10	sequence(:url) { Faker::Internet.uri('http') }
11		11
12	- factory :user, aliases: [:author, :assignee, :owner] do	12	+ factory :user, aliases: [:author, :assignee, :owner, :creator] do
13	email { Faker::Internet.email }	13	email { Faker::Internet.email }
14	name	14	name
15	username { Faker::Internet.user_name }	15	username { Faker::Internet.user_name }
	@@ -26,7 +26,7 @@ FactoryGirl.define do		@@ -26,7 +26,7 @@ FactoryGirl.define do
26	factory :project do	26	factory :project do
27	sequence(:name) { \|n\| "project#{n}" }	27	sequence(:name) { \|n\| "project#{n}" }
28	path { name.downcase.gsub(/\s/, '_') }	28	path { name.downcase.gsub(/\s/, '_') }
29	- owner	29	+ creator
30	end	30	end
31		31
32	factory :group do	32	factory :group do
	@@ -8,7 +8,7 @@ describe Project do		@@ -8,7 +8,7 @@ describe Project do
8	@u1 = create(:user)	8	@u1 = create(:user)
9	@u2 = create(:user)	9	@u2 = create(:user)
10	@u3 = create(:user)	10	@u3 = create(:user)
11	- @u4 = @p1.chief	11	+ @u4 = @p1.owner
12		12
13	@abilities = Six.new	13	@abilities = Six.new
14	@abilities << Ability	14	@abilities << Ability
	@@ -24,7 +24,7 @@ describe Project do		@@ -24,7 +24,7 @@ describe Project do
24	describe "Associations" do	24	describe "Associations" do
25	it { should belong_to(:group) }	25	it { should belong_to(:group) }
26	it { should belong_to(:namespace) }	26	it { should belong_to(:namespace) }
27	- it { should belong_to(:owner).class_name('User') }	27	+ it { should belong_to(:creator).class_name('User') }
28	it { should have_many(:users) }	28	it { should have_many(:users) }
29	it { should have_many(:events).dependent(:destroy) }	29	it { should have_many(:events).dependent(:destroy) }
30	it { should have_many(:merge_requests).dependent(:destroy) }	30	it { should have_many(:merge_requests).dependent(:destroy) }
	@@ -41,7 +41,7 @@ describe Project do		@@ -41,7 +41,7 @@ describe Project do
41		41
42	describe "Mass assignment" do	42	describe "Mass assignment" do
43	it { should_not allow_mass_assignment_of(:namespace_id) }	43	it { should_not allow_mass_assignment_of(:namespace_id) }
44	- it { should_not allow_mass_assignment_of(:owner_id) }	44	+ it { should_not allow_mass_assignment_of(:creator_id) }
45	it { should_not allow_mass_assignment_of(:private_flag) }	45	it { should_not allow_mass_assignment_of(:private_flag) }
46	end	46	end
47		47
	@@ -55,20 +55,15 @@ describe Project do		@@ -55,20 +55,15 @@ describe Project do
55	it { should validate_presence_of(:path) }	55	it { should validate_presence_of(:path) }
56	it { should validate_uniqueness_of(:path) }	56	it { should validate_uniqueness_of(:path) }
57	it { should ensure_length_of(:path).is_within(0..255) }	57	it { should ensure_length_of(:path).is_within(0..255) }
58	- # TODO: Formats
59	-
60	it { should ensure_length_of(:description).is_within(0..2000) }	58	it { should ensure_length_of(:description).is_within(0..2000) }
61	-
62	- # TODO: Formats
63	-
64	- it { should validate_presence_of(:owner) }	59	+ it { should validate_presence_of(:creator) }
65	it { should ensure_inclusion_of(:issues_enabled).in_array([true, false]) }	60	it { should ensure_inclusion_of(:issues_enabled).in_array([true, false]) }
66	it { should ensure_inclusion_of(:wall_enabled).in_array([true, false]) }	61	it { should ensure_inclusion_of(:wall_enabled).in_array([true, false]) }
67	it { should ensure_inclusion_of(:merge_requests_enabled).in_array([true, false]) }	62	it { should ensure_inclusion_of(:merge_requests_enabled).in_array([true, false]) }
68	it { should ensure_inclusion_of(:wiki_enabled).in_array([true, false]) }	63	it { should ensure_inclusion_of(:wiki_enabled).in_array([true, false]) }
69		64
70	it "should not allow new projects beyond user limits" do	65	it "should not allow new projects beyond user limits" do
71	- project.stub(:owner).and_return(double(can_create_project?: false, projects_limit: 1))	66	+ project.stub(:creator).and_return(double(can_create_project?: false, projects_limit: 1))
72	project.should_not be_valid	67	project.should_not be_valid
73	project.errors[:base].first.should match(/Your own projects limit is 1/)	68	project.errors[:base].first.should match(/Your own projects limit is 1/)
74	end	69	end
	@@ -134,7 +129,7 @@ describe Project do		@@ -134,7 +129,7 @@ describe Project do
134	it { should respond_to(:transfer) }	129	it { should respond_to(:transfer) }
135	it { should respond_to(:name_with_namespace) }	130	it { should respond_to(:name_with_namespace) }
136	it { should respond_to(:namespace_owner) }	131	it { should respond_to(:namespace_owner) }
137	- it { should respond_to(:chief) }	132	+ it { should respond_to(:owner) }
138	it { should respond_to(:path_with_namespace) }	133	it { should respond_to(:path_with_namespace) }
139	end	134	end
140		135
	@@ -211,4 +206,75 @@ describe Project do		@@ -211,4 +206,75 @@ describe Project do
211	@merge_request.last_commit.id.should == "bcf03b5de6c33f3869ef70d68cf06e679d1d7f9a"	206	@merge_request.last_commit.id.should == "bcf03b5de6c33f3869ef70d68cf06e679d1d7f9a"
212	end	207	end
213	end	208	end
		209	+
		210	+ describe :create_by_user do
		211	+ before do
		212	+ @user = create :user
		213	+ @opts = {
		214	+ name: "GitLab"
		215	+ }
		216	+ end
		217	+
		218	+ context 'user namespace' do
		219	+ before do
		220	+ @project = Project.create_by_user(@opts, @user)
		221	+ end
		222	+
		223	+ it { @project.should be_valid }
		224	+ it { @project.owner.should == @user }
		225	+ it { @project.namespace.should == @user.namespace }
		226	+ end
		227	+
		228	+ context 'user namespace' do
		229	+ before do
		230	+ @group = create :group, owner: @user
		231	+ @opts.merge!(namespace_id: @group.id)
		232	+ @project = Project.create_by_user(@opts, @user)
		233	+ end
		234	+
		235	+ it { @project.should be_valid }
		236	+ it { @project.owner.should == @user }
		237	+ it { @project.namespace.should == @group }
		238	+ end
		239	+ end
		240	+
		241	+ describe :find_with_namespace do
		242	+ context 'with namespace' do
		243	+ before do
		244	+ @group = create :group, name: 'gitlab'
		245	+ @project = create(:project, name: 'gitlab-ci', namespace: @group)
		246	+ end
		247	+
		248	+ it { Project.find_with_namespace('gitlab/gitlab-ci').should == @project }
		249	+ it { Project.find_with_namespace('gitlab-ci').should be_nil }
		250	+ end
		251	+
		252	+ context 'w/o namespace' do
		253	+ before do
		254	+ @project = create(:project, name: 'gitlab-ci')
		255	+ end
		256	+
		257	+ it { Project.find_with_namespace('gitlab-ci').should == @project }
		258	+ it { Project.find_with_namespace('gitlab/gitlab-ci').should be_nil }
		259	+ end
		260	+ end
		261	+
		262	+ describe :to_param do
		263	+ context 'with namespace' do
		264	+ before do
		265	+ @group = create :group, name: 'gitlab'
		266	+ @project = create(:project, name: 'gitlab-ci', namespace: @group)
		267	+ end
		268	+
		269	+ it { @project.to_param.should == "gitlab/gitlab-ci" }
		270	+ end
		271	+
		272	+ context 'w/o namespace' do
		273	+ before do
		274	+ @project = create(:project, name: 'gitlab-ci')
		275	+ end
		276	+
		277	+ it { @project.to_param.should == "gitlab-ci" }
		278	+ end
		279	+ end
214	end	280	end