Clean up conditional statement in `name` method.

Reverse the conditional order to avoid awkward `if !` construction.

Clean up conditional statement in `name` method.
Reverse the conditional order to avoid awkward `if !` construction.
C. Morgan Hamill
1 parent a45f7262
Showing 1 changed file with 3 additions and 3 deletions Show diff stats
lib/gitlab/oauth/user.rb
@@ -65,10 +65,10 @@ module Gitlab
         end
  
         def name
-          if !auth.info.name.nil?
-            auth.info.name.to_s.force_encoding('utf-8')
-          else
+          if auth.info.name.nil?
             "#{auth.info.first_name} #{auth.info.last_name}".force_encoding('utf-8')
+          else
+            auth.info.name.to_s.force_encoding('utf-8')
           end
         end
...	...	@@ -65,10 +65,10 @@ module Gitlab
65	65	end
66	66
67	67	def name
68		- if !auth.info.name.nil?
69		- auth.info.name.to_s.force_encoding('utf-8')
70		- else
	68	+ if auth.info.name.nil?
71	69	"#{auth.info.first_name} #{auth.info.last_name}".force_encoding('utf-8')
	70	+ else
	71	+ auth.info.name.to_s.force_encoding('utf-8')
72	72	end
73	73	end
74	74
...	...