Prevent a lot of sql queries for ProjectTeam#fetch_members method

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Prevent a lot of sql queries for ProjectTeam#fetch_members method
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Dmitriy Zaporozhets
1 parent ec8d3989
Showing 1 changed file with 4 additions and 1 deletions Show diff stats
app/models/project_team.rb
@@ -144,7 +144,10 @@ class ProjectTeam
       group_members = group_members.send(level) if group
     end
  
-    (project_members + group_members).map(&:user).uniq
+    user_ids = project_members.pluck(:user_id)
+    user_ids += group_members.pluck(:user_id) if group
+
+    User.where(id: user_ids)
   end
  
   def group
...	...	@@ -144,7 +144,10 @@ class ProjectTeam
144	144	group_members = group_members.send(level) if group
145	145	end
146	146
147		- (project_members + group_members).map(&:user).uniq
	147	+ user_ids = project_members.pluck(:user_id)
	148	+ user_ids += group_members.pluck(:user_id) if group
	149	+
	150	+ User.where(id: user_ids)
148	151	end
149	152
150	153	def group
...	...