Move locking from Satellite::Action to Satellite and add checks

Riyad Preukschas
1 parent 0e9d4f30
Showing 2 changed files with 27 additions and 22 deletions Show diff stats
lib/gitlab/satellite/action.rb
lib/gitlab/satellite/satellite.rb
@@ -18,18 +18,8 @@ module Gitlab
       # * Yields the prepared satellite repo
       def in_locked_and_timed_satellite
         Grit::Git.with_timeout(options[:git_timeout]) do
-          File.open(lock_file, "w+") do |f|
-            f.flock(File::LOCK_EX)
-
-            unless project.satellite.exists?
-              raise "Satellite doesn't exist"
-            end
-
-            Dir.chdir(project.satellite.path) do
-              repo = Grit::Repo.new('.')
-
-              return yield repo
-            end
+          project.satellite.lock do
+            return yield project.satellite.repo
           end
         end
       rescue Errno::ENOMEM => ex
@@ -40,10 +30,6 @@ module Gitlab
         return false
       end
-      def lock_file
-        Rails.root.join("tmp", "#{project.path}.lock")
-      end
-
       # * Clears the satellite
       # * Updates the satellite from Gitolite
       # * Sets up Git variables for the user
@@ -10,6 +10,8 @@ module Gitlab
       end
       def clear_and_update!
+        raise "Satellite doesn't exist" unless exists?
+
         delete_heads!
         clear_working_dir!
         update_from_source!
@@ -23,10 +25,31 @@ module Gitlab
         File.exists? path
       end
+      # Locks the satellite and yields
+      def lock
+        raise "Satellite doesn't exist" unless exists?
+
+        File.open(lock_file, "w+") do |f|
+          f.flock(File::LOCK_EX)
+
+          return yield
+        end
+      end
+
+      def lock_file
+        Rails.root.join("tmp", "#{project.path}.lock")
+      end
+
       def path
         Rails.root.join("tmp", "repo_satellites", project.path)
       end
+      def repo
+        raise "Satellite doesn't exist" unless exists?
+
+        @repo ||= Grit::Repo.new(path)
+      end
+
       private
       # Clear the working directory
@@ -39,7 +62,7 @@ module Gitlab
       # This ensures we have no name clashes or issues updating branches when
       # working with the satellite.
       def delete_heads!
-        heads = repo.heads.map{|head| head.name}
+        heads = repo.heads.map(&:name)
         # update or create the parking branch
         if heads.include? PARKING_BRANCH
@@ -54,15 +77,11 @@ module Gitlab
         heads.each { |head| repo.git.branch({D: true}, head) }
       end
-      def repo
-        @repo ||= Grit::Repo.new(path)
-      end
-
       # Updates the satellite from Gitolite
       #
       # Note: this will only update remote branches (i.e. origin/*)
       def update_from_source!
-        repo.git.fetch({}, :origin)
+        repo.git.fetch({timeout: true}, :origin)
       end
     end
   end
	@@ -18,18 +18,8 @@ module Gitlab		@@ -18,18 +18,8 @@ module Gitlab
18	# * Yields the prepared satellite repo	18	# * Yields the prepared satellite repo
19	def in_locked_and_timed_satellite	19	def in_locked_and_timed_satellite
20	Grit::Git.with_timeout(options[:git_timeout]) do	20	Grit::Git.with_timeout(options[:git_timeout]) do
21	- File.open(lock_file, "w+") do \|f\|
22	- f.flock(File::LOCK_EX)
23	-
24	- unless project.satellite.exists?
25	- raise "Satellite doesn't exist"
26	- end
27	-
28	- Dir.chdir(project.satellite.path) do
29	- repo = Grit::Repo.new('.')
30	-
31	- return yield repo
32	- end	21	+ project.satellite.lock do
		22	+ return yield project.satellite.repo
33	end	23	end
34	end	24	end
35	rescue Errno::ENOMEM => ex	25	rescue Errno::ENOMEM => ex
	@@ -40,10 +30,6 @@ module Gitlab		@@ -40,10 +30,6 @@ module Gitlab
40	return false	30	return false
41	end	31	end
42		32
43	- def lock_file
44	- Rails.root.join("tmp", "#{project.path}.lock")
45	- end
46	-
47	# * Clears the satellite	33	# * Clears the satellite
48	# * Updates the satellite from Gitolite	34	# * Updates the satellite from Gitolite
49	# * Sets up Git variables for the user	35	# * Sets up Git variables for the user