Merge branch 'master-create-group-projects' into 'master'

Master can create group projects It also includes Project transfer refactoring Fixes #1284

Merge branch 'master-create-group-projects' into 'master'
Master can create group projects It also includes Project transfer refactoring Fixes #1284
Dmitriy Zaporozhets
2 parents 64b1956b cea0fc1d
Showing 16 changed files with 116 additions and 200 deletions Show diff stats
app/controllers/projects_controller.rb
app/helpers/namespaces_helper.rb
app/models/ability.rb
app/models/group.rb
app/models/project.rb
app/models/user.rb
app/services/project_transfer_service.rb
app/services/projects/create_service.rb
app/services/projects/transfer_service.rb
app/views/groups/_projects.html.haml
doc/permissions/permissions.md
lib/api/groups.rb
lib/tasks/gitlab/enable_namespaces.rake
spec/models/project_spec.rb
spec/requests/api/groups_spec.rb
spec/services/projects/transfer_service_spec.rb
@@ -46,7 +46,7 @@ class ProjectsController &lt; ApplicationController
   end
   def transfer
-    ::Projects::TransferService.new(project, current_user, params).execute
+    ::Projects::TransferService.new(project, current_user, params[:project]).execute
   end
   def show
 module NamespacesHelper
   def namespaces_options(selected = :current_user, scope = :default)
-    groups = current_user.owned_groups
+    groups = current_user.owned_groups + current_user.masters_groups
     users = [current_user.namespace]
     group_opts = ["Groups", groups.sort_by(&:human_name).map {|g| [g.human_name, g.id]} ]
@@ -188,6 +188,13 @@ class Ability
         rules << :read_group
       end
+      # Only group masters and group owners can create new projects in group
+      if group.has_master?(user) || group.has_owner?(user) || user.admin?
+        rules += [
+          :create_projects,
+        ]
+      end
+
       # Only group owner and administrators can manage group
       if group.has_owner?(user) || user.admin?
         rules += [
@@ -205,6 +212,7 @@ class Ability
       # Only namespace owner and administrators can manage it
       if namespace.owner == user || user.admin?
         rules += [
+          :create_projects,
           :manage_namespace
         ]
       end
@@ -26,7 +26,7 @@ class Group &lt; Namespace
   validates :avatar, file_size: { maximum: 100.kilobytes.to_i }
   mount_uploader :avatar, AttachmentUploader
-  
+
   def self.accessible_to(user)
     accessible_ids = Project.accessible_to(user).pluck(:namespace_id)
     accessible_ids += user.groups.pluck(:id) if user
@@ -60,6 +60,10 @@ class Group &lt; Namespace
     owners.include?(user)
   end
+  def has_master?(user)
+    members.masters.where(user_id: user).any?
+  end
+
   def last_owner?(user)
     has_owner?(user) && owners.size == 1
   end
@@ -387,10 +387,6 @@ class Project &lt; ActiveRecord::Base
     end
   end
-  def transfer(new_namespace)
-    ProjectTransferService.new.transfer(self, new_namespace)
-  end
-
   def execute_hooks(data, hooks_scope = :push_hooks)
     hooks.send(hooks_scope).each do |hook|
       hook.async_execute(data)
@@ -90,6 +90,8 @@ class User &lt; ActiveRecord::Base
   has_many :users_groups, dependent: :destroy
   has_many :groups, through: :users_groups
   has_many :owned_groups, -> { where users_groups: { group_access: UsersGroup::OWNER } }, through: :users_groups, source: :group
+  has_many :masters_groups, -> { where users_groups: { group_access: UsersGroup::MASTER } }, through: :users_groups, source: :group
+
   # Projects
   has_many :groups_projects,          through: :groups, source: :projects
   has_many :personal_projects,        through: :namespace, source: :projects
@@ -1,46 +0,0 @@
-# ProjectTransferService class
-#
-# Used for transfer project to another namespace
-#
-class ProjectTransferService
-  include Gitlab::ShellAdapter
-
-  class TransferError < StandardError; end
-
-  attr_accessor :project
-
-  def transfer(project, new_namespace)
-    Project.transaction do
-      old_path = project.path_with_namespace
-      new_path = File.join(new_namespace.try(:path) || '', project.path)
-
-      if Project.where(path: project.path, namespace_id: new_namespace.try(:id)).present?
-        raise TransferError.new("Project with same path in target namespace already exists")
-      end
-
-      # Remove old satellite
-      project.satellite.destroy
-
-      # Apply new namespace id
-      project.namespace = new_namespace
-      project.save!
-
-      # Move main repository
-      unless gitlab_shell.mv_repository(old_path, new_path)
-        raise TransferError.new('Cannot move project')
-      end
-
-      # Move wiki repo also if present
-      gitlab_shell.mv_repository("#{old_path}.wiki", "#{new_path}.wiki")
-
-      # Create a new satellite (reload project from DB)
-      Project.find(project.id).ensure_satellite_exists
-
-      # clear project cached events
-      project.reset_events_cache
-
-      true
-    end
-  end
-end
-
@@ -97,7 +97,7 @@ module Projects
     def allowed_namespace?(user, namespace_id)
       namespace = Namespace.find_by(id: namespace_id)
-      current_user.can?(:manage_namespace, namespace)
+      current_user.can?(:create_projects, namespace)
     end
   end
 end
+# Projects::TransferService class
+#
+# Used for transfer project to another namespace
+#
+# Ex.
+#   # Move projects to namespace with ID 17 by user
+#   Projects::TransferService.new(project, user, namespace_id: 17).execute
+#
 module Projects
   class TransferService < BaseService
-    def execute(role = :default)
-      namespace_id = params[:project].delete(:namespace_id)
-      allowed_transfer = can?(current_user, :change_namespace, project) || role == :admin
-
-      if allowed_transfer && namespace_id.present?
-        if namespace_id.to_i != project.namespace_id
-          # Transfer to someone namespace
-          namespace = Namespace.find(namespace_id)
-          project.transfer(namespace)
-        end
-      end
+    include Gitlab::ShellAdapter
+    class TransferError < StandardError; end
+
+    def execute
+      namespace_id = params.delete(:namespace_id)
+      namespace = Namespace.find_by(id: namespace_id)
-    rescue ProjectTransferService::TransferError => ex
+      if allowed_transfer?(current_user, project, namespace)
+        transfer(project, namespace)
+      else
+        project.errors.add(:namespace, 'is invalid')
+        false
+      end
+    rescue Projects::TransferService::TransferError => ex
       project.reload
       project.errors.add(:namespace_id, ex.message)
       false
     end
+
+    def transfer(project, new_namespace)
+      Project.transaction do
+        old_path = project.path_with_namespace
+        new_path = File.join(new_namespace.try(:path) || '', project.path)
+
+        if Project.where(path: project.path, namespace_id: new_namespace.try(:id)).present?
+          raise TransferError.new("Project with same path in target namespace already exists")
+        end
+
+        # Remove old satellite
+        project.satellite.destroy
+
+        # Apply new namespace id
+        project.namespace = new_namespace
+        project.save!
+
+        # Move main repository
+        unless gitlab_shell.mv_repository(old_path, new_path)
+          raise TransferError.new('Cannot move project')
+        end
+
+        # Move wiki repo also if present
+        gitlab_shell.mv_repository("#{old_path}.wiki", "#{new_path}.wiki")
+
+        # Create a new satellite (reload project from DB)
+        Project.find(project.id).ensure_satellite_exists
+
+        # clear project cached events
+        project.reset_events_cache
+
+        true
+      end
+    end
+
+    def allowed_transfer?(current_user, project, namespace)
+      namespace &&
+        can?(current_user, :change_namespace, project) &&
+        namespace.id != project.namespace_id &&
+        current_user.can?(:create_projects, namespace)
+    end
   end
 end
-
 .ui-box
   .title
     Projects (#{projects.count})
-    - if can? current_user, :manage_group, @group
+    - if can? current_user, :create_projects, @group
       %span.pull-right
         = link_to new_project_path(namespace_id: @group.id), class: "btn btn-new" do
           %i.icon-plus
@@ -40,7 +40,7 @@ If a user is a GitLab administrator they receive all permissions.
 |------|-----|--------|---------|------|-----|
 |Browse group|✓|✓|✓|✓|✓|
 |Edit group|||||✓|
-|Create project in group|||||✓|
+|Create project in group||||✓|✓|
 |Manage group members|||||✓|
 |Remove group|||||✓|
@@ -87,10 +87,12 @@ module API
       #   POST /groups/:id/projects/:project_id
       post ":id/projects/:project_id" do
         authenticated_as_admin!
-        @group = Group.find(params[:id])
+        group = Group.find(params[:id])
         project = Project.find(params[:project_id])
-        if project.transfer(@group)
-          present @group
+        result = ::Projects::TransferService.new(project, current_user, namespace_id: group.id).execute
+
+        if result
+          present group
         else
           not_found!
         end
@@ -1,111 +0,0 @@
-namespace :gitlab do
-  desc "GITLAB | Enable usernames and namespaces for user projects"
-  task enable_namespaces: :environment do
-    warn_user_is_not_gitlab
-
-    migrate_user_namespaces
-    migrate_groups
-    migrate_projects
-  end
-
-  def migrate_user_namespaces
-    puts "\nGenerate usernames for users without one: ".blue
-    User.find_each(batch_size: 500) do |user|
-      if user.namespace
-        print '-'.cyan
-        next
-      end
-
-      username = if user.username.present?
-                   # if user already has username filled
-                   user.username
-                 else
-                   build_username(user)
-                 end
-
-      begin
-        User.transaction do
-          user.update_attributes!(username: username)
-          print '.'.green
-        end
-      rescue
-        print 'F'.red
-      end
-    end
-    puts "\nDone"
-  end
-
-  def build_username(user)
-    username = nil
-
-    # generate username
-    username = user.email.match(/^[^@]*/)[0]
-    username.gsub!("+", ".")
-
-    # return username if no matches
-    return username unless User.find_by(username: username)
-
-    # look for same username
-    (1..10).each do |i|
-      suffixed_username = "#{username}#{i}"
-
-      return suffixed_username unless User.find_by(username: suffixed_username)
-    end
-  end
-
-  def migrate_groups
-    puts "\nCreate directories for groups: ".blue
-
-    Group.find_each(batch_size: 500) do |group|
-      begin
-        if group.dir_exists?
-          print '-'.cyan
-        else
-          if group.ensure_dir_exist
-            print '.'.green
-          else
-            print 'F'.red
-          end
-        end
-      rescue
-        print 'F'.red
-      end
-    end
-    puts "\nDone"
-  end
-
-  def migrate_projects
-    git_path = Gitlab.config.gitlab_shell.repos_path
-    puts "\nMove projects in groups into respective directories ... ".blue
-    Project.where('namespace_id IS NOT NULL').find_each(batch_size: 500) do |project|
-      next unless project.group
-
-      group = project.group
-
-      print "#{project.name_with_namespace.yellow} ... "
-
-      new_path = File.join(git_path, project.path_with_namespace + '.git')
-
-      if File.exists?(new_path)
-        puts "already at #{new_path}".green
-        next
-      end
-
-      old_path = File.join(git_path, project.path + '.git')
-
-      unless File.exists?(old_path)
-        puts "couldn't find it at #{old_path}".red
-        next
-      end
-
-      begin
-        project.transfer(group.path)
-        puts "moved to #{new_path}".green
-      rescue
-        puts "failed moving to #{new_path}".red
-      end
-    end
-
-    puts "\nDone"
-  end
-end
@@ -84,7 +84,6 @@ describe Project do
     it { should respond_to(:satellite) }
     it { should respond_to(:update_merge_requests) }
     it { should respond_to(:execute_hooks) }
-    it { should respond_to(:transfer) }
     it { should respond_to(:name_with_namespace) }
     it { should respond_to(:owner) }
     it { should respond_to(:path_with_namespace) }
@@ -147,7 +147,7 @@ describe API::API, api: true  do
   describe "POST /groups/:id/projects/:project_id" do
     let(:project) { create(:project) }
     before(:each) do
-      project.stub(:transfer).and_return(true)
+      Projects::TransferService.any_instance.stub(execute: true)
       Project.stub(:find).and_return(project)
     end
@@ -160,8 +160,8 @@ describe API::API, api: true  do
     context "when authenticated as admin" do
       it "should transfer project to group" do
-        project.should_receive(:transfer)
         post api("/groups/#{group1.id}/projects/#{project.id}", admin)
+        response.status.should == 201
       end
     end
   end
 require 'spec_helper'
-describe ProjectTransferService do
+describe Projects::TransferService do
   before(:each) { enable_observers }
   after(:each) {disable_observers}
-  context 'namespace -> namespace' do
-    let(:user) { create(:user) }
-    let(:group) { create(:group) }
-    let(:project) { create(:project, namespace: user.namespace) }
+  let(:user) { create(:user) }
+  let(:group) { create(:group) }
+  let(:group2) { create(:group) }
+  let(:project) { create(:project, namespace: user.namespace) }
+  context 'namespace -> namespace' do
     before do
-      @result = service.transfer(project, group)
+      group.add_owner(user)
+      @service = Projects::TransferService.new(project, user, namespace_id: group.id)
+      @service.gitlab_shell.stub(mv_repository: true)
+      @result = @service.execute
     end
     it { @result.should be_true }
@@ -18,16 +22,25 @@ describe ProjectTransferService do
   end
   context 'namespace -> no namespace' do
-    let(:user) { create(:user) }
-    let(:project) { create(:project, namespace: user.namespace) }
+    before do
+      group.add_owner(user)
+      @service = Projects::TransferService.new(project, user, namespace_id: nil)
+      @service.gitlab_shell.stub(mv_repository: true)
+      @result = @service.execute
+    end
-    it { lambda{service.transfer(project, nil)}.should raise_error(ActiveRecord::RecordInvalid) }
+    it { @result.should be_false }
+    it { project.namespace.should == user.namespace }
   end
-  def service
-    service = ProjectTransferService.new
-    service.gitlab_shell.stub(mv_repository: true)
-    service
+  context 'namespace -> not allowed namespace' do
+    before do
+      @service = Projects::TransferService.new(project, user, namespace_id: group2.id)
+      @service.gitlab_shell.stub(mv_repository: true)
+      @result = @service.execute
+    end
+
+    it { @result.should be_false }
+    it { project.namespace.should == user.namespace }
   end
 end
-
	@@ -46,7 +46,7 @@ class ProjectsController < ApplicationController		@@ -46,7 +46,7 @@ class ProjectsController < ApplicationController
46	end	46	end
47		47
48	def transfer	48	def transfer
49	- ::Projects::TransferService.new(project, current_user, params).execute	49	+ ::Projects::TransferService.new(project, current_user, params[:project]).execute
50	end	50	end
51		51
52	def show	52	def show
1	module NamespacesHelper	1	module NamespacesHelper
2	def namespaces_options(selected = :current_user, scope = :default)	2	def namespaces_options(selected = :current_user, scope = :default)
3	- groups = current_user.owned_groups	3	+ groups = current_user.owned_groups + current_user.masters_groups
4	users = [current_user.namespace]	4	users = [current_user.namespace]
5		5
6	group_opts = ["Groups", groups.sort_by(&:human_name).map {\|g\| [g.human_name, g.id]} ]	6	group_opts = ["Groups", groups.sort_by(&:human_name).map {\|g\| [g.human_name, g.id]} ]
	@@ -1,46 +0,0 @@	@@ -1,46 +0,0 @@
1	-# ProjectTransferService class
2	-#
3	-# Used for transfer project to another namespace
4	-#
5	-class ProjectTransferService
6	- include Gitlab::ShellAdapter
7	-
8	- class TransferError < StandardError; end
9	-
10	- attr_accessor :project
11	-
12	- def transfer(project, new_namespace)
13	- Project.transaction do
14	- old_path = project.path_with_namespace
15	- new_path = File.join(new_namespace.try(:path) \|\| '', project.path)
16	-
17	- if Project.where(path: project.path, namespace_id: new_namespace.try(:id)).present?
18	- raise TransferError.new("Project with same path in target namespace already exists")
19	- end
20	-
21	- # Remove old satellite
22	- project.satellite.destroy
23	-
24	- # Apply new namespace id
25	- project.namespace = new_namespace
26	- project.save!
27	-
28	- # Move main repository
29	- unless gitlab_shell.mv_repository(old_path, new_path)
30	- raise TransferError.new('Cannot move project')
31	- end
32	-
33	- # Move wiki repo also if present
34	- gitlab_shell.mv_repository("#{old_path}.wiki", "#{new_path}.wiki")
35	-
36	- # Create a new satellite (reload project from DB)
37	- Project.find(project.id).ensure_satellite_exists
38	-
39	- # clear project cached events
40	- project.reset_events_cache
41	-
42	- true
43	- end
44	- end
45	-end
46	-
	@@ -97,7 +97,7 @@ module Projects		@@ -97,7 +97,7 @@ module Projects
97		97
98	def allowed_namespace?(user, namespace_id)	98	def allowed_namespace?(user, namespace_id)
99	namespace = Namespace.find_by(id: namespace_id)	99	namespace = Namespace.find_by(id: namespace_id)
100	- current_user.can?(:manage_namespace, namespace)	100	+ current_user.can?(:create_projects, namespace)
101	end	101	end
102	end	102	end
103	end	103	end
		1	+# Projects::TransferService class
		2	+#
		3	+# Used for transfer project to another namespace
		4	+#
		5	+# Ex.
		6	+# # Move projects to namespace with ID 17 by user
		7	+# Projects::TransferService.new(project, user, namespace_id: 17).execute
		8	+#
1	module Projects	9	module Projects
2	class TransferService < BaseService	10	class TransferService < BaseService
3	- def execute(role = :default)
4	- namespace_id = params[:project].delete(:namespace_id)
5	- allowed_transfer = can?(current_user, :change_namespace, project) \|\| role == :admin
6	-
7	- if allowed_transfer && namespace_id.present?
8	- if namespace_id.to_i != project.namespace_id
9	- # Transfer to someone namespace
10	- namespace = Namespace.find(namespace_id)
11	- project.transfer(namespace)
12	- end
13	- end	11	+ include Gitlab::ShellAdapter
		12	+ class TransferError < StandardError; end
		13	+
		14	+ def execute
		15	+ namespace_id = params.delete(:namespace_id)
		16	+ namespace = Namespace.find_by(id: namespace_id)
14		17
15	- rescue ProjectTransferService::TransferError => ex	18	+ if allowed_transfer?(current_user, project, namespace)
		19	+ transfer(project, namespace)
		20	+ else
		21	+ project.errors.add(:namespace, 'is invalid')
		22	+ false
		23	+ end
		24	+ rescue Projects::TransferService::TransferError => ex
16	project.reload	25	project.reload
17	project.errors.add(:namespace_id, ex.message)	26	project.errors.add(:namespace_id, ex.message)
18	false	27	false
19	end	28	end
		29	+
		30	+ def transfer(project, new_namespace)
		31	+ Project.transaction do
		32	+ old_path = project.path_with_namespace
		33	+ new_path = File.join(new_namespace.try(:path) \|\| '', project.path)
		34	+
		35	+ if Project.where(path: project.path, namespace_id: new_namespace.try(:id)).present?
		36	+ raise TransferError.new("Project with same path in target namespace already exists")
		37	+ end
		38	+
		39	+ # Remove old satellite
		40	+ project.satellite.destroy
		41	+
		42	+ # Apply new namespace id
		43	+ project.namespace = new_namespace
		44	+ project.save!
		45	+
		46	+ # Move main repository
		47	+ unless gitlab_shell.mv_repository(old_path, new_path)
		48	+ raise TransferError.new('Cannot move project')
		49	+ end
		50	+
		51	+ # Move wiki repo also if present
		52	+ gitlab_shell.mv_repository("#{old_path}.wiki", "#{new_path}.wiki")
		53	+
		54	+ # Create a new satellite (reload project from DB)
		55	+ Project.find(project.id).ensure_satellite_exists
		56	+
		57	+ # clear project cached events
		58	+ project.reset_events_cache
		59	+
		60	+ true
		61	+ end
		62	+ end
		63	+
		64	+ def allowed_transfer?(current_user, project, namespace)
		65	+ namespace &&
		66	+ can?(current_user, :change_namespace, project) &&
		67	+ namespace.id != project.namespace_id &&
		68	+ current_user.can?(:create_projects, namespace)
		69	+ end
20	end	70	end
21	end	71	end
22	-
1	.ui-box	1	.ui-box
2	.title	2	.title
3	Projects (#{projects.count})	3	Projects (#{projects.count})
4	- - if can? current_user, :manage_group, @group	4	+ - if can? current_user, :create_projects, @group
5	%span.pull-right	5	%span.pull-right
6	= link_to new_project_path(namespace_id: @group.id), class: "btn btn-new" do	6	= link_to new_project_path(namespace_id: @group.id), class: "btn btn-new" do
7	%i.icon-plus	7	%i.icon-plus
	@@ -40,7 +40,7 @@ If a user is a GitLab administrator they receive all permissions.		@@ -40,7 +40,7 @@ If a user is a GitLab administrator they receive all permissions.
40	\|------\|-----\|--------\|---------\|------\|-----\|	40	\|------\|-----\|--------\|---------\|------\|-----\|
41	\|Browse group\|✓\|✓\|✓\|✓\|✓\|	41	\|Browse group\|✓\|✓\|✓\|✓\|✓\|
42	\|Edit group\|\|\|\|\|✓\|	42	\|Edit group\|\|\|\|\|✓\|
43	-\|Create project in group\|\|\|\|\|✓\|	43	+\|Create project in group\|\|\|\|✓\|✓\|
44	\|Manage group members\|\|\|\|\|✓\|	44	\|Manage group members\|\|\|\|\|✓\|
45	\|Remove group\|\|\|\|\|✓\|	45	\|Remove group\|\|\|\|\|✓\|
46		46
	@@ -1,111 +0,0 @@	@@ -1,111 +0,0 @@
1	-namespace :gitlab do
2	- desc "GITLAB \| Enable usernames and namespaces for user projects"
3	- task enable_namespaces: :environment do
4	- warn_user_is_not_gitlab
5	-
6	- migrate_user_namespaces
7	- migrate_groups
8	- migrate_projects
9	- end
10	-
11	- def migrate_user_namespaces
12	- puts "\nGenerate usernames for users without one: ".blue
13	- User.find_each(batch_size: 500) do \|user\|
14	- if user.namespace
15	- print '-'.cyan
16	- next
17	- end
18	-
19	- username = if user.username.present?
20	- # if user already has username filled
21	- user.username
22	- else
23	- build_username(user)
24	- end
25	-
26	- begin
27	- User.transaction do
28	- user.update_attributes!(username: username)
29	- print '.'.green
30	- end
31	- rescue
32	- print 'F'.red
33	- end
34	- end
35	- puts "\nDone"
36	- end
37	-
38	- def build_username(user)
39	- username = nil
40	-
41	- # generate username
42	- username = user.email.match(/^[^@]*/)[0]
43	- username.gsub!("+", ".")
44	-
45	- # return username if no matches
46	- return username unless User.find_by(username: username)
47	-
48	- # look for same username
49	- (1..10).each do \|i\|
50	- suffixed_username = "#{username}#{i}"
51	-
52	- return suffixed_username unless User.find_by(username: suffixed_username)
53	- end
54	- end
55	-
56	- def migrate_groups
57	- puts "\nCreate directories for groups: ".blue
58	-
59	- Group.find_each(batch_size: 500) do \|group\|
60	- begin
61	- if group.dir_exists?
62	- print '-'.cyan
63	- else
64	- if group.ensure_dir_exist
65	- print '.'.green
66	- else
67	- print 'F'.red
68	- end
69	- end
70	- rescue
71	- print 'F'.red
72	- end
73	- end
74	- puts "\nDone"
75	- end
76	-
77	- def migrate_projects
78	- git_path = Gitlab.config.gitlab_shell.repos_path
79	- puts "\nMove projects in groups into respective directories ... ".blue
80	- Project.where('namespace_id IS NOT NULL').find_each(batch_size: 500) do \|project\|
81	- next unless project.group
82	-
83	- group = project.group
84	-
85	- print "#{project.name_with_namespace.yellow} ... "
86	-
87	- new_path = File.join(git_path, project.path_with_namespace + '.git')
88	-
89	- if File.exists?(new_path)
90	- puts "already at #{new_path}".green
91	- next
92	- end
93	-
94	- old_path = File.join(git_path, project.path + '.git')
95	-
96	- unless File.exists?(old_path)
97	- puts "couldn't find it at #{old_path}".red
98	- next
99	- end
100	-
101	- begin
102	- project.transfer(group.path)
103	- puts "moved to #{new_path}".green
104	- rescue
105	- puts "failed moving to #{new_path}".red
106	- end
107	- end
108	-
109	- puts "\nDone"
110	- end
111	-end