Download as
Browse Code »

Commit 23e2ec6bf28920aa55da1f0382b2a9a6eb27f412

Authored by Dmitriy Zaporozhets
2 parents 7ddbc92a 5bda665d
Exists in spb-stable and in 3 other branches 6-8-stable, 7-0-stable, 7-0-stable-spb

Merge branch 'check-css' into 'master' 

Check Css

Based on Dmitriy his remark https://gitlab.slack.com/archives/general/p1395770459000142
Showing 1 changed file with 1 additions and 0 deletions   Show diff stats
CONTRIBUTING.md
  Diff comments   View file @23e2ec6
@@ -67,6 +67,7 @@ If you can, please submit a merge request with the fix or improvements including @@ -67,6 +67,7 @@ If you can, please submit a merge request with the fix or improvements including
67 1. The MR title should describes the change you want to make 67 1. The MR title should describes the change you want to make
68 1. The MR description should give a motive for your change and the method you used to achieve it 68 1. The MR description should give a motive for your change and the method you used to achieve it
69 1. If the MR changes the UI it should include before and after screenshots 69 1. If the MR changes the UI it should include before and after screenshots
  70 +1. If the MR changes CSS classes please include the list of affected pages `grep css-class ./app -R`
70 1. Link relevant [issues](https://gitlab.com/gitlab-org/gitlab-ce/issues) and/or [feature requests](http://feedback.gitlab.com/) from the merge request description and leave a comment on them with a link back to the MR 71 1. Link relevant [issues](https://gitlab.com/gitlab-org/gitlab-ce/issues) and/or [feature requests](http://feedback.gitlab.com/) from the merge request description and leave a comment on them with a link back to the MR
71 1. Be prepared to answer questions and incorporate feedback even if requests for this arrive weeks or months after your MR submittion 72 1. Be prepared to answer questions and incorporate feedback even if requests for this arrive weeks or months after your MR submittion
72 1. If your MR touches code that executes shell commands, make sure it adheres to the [shell command guidelines]( doc/development/shell_commands.md). 73 1. If your MR touches code that executes shell commands, make sure it adheres to the [shell command guidelines]( doc/development/shell_commands.md).