Download as
Browse Code »

Commit 2db4d8f844d36a741c47d7d978f701c953d235ec

Authored by Dmitriy Zaporozhets
2 parents 28eb6c69 6adbfda2
Exists in spb-stable and in 3 other branches 6-8-stable, 7-0-stable, 7-0-stable-spb

Merge pull request #6593 from jvanbaarsen/mr-template 

Added some extra information how a good MR looks like
Showing 1 changed file with 8 additions and 0 deletions   Show diff stats
CONTRIBUTING.md
  Diff comments   View file @2db4d8f
... ... @@ -77,6 +77,14 @@ Please keep the change in a single MR **as small as possible**. If you want to c
77 77  
78 78 For examples of feedback on merge requests please look at already [closed merge requests](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests?assignee_id=&label_name=&milestone_id=&scope=&sort=&state=closed). Please ensure that your merge request meets the following contribution acceptance criteria.
79 79  
  80 +**Please format your merge request description as follows:**
  81 +
  82 +1. What does this MR do?
  83 +2. Are there points in the code the reviewer needs to double check?
  84 +3. Why was this MR needed?
  85 +4. What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
  86 +5. Screenshots (If appropiate)
  87 +
80 88 ## Contribution acceptance criteria
81 89  
82 90 1. The change is as small as possible (see the above paragraph for details)
... ...