Log if satellite creation failed

Dmitriy Zaporozhets
1 parent 5d1044c3
Showing 1 changed file with 7 additions and 1 deletions Show diff stats
lib/gitlab/satellite/satellite.rb
@@ -18,7 +18,13 @@ module Gitlab
       end
  
       def create
-        `git clone #{project.url_to_repo} #{path}`
+        create_cmd = "git clone #{project.url_to_repo} #{path}"
+        if system(create_cmd)
+          true
+        else
+          Gitlab::GitLogger.error("Failed to create satellite for #{project.name_with_namespace}")
+          false
+        end
       end
  
       def exists?
...	...	@@ -18,7 +18,13 @@ module Gitlab
18	18	end
19	19
20	20	def create
21		- `git clone #{project.url_to_repo} #{path}`
	21	+ create_cmd = "git clone #{project.url_to_repo} #{path}"
	22	+ if system(create_cmd)
	23	+ true
	24	+ else
	25	+ Gitlab::GitLogger.error("Failed to create satellite for #{project.name_with_namespace}")
	26	+ false
	27	+ end
22	28	end
23	29
24	30	def exists?
...	...