Download as
Browse Code »

Commit 468c8c5f0a66a9ebf1489926ba32c19db71d821a

Authored by Andrew8xx8
1 parent 08f665cf
Exists in master and in 4 other branches 6-8-stable, 7-0-stable, 7-0-stable-spb, spb-stable

A little bit of codestyle improvments

Showing 1 changed file with 9 additions and 10 deletions   Show diff stats
app/observers/system_hook_observer.rb
  Diff comments   View file @468c8c5
1 1 class SystemHookObserver < ActiveRecord::Observer
2 2 observe :user, :project, :users_project
3   -
  3 +
4 4 def after_create(model)
5   - if model.kind_of? Project
  5 + case model
  6 + when Project
6 7 SystemHook.all_hooks_fire({
7 8 event_name: "project_create",
8 9 name: model.name,
... ... @@ -12,15 +13,14 @@ class SystemHookObserver &lt; ActiveRecord::Observer
12 13 owner_email: model.owner.email,
13 14 created_at: model.created_at
14 15 })
15   - elsif model.kind_of? User
  16 + when User
16 17 SystemHook.all_hooks_fire({
17 18 event_name: "user_create",
18 19 name: model.name,
19 20 email: model.email,
20 21 created_at: model.created_at
21 22 })
22   -
23   - elsif model.kind_of? UsersProject
  23 + when UsersProject
24 24 SystemHook.all_hooks_fire({
25 25 event_name: "user_add_to_team",
26 26 project_name: model.project.name,
... ... @@ -31,12 +31,12 @@ class SystemHookObserver &lt; ActiveRecord::Observer
31 31 project_access: model.repo_access_human,
32 32 created_at: model.created_at
33 33 })
34   -
35 34 end
36 35 end
37 36  
38 37 def after_destroy(model)
39   - if model.kind_of? Project
  38 + case model
  39 + when Project
40 40 SystemHook.all_hooks_fire({
41 41 event_name: "project_destroy",
42 42 name: model.name,
... ... @@ -45,14 +45,13 @@ class SystemHookObserver &lt; ActiveRecord::Observer
45 45 owner_name: model.owner.name,
46 46 owner_email: model.owner.email,
47 47 })
48   - elsif model.kind_of? User
  48 + when User
49 49 SystemHook.all_hooks_fire({
50 50 event_name: "user_destroy",
51 51 name: model.name,
52 52 email: model.email
53 53 })
54   -
55   - elsif model.kind_of? UsersProject
  54 + when UsersProject
56 55 SystemHook.all_hooks_fire({
57 56 event_name: "user_remove_from_team",
58 57 project_name: model.project.name,
... ...